Commit Graph

218 Commits

Author SHA1 Message Date
Zuul 6966c7de68 Merge "Add support for image_cache_driver option" 2024-03-07 18:03:40 +00:00
Zuul 8e4ccdfe04 Merge "Refactor resource dependencies" 2024-03-05 03:50:52 +00:00
Takashi Kajinami e12c8754d2 Add support for image_cache_driver option
... so that users can select non-default drivers such as centralized_db
driver.

Change-Id: I8d9d9161b46c47d09c31baff2f732a532640f208
2024-03-05 11:24:37 +09:00
Takashi Kajinami 8b3054a13f Refactor resource dependencies
This refactors resource dependencies to improve the following points.

 - Avoid unnecessary dependencies across services. For example aodh
   service does not require cinder db.

 - Restart only api service when config files like paste.ini, which
   are used only be api service is changed.

Change-Id: I6a4c65e81b97235d0ce8a142245927c92ab6e48d
2024-03-04 09:49:06 +09:00
Takashi Kajinami 6b44259135 Deprecate support for delayed_delete option
... because this option was deprecated as part of deprecation of
glance-scrubber.

Depends-on: https://review.opendev.org/910042
Change-Id: I9862d999025dd63dcbac4f33faeaad4fa6c1ada9
2024-02-27 09:05:50 +09:00
Takashi Kajinami c9e79c84cb Deprecate support for [DEFAULT] location_strategy
... because the option was deprecated in glance.

Depneds-on: https://review.opendev.org/c/openstack/glance/+/906317
Change-Id: I44a7ecf52972c88f1ca6b41236f4757e0fcff3f8
2024-01-23 17:24:28 +09:00
Takashi Kajinami b1aaafa39b Add [DEFAULT] lock_path to glance-cache.conf
This option is required to access image data when cinder backend is
used.

Related-Bug: #2034893
Change-Id: Ic5e1d1c55fe31d48b8c9605beaabbc12446682dd
2023-09-11 10:44:08 +09:00
Takashi Kajinami 10d7bbdeef Add all store options to glance-cache.conf
The glance-cache.conf is used by the glance-cache-prefetcher command
which requires access to backend store. Thus all store options should
be added to the glance-cache.conf file so that backend store can be
loaded properly.

Closes-Bug: #2034893
Change-Id: I8f0b2be8b138d267364f20ff81876902b225d29e
2023-09-08 18:56:20 +09:00
Takashi Kajinami 357e761bf7 Fix legacy backend class usage with multi_store=false
Using legacy backend class (eg glance::backend::file) with multi_store
set to false(default) has been broken, because of duplicate declaration
of [glance_store] default_store option.

This fixes that problem.

Change-Id: Ibb12bdb8333fc91e2dc95c2c2cc4de79f2c82cc1
2023-09-08 15:30:24 +09:00
Takashi Kajinami c37af7627c Ensure purge_config takes a boolean value
The purge_config parameters only accept boolean values. This enforces
that using the typed parameters.

Change-Id: I68260f896eb4b94661685a2ebf76500b0cf409a6
2023-07-18 00:52:27 +09:00
Takashi Kajinami 6e4402417a Fix undefined variable
The default_store_real variable is not defined in some code paths and
that is causing the following error when Puppet 8 is used.

```
Evaluation Error: Unknown variable: 'default_store_real'.
```

Change-Id: I8220b646de922e44e08db49817b473789e2742f8
2023-06-26 22:05:22 +09:00
Takashi Kajinami 2912393664 Remove redundant handling of empty flavor
Setting an empty string('') to [paste_deploy] flavor results in
the exactly same behavior as removing the [paste_deploy] flavor option.

Thus we don't really need the special treatment for an empty string.

Change-Id: Ib50da09ac6fd2499fc922d5d0e1115cd600ecb69
2023-06-19 18:33:52 +09:00
Takashi Kajinami 945280277f replace validate_legacy with proper data types
the validate_legacy function is marked for deprecation in
v9.0.0 from puppetlabs-stdlib.

Note that this change removes the pattern validation about [DEFAULT]
pipeline. The existing pattern check is incomplete, because of
the following two reasons.
 - the pattern does not guarantee that the requested pipeline is
   really supported or not
 - the pattern accepts a+b+c but the existing pipelines in glance
   does not have any entries with this pattern

Change-Id: I156d9a3a30ba6c523a0b16a14bf8a1839b61fb78
2023-06-19 18:33:38 +09:00
Takashi Kajinami 2f23343e4f Use static name for package resource
... instead of using the actual package name. This helps users to
identify the resource name more easily.

Change-Id: Icc6a27685f3b3747b4e0562eb8066aa3cce5516c
2023-03-20 00:47:47 +09:00
Takashi Kajinami 2cdc2b2176 Add strict validation about boolean parameters
This ensures the parameters used by if-else logic accept only boolean
values because non-boolean can result in unexpected behavior.

Change-Id: Ie3fce5786d44be38fad176442a0a0f9b24faab77
2023-03-17 02:23:27 +00:00
Takashi Kajinami 8b0f7ea16d Remove deprecated cache_prefetcher_interval
This parameter was deprecated during the previous cycle[1] and has had
no effect since then.

[1] 89857141d1

Change-Id: I21e59483cef2847b02783a13072745a9f434a318
2023-03-10 18:30:45 +09:00
Takashi Kajinami 43735fb127 Replace legacy facts and use fact hash
... because the latest lint no longer allows usage of legacy facts and
top scope fact.

Change-Id: Iebdb33dd18a8f8d18840ff3e5f4608f021a78bfa
2023-03-02 10:54:36 +09:00
Tobias Urdin cad31f4a21 Set bind_port in glance::api to $::os_service_default
Change-Id: I9e606a77f47ecceb22ca1a57adfa3e9d2be441f7
2023-02-23 15:09:21 +00:00
Takashi Kajinami 89f9a6b3fb api: Remove deprecated scrub_time
This parameter was deprecated during the past cycle because it is not
used by glance-api actually[1], and has had no effect since then.

[1] bd6fb8f175

Change-Id: Ic4f2ed44fa4e7263d2e4c6d3ae3e255fdf798aa2
2023-01-10 09:58:23 +09:00
Zuul d61047c7d3 Merge "Clean up parameters for service validation" 2022-12-12 07:51:00 +00:00
Takashi Kajinami 493c828900 Remove parameters for native ssl support
These parameters were deprecated during the previous cycle by [1] and
have had no effect. These parameters are not really used by recent
glance.

[1] 2a2f349d8a

Depends-on: https://review.opendev.org/865924
Related-Bug: #1965776
Change-Id: Ia24b57966f6d8aee5cfa56cfe3496f1d81924ea1
2022-11-29 01:16:59 +00:00
Takashi Kajinami 58b9a1c3bc Clean up parameters for service validation
... service validation was deprecated during Yoga cycle by [1].
The parameters were left for interface compatibility but have had no
effect since then.

[1] 3d5c217596daeafe7620273ab7a0b5dd9ee2d194

Change-Id: I4b2fa2f250576eb811d66c4925f0b9a5cf6bb3ee
2022-11-28 22:46:46 +09:00
Zuul 0176638d47 Merge "Deprecate support for [DEFAULT] cache_prefetcher_interval" 2022-09-08 14:32:26 +00:00
Takashi Kajinami 89857141d1 Deprecate support for [DEFAULT] cache_prefetcher_interval
... because the parameter was already removed from Glance.

Depends-on: https://review.opendev.org/c/openstack/glance/+/842070
Change-Id: I6a8029e9f85ef0511fe52292901fc66fc437b57b
2022-09-08 01:22:57 +09:00
Trygve Vea 709b83b390 Add new option for api: public_endpoint
When running glance-api behind a proxy or load balancer that hides
glance behind an extended base URL, it is necessary to provide
information about the base URL to glance-api to ensure that clients
know where to pass subsequent requests.

Change-Id: I9bebee01c2580f0500a069f5ab57ac2a8c329389
2022-08-29 14:02:09 +00:00
Takashi Kajinami 3aa1e7697d Remove deprecated keymgr_* parameters
These were deprecated during Xena cycle in favor of the new separate
classes to customize key manager[1].

[1] bc7651fa5f

Change-Id: Id3395fd58cbdd7e686a08c8369cd38c3e322628b
2022-08-16 15:40:18 +00:00
Takashi Kajinami b91d905887 Remove deprecated glance::os_region_name
It was deprecated during Ussuri cycle by [1].

[1] 9e82f598ad

Change-Id: Iab8fe79beedbe8cae0a5e6f6bd7c8a0b2d1e74c0
2022-08-17 00:39:59 +09:00
Takashi Kajinami 53eefc2d95 Add support for running glance-api by httpd+mod_wsgi
This change introduces a basic implementation to run glance-api as
an application managed by httpd+mod_wsgi, instead of a standalone
eventlet server.

Change-Id: I9421ec891c535503ff61ad6107a1935a32b4b263
2022-07-15 10:33:39 +09:00
Takashi Kajinami fa5fcb4ab5 Add support for [paste_deploy] config_file
... so that users can customize that option using the native interface.
In TripleO we append additional arguments(to load glance-cache.conf)
and we need to set the option explicitly to ensure the correct file
path is used.

Also, the pipeline parameter is confusing because of its naming
different from the actual parameter in Glance, so this change renames
the parameter as well.

Change-Id: I3d6ce07f44ae526207a30d4b57c2fec7cd6fa3ca
2022-07-14 13:47:13 +00:00
Alan Bishop 6f61ecd9c5 Configure the oslo.concurrency lock_path
A recent change in os-brick [1], which is used by cinder backends,
requires external file locks. This patch adds support for configuring
the lock path, with a default value that matches the corresponding
lock paths used by other services that use os-brick (namely cinder
and nova).

[1] I6f7f7d19540361204d4ae3ead2bd6dcddb8fcd68

Closes-Bug: #1980539
Change-Id: I5ea6766656f4227a1c514777c03bbf78d4ac59cd
2022-07-01 21:47:45 -07:00
Takashi Kajinami 0e6fd040e5 Deprecate support for [glance_store] filesystem_store_* options
... because these options are used only when legacy store is used,
which has been deprecated in favor of multi store.

Change-Id: Ib5cef2869b241d26bbe2fc0a71b05942e03fe512
2022-06-22 15:11:55 +00:00
Rajesh Tailor 499a898468 Fix typos in parameter descriptions
Change-Id: Iacebc227e074da592aa0ca8ff6f8226f3e850a66
2022-06-17 16:17:30 +00:00
Takashi Kajinami 5d977c750a Ensure [DEFAULT] show_multiple_locations is cleared
The parameter was already deprecated, but it is still required in
some setup (eg. to leverage in-storage copy in a deployment with Ceph
used for cinder/glance).

Considering the parameter is still valid, this change ensures it is
removed by default, so that old value is properly removed from config
file.

Change-Id: I2477d5e271b017ee12546c67f4c3f3f9be89c062
2022-04-25 18:26:29 +09:00
Takashi Kajinami 2a2f349d8a Deprecate parameters for native ssl support
Glance removed native ssl support during Ussuri cycle[1]. This change
deprecates the remaining parameters to set up the feature, so that
we can remove these ineffective parameters in a future release.

[1] 06b2465f598c014451c244d47c2ded4f1e2c6947

Closes-Bug: #1965776
Change-Id: Ie4a984a4b7136304425588856eabff2e60d1cbba
2022-03-22 17:17:00 +00:00
Takashi Kajinami a37cdd923e Disallow sheepdog backend
... because it was removed during Ussuri cycle[1].

[1] 5c9db72a93356876fabab2b294bced61a67105fe

Change-Id: Ic7a01c9ca60196f89750026e7540a39c41e07cd3
2022-02-10 13:29:04 +09:00
Takashi Kajinami 9112b1af86 Clean up deprecated database parameters
Change-Id: Ie04052b937e501f1e3d8659a773575755e8286b5
2022-01-31 21:04:11 +09:00
Takashi Kajinami bd6fb8f175 api: Deprecate ineffective scrub_time
The scrub_time parameter is not used by glance-api. The parameter is
used by glance-scrubber which is not yet supported by puppet-glance,
and should be added to glance-scrubber.conf instead.

This change deprecates the parameter because it has been ineffective.

Change-Id: I12ed8285a2a048880b5a263958f0aba62128ca58
2022-01-10 13:41:21 +09:00
Takashi Kajinami f3754c8c1f Deprecate service validation for glance-api
Following the past deprecation in puppet-keystone[1], this change
deprecates service validation for glance-api.

[1] 3c95205e0253895e477b9135c10f5175d4166cfc

Change-Id: Icf44d49d68a345b0ac910918a3b4208e1c23aec9
2021-12-14 08:12:32 +09:00
Zuul 6927139f6a Merge "Add support of keystone unified limits from glance to use quotas" 2021-11-12 18:57:13 +00:00
Pranali Deore 26cd418b60 Add support of keystone unified limits from glance to use quotas
Adding 'use_keystone_limits' parameter, which will allow Glance to
retrieve limits set in keystone for resource consumption and enforce
them against API users.

Depends-on: https://review.opendev.org/812766
Change-Id: I5977d0cd62454d70028a25aaa6206b490884f325
2021-11-12 17:25:57 +09:00
Takashi Kajinami d40184a77c Do not manage the glance-api service when manage_service is disabled
Change-Id: Ie953021f975cc009a329b23ed0c933066b6541c9
2021-11-10 22:37:36 +09:00
Takashi Kajinami a07bd45712 Add support for more quota parameters
Change-Id: Ic53be0bdd02677a4a6d328acad4c75885871b3a2
2021-10-05 21:48:00 +09:00
Takashi Kajinami ef245de870 Fix wrong parameter name in deprecation warning
Change-Id: I48ca661a1cd9e7000d24984a8f2586aac4d15e93
2021-08-23 08:44:04 +09:00
Takashi Kajinami bc7651fa5f Create independent classes for key managers
This change introduces the new independent classes to manage options
for key managers, which are implemented in the castellan library.

Depends-on: https://review.opendev.org/772676
Change-Id: Id54b87472ae67a9005276e52de9dd68172e22eff
2021-05-08 23:33:19 +09:00
Pranali Deore fdb2c555fd Add new parameter required for secure RBAC configuration
Glance has added support for project persona of secure RBAC as
an experimental feature where 'enforce_secure_rbac' has been introduced.

Adding support of 'enforce_secure_rbac' parameter here.

Partially Implements: blueprint secure-rbac

Change-Id: I1db7fa2694bc9a448a47e435cfd95264504086c6
2021-04-14 01:31:03 +00:00
Zuul 117d80aea8 Merge "Clean up remaining items for glance-registry" 2021-03-26 06:44:08 +00:00
Takashi Kajinami 2ae1115e42 Clean up remaining items for glance-registry
This change drops remaining items about support for glance-registry.
These were deprecated by the removal patch[1] which was merged during
the previous cycle thus we are now ready to drop them.

[1] 11599ba429

Change-Id: If2d371a372cf4d95d84e3d71fb4ce272565ac659
2021-03-17 07:41:23 +09:00
Pranali Deore d05a5760c7 Add new conf parameter required for distribute image import
To support distributed image import new configuration parameter
'worker_self_reference_url' has been added.

Adding support of 'worker_self_reference_url' parameter.

Change-Id: Ib14a126bde1ecc2e55b0f5bace06a81c9cfa1011
2021-03-16 18:07:34 +05:30
Takashi Kajinami 10f14f29b1 Deprecate database options from the glance::api class
... because these options have been implemented in the glance::api::db
class.

Change-Id: Ib153455d48f59d440803e26570986854cb6e0299
2020-10-21 09:44:55 +09:00
Takashi Kajinami 4af7ebd6bc Simplfy logic to generate list opts
Change-Id: Ia0f0fd0c6633e658c20351cf1e1d62a495361552
2020-10-12 19:21:00 +09:00