openstack
/
puppet-glare
Code Issues Proposed changes

oslo log: check puppet resource instead of actual config in spec 

Change-Id: I892f333e069604ae04e3e9af04622edd32a3451c
This commit is contained in:
Mykyta Karpin 2017-04-07 12:38:29 +03:00
parent abbf6d8347
commit d22ad66cc2
1 changed files with 36 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

84
spec/classes/glare_logging_spec.rb
View File

@ -17,8 +17,7 @@ describe 'glare::logging' do
:publish_errors => true,
:default_log_levels => {
'amqp' => 'WARN', 'amqplib' => 'WARN', 'boto' => 'WARN',
'qpid' => 'WARN', 'sqlalchemy' => 'WARN', 'suds' => 'INFO',
'iso8601' => 'WARN',
'sqlalchemy' => 'WARN', 'suds' => 'INFO', 'iso8601' => 'WARN',
'requests.packages.urllib3.connectionpool' => 'WARN' },
:fatal_deprecations => true,
:instance_format => '[instance: %(uuid)s] ',
@ -28,7 +27,7 @@ describe 'glare::logging' do
:use_stderr => false,
:syslog_log_facility => 'LOG_FOO',
:log_dir => '/var/log',
:log_file => '/var/log/glare.log',
:log_file => '/var/tmp/glare_random.log',
:debug => true,
}
end
@ -57,63 +56,52 @@ describe 'glare::logging' do
shared_examples 'basic default logging settings' do
it 'configures glare logging settings with default values' do
is_expected.to contain_glare_config('DEFAULT/use_syslog').with(:value => '<SERVICE DEFAULT>')
is_expected.to contain_glare_config('DEFAULT/use_stderr').with(:value => '<SERVICE DEFAULT>')
is_expected.to contain_glare_config('DEFAULT/syslog_log_facility').with(:value => '<SERVICE DEFAULT>')
is_expected.to contain_glare_config('DEFAULT/log_dir').with(:value => '/var/log/glare')
is_expected.to contain_glare_config('DEFAULT/log_file').with(:value => '/var/log/glare/glare.log')
is_expected.to contain_glare_config('DEFAULT/debug').with(:value => '<SERVICE DEFAULT>')
is_expected.to contain_oslo__log('glare_config').with(
:use_syslog => '<SERVICE DEFAULT>',
:use_stderr => '<SERVICE DEFAULT>',
:syslog_log_facility => '<SERVICE DEFAULT>',
:log_dir => '/var/log/glare',
:log_file => '/var/log/glare/glare.log',
:debug => '<SERVICE DEFAULT>',
)
end
end
shared_examples 'basic non-default logging settings' do
it 'configures glare logging settings with non-default values' do
is_expected.to contain_glare_config('DEFAULT/use_syslog').with(:value => 'true')
is_expected.to contain_glare_config('DEFAULT/use_stderr').with(:value => 'false')
is_expected.to contain_glare_config('DEFAULT/syslog_log_facility').with(:value => 'LOG_FOO')
is_expected.to contain_glare_config('DEFAULT/log_dir').with(:value => '/var/log')
is_expected.to contain_glare_config('DEFAULT/log_file').with(:value => '/var/log/glare.log')
is_expected.to contain_glare_config('DEFAULT/debug').with(:value => 'true')
is_expected.to contain_oslo__log('glare_config').with(
:use_syslog => true,
:use_stderr => false,
:syslog_log_facility => 'LOG_FOO',
:log_dir => '/var/log',
:log_file => '/var/tmp/glare_random.log',
:debug => true,
)
end
end
shared_examples_for 'logging params set' do
it 'enables logging params' do
is_expected.to contain_glare_config('DEFAULT/logging_context_format_string').with_value(
'%(asctime)s.%(msecs)03d %(process)d %(levelname)s %(name)s [%(request_id)s %(user_identity)s] %(instance)s%(message)s')
is_expected.to contain_glare_config('DEFAULT/logging_default_format_string').with_value(
'%(asctime)s.%(msecs)03d %(process)d %(levelname)s %(name)s [-] %(instance)s%(message)s')
is_expected.to contain_glare_config('DEFAULT/logging_debug_format_suffix').with_value(
'%(funcName)s %(pathname)s:%(lineno)d')
is_expected.to contain_glare_config('DEFAULT/logging_exception_prefix').with_value(
'%(asctime)s.%(msecs)03d %(process)d TRACE %(name)s %(instance)s')
is_expected.to contain_glare_config('DEFAULT/log_config_append').with_value(
'/etc/glare/logging.conf')
is_expected.to contain_glare_config('DEFAULT/publish_errors').with_value(
true)
is_expected.to contain_glare_config('DEFAULT/default_log_levels').with_value(
'amqp=WARN,amqplib=WARN,boto=WARN,iso8601=WARN,qpid=WARN,requests.packages.urllib3.connectionpool=WARN,sqlalchemy=WARN,suds=INFO')
is_expected.to contain_glare_config('DEFAULT/fatal_deprecations').with_value(
true)
is_expected.to contain_glare_config('DEFAULT/instance_format').with_value(
'[instance: %(uuid)s] ')
is_expected.to contain_glare_config('DEFAULT/instance_uuid_format').with_value(
'[instance: %(uuid)s] ')
is_expected.to contain_glare_config('DEFAULT/log_date_format').with_value(
'%Y-%m-%d %H:%M:%S')
is_expected.to contain_oslo__log('glare_config').with(
:logging_context_format_string =>
'%(asctime)s.%(msecs)03d %(process)d %(levelname)s %(name)s [%(request_id)s %(user_identity)s] %(instance)s%(message)s',
:logging_default_format_string => '%(asctime)s.%(msecs)03d %(process)d %(levelname)s %(name)s [-] %(instance)s%(message)s',
:logging_debug_format_suffix => '%(funcName)s %(pathname)s:%(lineno)d',
:logging_exception_prefix => '%(asctime)s.%(msecs)03d %(process)d TRACE %(name)s %(instance)s',
:log_config_append => '/etc/glare/logging.conf',
:publish_errors => true,
:default_log_levels => {
'amqp' => 'WARN', 'amqplib' => 'WARN', 'boto' => 'WARN',
'sqlalchemy' => 'WARN', 'suds' => 'INFO', 'iso8601' => 'WARN',
'requests.packages.urllib3.connectionpool' => 'WARN' },
:fatal_deprecations => true,
:instance_format => '[instance: %(uuid)s] ',
:instance_uuid_format => '[instance: %(uuid)s] ',
:log_date_format => '%Y-%m-%d %H:%M:%S',
)
end
end
shared_examples_for 'logging params unset' do
[ :logging_context_format_string, :logging_default_format_string,
:logging_debug_format_suffix, :logging_exception_prefix,
@ -121,7 +109,7 @@ describe 'glare::logging' do
:default_log_levels, :fatal_deprecations,
:instance_format, :instance_uuid_format,
:log_date_format, ].each { |param|
it { is_expected.to contain_glare_config("DEFAULT/#{param}").with_value('<SERVICE DEFAULT>') }
it { is_expected.to contain_oslo__log('glare_config').with("#{param}" => '<SERVICE DEFAULT>') }
}
end