Commit Graph

11 Commits

Author SHA1 Message Date
Takashi Kajinami 02599a4e70 Remove usage of deleted manifest_dir
Recent update in rspec-puppet removed some of the config interfaces for
old puppet versions[1]. This drops usage of these interfaces to resolve
the following error in unit tests.

```
An error occurred while loading ./spec/unit/provider/manila_spec.rb.
Failure/Error: c.manifest_dir = File.join(fixture_path, 'manifests')

NoMethodError:
  undefined method `manifest_dir='...
```

[1] 316d95923c

Change-Id: I966e5e3178847d34910cdc91610adbd88d4d6089
2023-10-11 12:00:18 +09:00
Takashi Kajinami f2f27f8e76 Load libraries in a single place
This change refactors how the dependent libraries are loaded during
unit tests, and load the libraries in the base spec_helper to avoid
duplicate and redundant implementations.

Change-Id: Ia4f1a4a731de0a0ee2e4ebc47e0628fbf5f58436
2021-12-27 10:38:36 +09:00
Takashi Kajinami bd7d486b52 Set fixture paths for unit tests
This change defines manifest_dir and module_path expicitly in unit
tests so that modules installed under fixtures directory is properly
loaded.

Closes-Bug: #1930403
Change-Id: Ifd966b0f62cd5f682d5ba70927597d6923f3fa47
2021-06-02 13:59:58 +09:00
Alex Schultz 86daa8c830 Move rspec-puppet-facts to spec helper
This change updates the module to use the rspec-puppet-facts as defined
in the puppet-openstack_spec_helper.

Change-Id: I01188e4d2f6f60539c336cba9d8695c232a62386
2016-09-30 13:19:20 -06:00
Emilien Macchi 5b938affec drop mock dependency
mock is not used anywhere in the module, let's drop it.
This patch will help to hit this bug:
https://launchpad.net/bugs/1492636

Change-Id: I227fb1c5203a90d3929d99042e543d3ecc8590ee
2016-01-22 09:45:34 -05:00
Alex Schultz ae2e7760b3 Add rspec-puppet-facts to the spec_helper
This change adds the rspec-puppet-facts gem to the spec helper so that
we can centralize the management of the base operating systems that we
support. rspec-puppet-facts allows us to simplify our unit tests and
provides a more complete list of Operating Systems and their associated
facts for the unit tests.  With this change we can now loop over and
test CentOS, Debian, Fedora, RedHat, and Ubuntu by simply providing a
list of supported os to rspec-puppet-facts.

Additionally this change includes a central object for managing our
supported os list for rspec-puppet-facts and providing our default facts
like os_service_default. This central object should replace the usage of
@default_facts within the unit tests for each module.

Change-Id: If05b890b9d1b60a4f0561f35e525259e66895360
2016-01-14 18:52:27 +03:00
Mykyta Karpin d57948dcfe Add os_service_default support to heat tests
Heat classes tests are modified to support
	os_service_default facts.

Change-Id: Ie8201de4158f1442eade93fee042453f4effb34c
2015-11-18 13:57:58 +02:00
Cody Herriges 4fa9985f2a Initial msync run for all Puppet OpenStack modules
This patch is the initial modulesync run, it impacts:

* gitignore: just a sync between projects
* gemfile:
  - update and allow to setup facter version and gem source
  - split beaker gems with a dedicated group
  - switch to rspec-puppet 2.2.0
* rakefile:
  - use the new syntax for lint configuration
  - add a acceptance target
* acceptance:
  - sync nodesets
* spec: added rspec coverage report

Change-Id: Ib75add2af3380d0b1d4ce320b58df22b6c3ffa57
2015-08-18 14:37:18 +02:00
Martin Magr 41608dc6c8 Implement Keystone domain creation
Keystone domain has to be created for Heat. This patch implements this
via helper script [1] since we don't have support for Keystone v3 API
in puppet-keystone yet. This implementation should be refactored as soon
as we will have v3 API available in puppet-keystone. For more info
please check [2].

[1] https://github.com/openstack/heat/blob/master/bin/heat-keystone-setup-domain
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1076172

Change-Id: I036a84eee6b9d0afa9a9ed96849494324ba4c4db
2014-09-18 12:27:20 +02:00
Francesco Vollero c393ba3bef Initial setup for the test environment in puppet-heat
Change-Id: I2a8523bb503cec68e278542100be35bfac12cba9
Signed-off-by: Francesco Vollero <fvollero@redhat.com>
2013-08-05 19:22:24 +02:00
Émilien Macchi e6d5cdc057 Add spec_helper 2013-06-01 00:12:56 +02:00