The parameter descriptions says the value should be a positive integer
(or 0). Validate the given value to reject invalid values such as
strings or even negative values.
Change-Id: Ica59437af00ea05335c934e6c3283e9207085587
If manila-share launches without enabled_share_backends, it actually
has no effect because it can't manage any share backend.
Require a valid inputs to detect potential misconfiguration.
Change-Id: I9d4387384908384e9b7d2b1621f856f49bce7cd8
... to each driver configurations, so that users can customize this
option in individual driver sections.
Note that this option works only when the driver supports thin
provisioning.
Change-Id: I8b6fd6a14f77f56c6b42a9977fe81b64698b5db4
We should use the reserved_share_extend_percentage parameter, instead
of the reserved_share_percentage parameter, to configure the option.
Closes-Bug: #2058111
Change-Id: Ib224d0af5c9794c9c27573981f498cdd28dacc4a
This refactors resource dependencies to improve the following points.
- Avoid unnecessary dependencies across services. For example aodh
service does not require cinder db.
- Restart only api service when config files like paste.ini, which
are used only be api service is changed.
Change-Id: I33f0123caa057169be0e7eee6c17d1d4d387f87f
This looses dependency using the new openstackclient tag, which
requires only packages actually related to openstack CLI.
Also, manilaclient is not required by manila itself so the support
package tag can be removed.
Depends-on: https://review.opendev.org/899594
Change-Id: I826e54bf5bbe125441aec38bb05353ea651252b7
Debian 12 was released in June 2023. Recent versions of OpenStack
(actually, 2023.1 and later) no longer support Debian 11.
Change-Id: I7ed9eecb3d8027143a2f11ce59711b1fb32287f1
Using credentials in keystone_authtoken options for manila_* resources
was deprecated some cycles ago[1].
[1] 5ca6e6fc9c
Change-Id: I71d98227468ef3be42ece9f5b1e4b588b51b9854
The unity share driver requires storops library, and now we install it
using pip. However this may not be ideal in some deployments because
it mixes up python libraries installed by packages and ones installed
by pip. This change introduces an option to disable management of
the storops library so that users can install the library by
a different method (3rd party package).
This change also fixes the missing manila-support-package tag, to
ensure that the package is installed before manila services start.
Change-Id: I56951a77264154c2f3cbc57234b7f54eef99aee1
Each backend support a few options to determine the capacity percentage
which should be reserved for certain operations. This adds support
for these options.
Change-Id: Ia259871cb6759eb2f8768cb5989846dd121d0d70
Add file to the reno documentation build to show release notes for
stable/2023.2.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2023.2.
Sem-Ver: feature
Change-Id: I32fa0913f4e1470374c6964019fee6da90cde792
Recent update in rspec-puppet removed some of the config interfaces for
old puppet versions[1]. This drops usage of these interfaces to resolve
the following error in unit tests.
```
An error occurred while loading ./spec/unit/provider/manila_spec.rb.
Failure/Error: c.manifest_dir = File.join(fixture_path, 'manifests')
NoMethodError:
undefined method `manifest_dir='...
```
This also removes explicit setting of mock module. The definition is
no longer required since we bumped puppetlabs_spec_helper to v 5.0.0.
[1] 316d95923c
Change-Id: Ia3affb52355ef859320a2b2bd6ef6365ea2b4844
This introduces support for options used by share backup and restore
feature, which was introduced to manila recently.
This also adds support for NFS share backup driver.
Change-Id: Idf187458b62e81999874f9582f932d9707c0d8c1
This was fixed for the other drivers by [1] but we somehow overlooked
this specific implementation.
[1] 5e92666e08
Related-Bug: #1931711
Change-Id: Ibd59d7bd2c74d0b459645bbb53ce7a57495eb27d
... because we are currently using v9.0.0 in CI. Lower version may be
bumped after 2023.2 release.
Change-Id: I0942614c38a3fd887a5611adb3f322bea43d7c87
The oslo.policy library has implementations to detect change in policy
rules and reload the new rules without service restart.
Change-Id: Idbd1eb9f14242e069a446acfc757b32568625388
This ensures the parameters used as file paths accept only absolute
paths, so that more sensible errors are returned to users instead of
the error from the file resource.
Change-Id: I0e39855aa5e4892f338d5f476be7760ec59e2eb8