openstack
/
puppet-neutron
Code Issues Proposed changes

Remove redundantly tested code 

Remove code that is redundantly tested.

This should not be tested here but in puppet-oslo
where this logic resides.

If we keep this and we do changes in puppet-oslo we
will break these unit tests, this is something we need
to sort out for all modules.

Change-Id: I0802fdd41954034270f4c67754891a82eb39ef5b
This commit is contained in:
Tobias Urdin 2019-01-18 10:46:20 +01:00
parent 9c74563d67
commit c6e7817053
1 changed files with 0 additions and 54 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
spec/classes/neutron_db_spec.rb
View File

@ -14,7 +14,6 @@ describe 'neutron::db' do
:max_overflow => '<SERVICE DEFAULT>',
:pool_timeout => '<SERVICE DEFAULT>',
)}
end
context 'with specific parameters' do
@ -43,55 +42,6 @@ describe 'neutron::db' do
:max_overflow => '21',
:pool_timeout => '21',
)}
end
context 'with MySQL-python library as backend package' do
let :params do
{ :database_connection => 'mysql+pymysql://neutron:neutron@localhost/neutron' }
end
it { should contain_oslo__db('neutron_config').with(
:connection => 'mysql+pymysql://neutron:neutron@localhost/neutron',
)}
end
context 'with postgresql backend' do
let :params do
{ :database_connection => 'postgresql://neutron:neutron@localhost/neutron', }
end
it 'install the proper backend package' do
should contain_package('python-psycopg2').with(:ensure => 'present')
end
end
context 'with incorrect database_connection string' do
let :params do
{ :database_connection => 'redis://neutron:neutron@localhost/neutron', }
end
it { should raise_error(Puppet::Error, /validate_re/) }
end
context 'with incorrect database_connection string' do
let :params do
{ :database_connection => 'foo+pymysql://neutron:neutron@localhost/neutron', }
end
it { should raise_error(Puppet::Error, /validate_re/) }
end
end
shared_examples 'neutron::db on Debian' do
context 'using pymysql driver' do
let :params do
{ :database_connection => 'mysql+pymysql://neutron:neutron@localhost/neutron' }
end
it { should contain_package('python-pymysql').with({ :ensure => 'present', :name => 'python-pymysql' }) }
end
end
@ -104,10 +54,6 @@ describe 'neutron::db' do
end
it_behaves_like 'neutron::db'
if facts[:osfamily] == 'Debian'
it_behaves_like 'neutron::db on Debian'
end
end
end
end