Commit Graph

3298 Commits

Author SHA1 Message Date
Zuul 08312cd7f3 Merge "Refactor unit tests for nova::compute::libvirt::services" 2024-06-03 17:41:26 +00:00
Zuul 35006301fb Merge "CentOS: Install libvirt-daemon only when needed" 2024-06-03 17:41:24 +00:00
Takashi Kajinami 0f52aa0eec Refactor unit tests for nova::compute::libvirt::services
... and improve the test coverage.

Change-Id: I4fa79abd5868bb380d9ed2bf322ca27738c86e02
2024-06-03 19:20:10 +09:00
Takashi Kajinami bdd63d3761 CentOS: Install libvirt-daemon only when needed
When libvirt service name is false then the core libvirt package is not
managed. So the libvir-daemon package should be also unmanaged.

Change-Id: I89ca6864ae476f5081fca65512caafae7642802e
2024-06-03 18:41:12 +09:00
Takashi Kajinami 39bc5b435b Refactor unit tests of nova::compute::libvirt
Create a common shared example so that all options are tested for
RHEL/CentOS.

Change-Id: I208534f8d00a643522b553924c99e1d3e794aac8
2024-06-03 18:33:41 +09:00
Takashi Kajinami 85f09f284c Avoid testing details of included class
Avoid testing details of nova::compute::libvirt::services in the unit
tests for nova::compute::libvirt, so that we don't have to maintain
test implementations about the same resources in two places.

Change-Id: I2702ce1ac20e68a933a10a5b9066661d96f56fe7
2024-06-03 17:52:50 +09:00
Takashi Kajinami 7617973329 CentOS: Drop unused libvirt-daemon-config-nwfilter
The package is no longer used by nova, since the firewall feature was
removed from nova during ussuri cycle[1].

[1] 9b321e41f60be5d4111c8312b40c826454386c53

Closes-Bug: #2067867
Change-Id: I9fb3193d10b8c23dcf7eb1d4549ee04776d9959d
2024-06-03 16:40:25 +09:00
Zuul 08d61a607a Merge "Assume structured fact in unit tests" 2024-06-01 05:21:28 +00:00
Takashi Kajinami df8171df93 Assume structured fact in unit tests
The legacy fact has been deprecated and is no longer available in
Puppet 8. Use the structured one to access fact values in tests so that
we use the consistent method for fact value access.

This change also fixes ignored unit tests of nova::migration::libvirt
with modular libvirt daemons.

Change-Id: I852facc2ee0ad2a948821f4232a1e8fc20ce4957
2024-06-01 10:10:56 +09:00
Takashi Kajinami 8593d289d1 Fix puppet 8 compatibility of nova_flavor
Fix the following error detected by puppet 8.

Munging failed for value true in class is_public: undefined method `=~'
for true:TrueClass ...

Change-Id: I7d078ea72c5c1c4898247f61422986f277ee9a98
2024-05-31 07:05:16 +00:00
Zuul 2c0c052297 Merge "Remove support for amqp1 messaging driver" 2024-05-10 16:44:04 +00:00
OpenStack Release Bot 7e60290a14 reno: Update master for unmaintained/zed
Update the zed release notes configuration to build from
unmaintained/zed.

Change-Id: I7644f5216c1f230f7c1da43cca16556efb0a284b
2024-05-10 09:20:52 +00:00
Takashi Kajinami 11653dc826 Remove support for amqp1 messaging driver
The base implementation in puppet-oslo was deprecated during the 2023.2
cycle[1], so can be removed now.

[1] e174113210699b433dbae4c2c5a68bc3d269b5c3

Change-Id: I80ff34199b00a47d105f76260fdcf33fd54032ff
2024-05-10 00:56:12 +09:00
Takashi Kajinami b749df0f91 secret_ceph: Validate value format
Ensure uuid is a valid UUID v4 string and value is base64-encoded.

Change-Id: If34038d4bc6f970045847d8dc92ada98e3083f99
2024-05-03 01:36:20 +09:00
Zuul 8b5ae727cd Merge "Add support for [scheduler_filter] pci_in_placement" 2024-05-01 16:51:31 +00:00
Takashi Kajinami 1f4ee98a43 Add support for [scheduler_filter] pci_in_placement
... which was added during 2023.1 cycle.

Depends-on: https://review.opendev.org/854924
Change-Id: I4b7c60a9f521547a4774e10c8ce18b5b45348da3
2024-04-30 01:33:24 +09:00
Takashi Kajinami 661a46c0d6 rbd: Support more libvirt driver tunables
Change-Id: I797141ce37129cc1b42da4182a4c54439c1371d1
2024-04-27 17:20:40 +09:00
Zuul dd59f94f57 Merge "Remove deprecated nova::periodic_interval" 2024-04-26 03:37:51 +00:00
Zuul 1aa4cce270 Merge "Remove deprecated cells v1 upgrade_levels parameters" 2024-04-25 15:20:39 +00:00
Zuul 1ebe4ac2c8 Merge "Use secret_ceph resource in nova::compute::rbd" 2024-04-25 15:20:38 +00:00
Zuul 96acc50a11 Merge "Add nova::compute::libvirt::secret_ceph resource" 2024-04-25 15:20:36 +00:00
Tobias Urdin d033bb39de Use secret_ceph resource in nova::compute::rbd
This migrates the libvirt secret handling in the
nova::compute::rbd class to using the new
secret_ceph definition.

We also deprecate the rbd_keyring approach were
we now require the usage of libvirt_rbd_secret_key
if manage_libvirt_secret is set to true (the default)
and we have a libvirt_rbd_secret_uuid given.

Change-Id: I8be56ebfc7c7ed6fb6d1d92f0ffec4a6d714a5d1
2024-04-23 09:10:04 +00:00
Tobias Urdin a7498d6dbc Add nova::compute::libvirt::secret_ceph resource
This adds the nova::compute::libvirt::secret_ceph
resource definition that can be used to define
libvirt secrets of ceph type.

Before this patch one could only handle one libvirt
secret by configuring the parameters in the
nova::compute::rbd class and with this one can
configure multiple.

This adds a new manage_libvirt_secret parameter
defaulting to true in the nova::compute::rbd class
so that one can disable the creation of the libvirt
secret from that class.

Change-Id: Ief031f5dd4b0648d5629789cb7d6d2f6f946fbf8
2024-04-23 11:09:51 +02:00
Zuul 7040f189ef Merge "libvirt: Support array for log_filters and log_outputs" 2024-04-23 08:05:18 +00:00
Takashi Kajinami b23268b083 Remove deprecated nova::periodic_interval
The parameter was deprecated in 23.0.0 release (2023.1)[1] and has had
no effect since then.

[1] 9d97a00634

Change-Id: Icc1b7f412c49f350c35be7f4a2fe9278808f6e15
2024-04-23 16:22:30 +09:00
Takashi Kajinami 1faa288038 Remove deprecated cells v1 upgrade_levels parameters
These were deprecated during 2023.2 cycle[1] so can be removed now.

[1] adbb5ce857

Change-Id: If10406a2e5872277ca56638f35d5bfaa44458ec9
2024-04-23 16:19:53 +09:00
Zuul ddde8befa8 Merge "Add missing test coverage about [quota] driver option" 2024-04-22 14:53:53 +00:00
Zuul 958b162911 Merge "Remove deprecated nova::scheduler::filter parameters" 2024-04-22 14:53:51 +00:00
Zuul 6ed6d7ba7e Merge "Remove deprecated api class parameters" 2024-04-22 14:44:20 +00:00
Zuul 4d2702016a Merge "virtlockd: Remove redundant pick" 2024-04-22 13:50:01 +00:00
Zuul 23aa10026a Merge "Improve test coverage of virtlockd class" 2024-04-19 16:19:40 +00:00
Takashi Kajinami 05db6ce121 Add missing test coverage about [quota] driver option
Change-Id: If37facbca2fd5d0592b7f5472b317bc96f71eab3
2024-04-19 14:19:54 +09:00
Takashi Kajinami cf2e04dda2 libvirt: Support array for log_filters and log_outputs
log_filters and log_outputs accept multiple items separated by single
spaces.

Change-Id: I58cbbf5ead4da9f36f9b1f2d2cf79e266d373134
2024-04-19 14:14:50 +09:00
Takashi Kajinami 94bf78b04e Remove deprecated nova::scheduler::filter parameters
These were deprecated during the previous cycle because of shortened
parameter names.

Change-Id: I2a3e3ce2a9961258895ed20cddad7c4aa37d775f
2024-04-19 02:07:37 +00:00
Takashi Kajinami 17b3724ec8 Remove deprecated api class parameters
These parameters were deprecated during the previous cycle and have
had no effect.

Change-Id: I3c1ef0de244d6a40ed2af89615748abdbaf3fdfe
2024-04-19 02:07:31 +00:00
Takashi Kajinami dea69138aa virtlockd: Remove redundant pick
Change-Id: Ia990b052ea9ea41dc27cfb35ddfb50d82250b570
2024-04-19 10:09:58 +09:00
Takashi Kajinami 9d6f46d1cf Improve test coverage of virtlockd class
Change-Id: I4d430fe072deb86d0043e2fd5e23a8f5f612fc5b
2024-04-19 10:09:54 +09:00
OpenStack Release Bot 685e33aa47 Update master for stable/2024.1
Add file to the reno documentation build to show release notes for
stable/2024.1.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2024.1.

Sem-Ver: feature
Change-Id: Ib322810b94af80e7bef166d78083b0b2f39785d4
2024-04-18 10:48:08 +00:00
Takashi Kajinami f011966893 Prepare 2024.1 release
Change-Id: I0b4ae6e96fbae47d65d93b781c66a04c0a9d6ae2
2024-04-15 22:31:13 +09:00
Zuul 8633ef31ac Merge "reno: Update master for unmaintained/xena" 2024-04-12 13:02:47 +00:00
OpenStack Release Bot bbef641b55 reno: Update master for unmaintained/xena
Update the xena release notes configuration to build from
unmaintained/xena.

Change-Id: I387c33574c0af18604879da86e5a454cb9094770
2024-04-12 12:33:33 +00:00
OpenStack Release Bot f3c10a34b5 reno: Update master for unmaintained/wallaby
Update the wallaby release notes configuration to build from
unmaintained/wallaby.

Change-Id: I12600c328cad4946e96d0cf8bd5d0c98cc705899
2024-04-12 12:25:49 +00:00
Zuul 57d31d0fbd Merge "Set show_diff to false for Nova SSH private key" 2024-04-11 15:33:55 +00:00
Zuul c35529dcd3 Merge "ironic: Support options to distribute baremetal management" 2024-04-11 15:33:53 +00:00
Zuul da0093fbb2 Merge "Avoid deprecated live_migration_uri if possible" 2024-04-11 15:30:43 +00:00
Tobias Urdin 75fbe61987 Set show_diff to false for Nova SSH private key
The private key is currently being leaked into
the diff output.

Change-Id: I94170f76257c77d1eabeeb3d373c05c50413c53d
2024-04-08 20:11:51 +00:00
Takashi Kajinami 7c7f60cc84 validate maxdelay for cron job
The parameter descriptions says the value should be a positive integer
(or 0). Validate the given value to reject invalid values such as
strings or even negative values.

Change-Id: Ib0937e1c3f6f97959b59e2c5812e3dfe696b6dba
2024-04-08 16:43:50 +09:00
Takashi Kajinami d452e60c7c ironic: Support options to distribute baremetal management
The ironic driver now provides a few options to distribute baremetal
node management among multilple nova-compute.

Change-Id: I7fbceb00422c2bd6ae7d594321fe09789fe0a3f3
2024-04-08 10:45:58 +09:00
Takashi Kajinami 34f0c8c722 Avoid deprecated live_migration_uri if possible
The live_migration_uri option was deprecated in favor of the new
live_migration_(scheme|inbound_addr) options.

Note that the new options does not allow customizing some parameters
for ssh, which were possible by the deprecated _uri option, so
the legacy option is still used if a user requests any of the options
currently not configurable by the new options.

Related-Bug: #1680729
Change-Id: I88c9777999cb091b8570c642e75b0332fb103294
2024-04-06 12:13:26 +09:00
Takashi Kajinami 83c9e4b17b Add consoleauth option support
Change-Id: Ic77b0a4aa0715344ed32c74cc11c114a6232af73
2024-04-04 09:30:44 +09:00