openstack
/
puppet-openstack_spec_helper
Code Issues Proposed changes

Default puppet version to >= 5.5 

The current one default to 5.5.x however when
we set puppet_gem_version to latest this actually
breaks the notion that "latest" should pull in
puppet 6.0.4

Changing this to >= 5.5 will cause it to select
latest version above or equal to 5.5 which should
be 6.0.4

Since we specify puppet_gem_version for all jobs
that should use puppet 4, puppet 5 etc this should
be safe.

Depends-On: https://review.openstack.org/#/c/631284/
Change-Id: Ifd9c6cff2fe4b7682c4d1349019333bc9fee9d04
This commit is contained in:
Tobias Urdin 2018-11-20 02:00:51 +01:00
parent 799f976b7b
commit c10cc3fe6d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
puppet-openstack_spec_helper.gemspec
View File

@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
spec.add_dependency 'puppet-lint', ['2.3.6']
spec.add_dependency 'puppetlabs_spec_helper'
puppetversion = ENV.key?('PUPPET_GEM_VERSION') ? ENV['PUPPET_GEM_VERSION'] : ['~> 5.5']
puppetversion = ENV.key?('PUPPET_GEM_VERSION') ? ENV['PUPPET_GEM_VERSION'] : ['>= 5.5']
spec.add_dependency 'puppet', puppetversion
# TODO(tobias-urdin): We need to bump this to 2.7.1 soon which will cause strict checking