openstack
/
puppet-pacemaker
Code Issues Proposed changes

Remove the pcmk_is_remote fact 

Since change I61f3393b88b65d29e2f2a5fdf6c2e2a112bfc9a1
(Switch requires for wait-for-settle into resource collectors) we
are not using the pcmk_is_remote fact any longer:
$ grep -r pcmk_is_remote puppet-pacemaker puppet-tripleo
$

It was partially broken anyway: facts run before package installation,
so if pacemaker-remote was not installed it would have returned
false before the configuration.

Let's save ourselves a systemctl call.

Change-Id: Icea3f0535fd8da8d28d269f0984453668424c28d
This commit is contained in:
Michele Baldessari 2018-07-18 09:50:45 +02:00 committed by Alex Schultz
parent a82e35575c
commit 8d09c3f5ce
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/facter/pcmk_is_remote.rb
View File

@ -1,8 +0,0 @@
require 'facter'
Facter.add('pcmk_is_remote') do
setcode do
systemd_pcmk_remote = `/usr/bin/systemctl is-active pacemaker_remote`
systemd_pcmk_remote.downcase.chomp == 'active'
end
end