Remove redundantly tested code
Remove code that is redundantly tested. This should not be tested here but in puppet-oslo where this logic resides. If we keep this and we do changes in puppet-oslo we will break these unit tests, this is something we need to sort out for all modules. Change-Id: I3856057008b61323cdf1d4ce919bc3c71ae6c32a
This commit is contained in:
parent
db576c4e84
commit
72ad68cd2c
|
@ -1,10 +1,11 @@
|
|||
require 'spec_helper'
|
||||
|
||||
describe 'tacker::db' do
|
||||
|
||||
shared_examples 'tacker::db' do
|
||||
context 'with default parameters' do
|
||||
it { is_expected.to contain_oslo__db('tacker_config').with(
|
||||
it { should contain_class('tacker::deps') }
|
||||
|
||||
it { should contain_oslo__db('tacker_config').with(
|
||||
:db_max_retries => '<SERVICE DEFAULT>',
|
||||
:connection => 'sqlite:////var/lib/tacker/tacker.sqlite',
|
||||
:idle_timeout => '<SERVICE DEFAULT>',
|
||||
|
@ -19,7 +20,8 @@ describe 'tacker::db' do
|
|||
|
||||
context 'with specific parameters' do
|
||||
let :params do
|
||||
{ :database_connection => 'mysql+pymysql://tacker:tacker@localhost/tacker',
|
||||
{
|
||||
:database_connection => 'mysql+pymysql://tacker:tacker@localhost/tacker',
|
||||
:database_idle_timeout => '3601',
|
||||
:database_min_pool_size => '2',
|
||||
:database_max_retries => '11',
|
||||
|
@ -31,7 +33,9 @@ describe 'tacker::db' do
|
|||
}
|
||||
end
|
||||
|
||||
it { is_expected.to contain_oslo__db('tacker_config').with(
|
||||
it { should contain_class('tacker::deps') }
|
||||
|
||||
it { should contain_oslo__db('tacker_config').with(
|
||||
:connection => 'mysql+pymysql://tacker:tacker@localhost/tacker',
|
||||
:idle_timeout => '3601',
|
||||
:min_pool_size => '2',
|
||||
|
@ -43,68 +47,6 @@ describe 'tacker::db' do
|
|||
:pool_timeout => '21',
|
||||
)}
|
||||
end
|
||||
|
||||
context 'with postgresql backend' do
|
||||
let :params do
|
||||
{ :database_connection => 'postgresql://tacker:tacker@localhost/tacker', }
|
||||
end
|
||||
|
||||
it 'install the proper backend package' do
|
||||
is_expected.to contain_package('python-psycopg2').with(:ensure => 'present')
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
context 'with MySQL-python library as backend package' do
|
||||
let :params do
|
||||
{ :database_connection => 'mysql://tacker:tacker@localhost/tacker', }
|
||||
end
|
||||
|
||||
it { is_expected.to contain_package('python-mysqldb').with(:ensure => 'present') }
|
||||
end
|
||||
|
||||
context 'with incorrect database_connection string' do
|
||||
let :params do
|
||||
{ :database_connection => 'foodb://tacker:tacker@localhost/tacker', }
|
||||
end
|
||||
|
||||
it_raises 'a Puppet::Error', /validate_re/
|
||||
end
|
||||
|
||||
context 'with incorrect pymysql database_connection string' do
|
||||
let :params do
|
||||
{ :database_connection => 'foo+pymysql://tacker:tacker@localhost/tacker', }
|
||||
end
|
||||
|
||||
it_raises 'a Puppet::Error', /validate_re/
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
shared_examples_for 'tacker::db on Debian' do
|
||||
context 'using pymysql driver' do
|
||||
let :params do
|
||||
{ :database_connection => 'mysql+pymysql://tacker:tacker@localhost/tacker', }
|
||||
end
|
||||
|
||||
it 'install the proper backend package' do
|
||||
is_expected.to contain_package('python-pymysql').with(
|
||||
:ensure => 'present',
|
||||
:name => 'python-pymysql',
|
||||
:tag => 'openstack'
|
||||
)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
shared_examples_for 'tacker::db on RedHat' do
|
||||
context 'using pymysql driver' do
|
||||
let :params do
|
||||
{ :database_connection => 'mysql+pymysql://tacker:tacker@localhost/tacker', }
|
||||
end
|
||||
|
||||
|
||||
end
|
||||
end
|
||||
|
||||
on_supported_os({
|
||||
|
@ -115,8 +57,7 @@ describe 'tacker::db' do
|
|||
facts.merge!(OSDefaults.get_facts())
|
||||
end
|
||||
|
||||
it_configures 'tacker::db'
|
||||
it_configures "tacker::db on #{facts[:osfamily]}"
|
||||
it_behaves_like 'tacker::db'
|
||||
end
|
||||
end
|
||||
end
|
||||
|
|
Loading…
Reference in New Issue