This fixes default values in parameter description which do not match
the actual values or are missing.
Change-Id: I9bd4458c094c301339f7b9d45f25670f3b715bd4
The hiera function is deprecated and does not work with the latest
hieradata version 5. It should be replaced by the new lookup
function[1].
[1] https://puppet.com/docs/puppet/7/hiera_automatic.html
With the lookup function, we can define value type and merge behavior,
but these are kept default at this moment to limit scope of this change
to just simple replacement. Adding value type might be useful to make
sure the value is in expected type (especially when a boolean value is
expected), but we will revisit that later.
example:
lookup(<NAME>, [<VALUE TYPE>], [<MERGE BEHAVIOR>], [<DEFAULT VALUE>])
Change-Id: Ie4afe07edb1166beb09af7d49bf39abacfd8c716
This reverts commit de98e1411b.
Reason for revert:
Aodh service has never been deprecated in tripleo-heat-templates.
The current warning in puppet-tripleo gives a wrong notice to users.
Deprecation should happen in a consistent manner within all TripleO
repos.
Conflicts:
manifests/profile/base/aodh/api.pp
manifests/profile/base/aodh/evaluator.pp
manifests/profile/base/aodh/listener.pp
manifests/profile/base/aodh/notifier.pp
Resolved conflicts caused by migration of class name format (from
absolute names to relative names)
Change-Id: I43eb5e96a2f15c4c49193c676acccce9c3f413c1
Service assurance framework is going to replace Aodh as alerting solution in T release.
This patch adds warning about the service removal.
Change-Id: Icef377071aaad5b58518a8a436c5821532482be2
The step is typically set with the hieradata setting an integer value:
{"step": 1}
However it would be useful for the value to be a string so that
substitutions are possible, for example:
{"step": "%{::step}"}
This change ensures the step parameter defaults to an integer by
calling Integer(hiera('step'))
This change was made by manually removing the undef defaults from
fluentd.pp, uchiwa.pp, and sensu.pp then bulk updating with:
find ./ -type f -print0 |xargs -0 sed -i "s/= hiera('step')/= Integer(hiera('step'))/"
Change-Id: I8a47ca53a7dea8391103abcb8960a97036a6f5b3
Ghanshyam Mann