Commit Graph

16 Commits

Author SHA1 Message Date
Takashi Kajinami 285607dd6a Cinder: Remove implementation for Dell SC driver
... because it was deprecated several cycles ago in favor of renaming
to Dell/EMC SC driver. The resource template to use this implementation
was already removed from t-h-t by [1].

[1] 3699a56891f8abce10d75a1b1cbbd6f2f775ff77

Change-Id: I4586a887ad25eaa2050ba1459842c248ecca478f
2022-12-12 10:48:28 +09:00
Rajesh Tailor c4890a2b00 Fix typos in parameter descriptions, comments and tests
Change-Id: I75b17e41aff3a63b618b6cada01f225f93a4ff4f
2022-09-17 11:34:15 +05:30
katarimanoj 626535352d Cinder: Replace hiera by lookup
The hiera function is deprecated and does not work with the latest
hieradata version 5. It should be replaced by the new lookup
function[1].

[1] https://puppet.com/docs/puppet/7/hiera_automatic.html

With the lookup function, we can define value type and merge behavior,
but these are kept default at this moment to limit scope of this change
to just simple replacement. Adding value type might be useful to make
sure the value is in expected type (especially when a boolean value is
expected), but we will revisit that later.

example:
lookup(<NAME>, [<VALUE TYPE>], [<MERGE BEHAVIOR>], [<DEFAULT VALUE>])

Change-Id: I77cb622a7ec1471715bb3e4fcb0157e5a6b80e74
2022-04-21 23:37:08 +00:00
Takashi Kajinami 33ac8dcc23 Cinder: Use defaults defined in puppet-cinder
Currently we override default values for backend manifests by undef
but because of this we already need to define each parameters otherwise
puppet-cinder raises validation failure or set empty values.
This change removes that redundant overrides and make puppet-tripleo
rely on defaults in puppet-cinder (and most of them are
$::os_service_default which result in defaults in cinder itself)

Change-Id: I0089a53ce630a7e84b193af427455ab96b04ec48
2021-07-03 23:47:28 +09:00
rajinir 8e074fd166 Deprecating Old Dell SC Volume Config
A new Dell SC volume config which supports both iSCSI and FC drivers
is added. Deprecating the old Dell SC config
See review https://review.opendev.org/#/c/722538/

Change-Id: I3402f71fde956ede80da0840780ad4bd227103c7
2020-04-24 15:05:17 -05:00
Tobias Urdin 1523a4b804 Convert all class usage to relative names
Change-Id: Ib2ed745b682cf12f9469a5a64451adcabec400af
2019-12-08 23:23:25 +01:00
Alan Bishop 6653440df8 Remove deprecated cinder parameters
Clean up parameters and hiera data associated with deprecated cinder
parameters removed from puppet-cinder by [1].

[1] https://review.opendev.org/678965

Change-Id: Ie763c985d32ecf942b32af2ff0eb5c531547b5c4
2019-09-06 10:58:39 -07:00
Alan Bishop 86ca1e6d3d Handle deprecated cinder iSCSI parameters
Cinder removed support for some previously deprecated configs, which
in turn required an update to puppet-cinder. This patch fixes the
parameter names used when creating puppet-cinder resources to not use
the deprecated names.

Closes-Bug: #1801081
Depends-On: I355298aaa7e48d242ad05b8c931ee9d41339185f
Change-Id: Ice4992678902a5adc090323fb232c8405e747bb5
2018-11-02 08:11:11 -04:00
rajinir 4342ac59b7 Dell EMC SC: Add use_multipath_for_image_xfer
This change adds support for
cinder::backend::dellsc_iscsi::use_multipath_for_image_xfer.

Change-Id: I69360b1ee167f8417876c9f6513981ef73e949ae
2018-10-22 10:58:40 -05:00
Alan Bishop ab13b5dc80 Add support for cinder backend availability zones
Add the ability to override the "backend_availability_zone" parameter
in every cinder volume backend.

Implements: blueprint split-controlplane-cinder-volume-az
Depends-On: I11821a38d8ba5afc594b3d601cd1634207a6f093
Change-Id: Ic407b747474b567858ad36beabc8a7d8c5022343
2018-10-18 09:18:17 -04:00
rajinir 7fd1113baf Dell EMC SC: Add support for excluded_domain_ips
The Dell EMC SC configuration option excluded_domain_ip has been
deprecated and will be removed in a future release. Deployments
should now migrate to the option excluded_domain_ips for
equivalent functionality.

Depends-On: https://review.openstack.org/#/c/604384/
Change-Id: Ib9218e7825fef83e41bdebaba3a444935c8a38e1
2018-10-04 09:12:12 -05:00
Steve Baker 94f13e6608 Ensure hiera step value is an integer
The step is typically set with the hieradata setting an integer value:

  {"step": 1}

However it would be useful for the value to be a string so that
substitutions are possible, for example:

  {"step": "%{::step}"}

This change ensures the step parameter defaults to an integer by
calling Integer(hiera('step'))

This change was made by manually removing the undef defaults from
fluentd.pp, uchiwa.pp, and sensu.pp then bulk updating with:

    find ./ -type f -print0 |xargs -0 sed -i "s/= hiera('step')/= Integer(hiera('step'))/"

Change-Id: I8a47ca53a7dea8391103abcb8960a97036a6f5b3
2017-06-14 14:31:52 +12:00
rajinir f30b791103 Dell SC: Add secondary DSM support
Adds support for a secondary DSM in case the primary becomes
unavailable.

Change-Id: Ibf8c333f62556d421d67c853f1f0740d7f9985bf
Depends-On: I331466e4f254b2b8ff7891b796e78cd30c2c87f7
2017-04-19 16:11:23 -05:00
rajinir 49ea8b5ed3 Dell SC: Add exclude_domain_ip option
This option allows users to exclude some fault domains.
Otherwise all domains are returned.

Change-Id: I6eb2bcc7db003a5eebd3924e3e4eb44e35f60483
Depends-On: I8ac91e6720e52da9cf7480f80bcfb456bf0c2433
2017-04-12 14:07:13 -05:00
Carlos Camacho 689d80e971 Fix parameters and headers inconsistency in the puppet manifests.
As we are staring to manually check overcloud services
the first step is to check that the puppet profiles
are all aligned.

Changes applied:

  No logic added or removed in this submission.

  Removed unused parameters.

  Align header comments structure.

  All profiles parameters sorted following:
  "Mandatory params first sorted alphabetically
  then optional params sorted alphabetically."

Note: Following submissions will check pacemaker,
cinder, mistral and redis services in the base profiles
as some of them has the $pacemaker_master parameter
defaulted to true.

Change-Id: I2f91c3f6baa33f74b5625789eec83233179a9655
2016-08-08 22:44:01 +02:00
Giulio Fidente f75502475d Add Cinder API/Scheduler/Volume roles
Includes both the base and the pacemaker roles.

Change-Id: I3c6d5226eed5f0f852b0ad9476c7cd9a959fda69
2016-06-02 14:42:27 +00:00