The hiera function is deprecated and does not work with the latest
hieradata version 5. It should be replaced by the new lookup
function[1].
[1] https://puppet.com/docs/puppet/7/hiera_automatic.html
With the lookup function, we can define value type and merge behavior,
but these are kept default at this moment to limit scope of this change
to just simple replacement. Adding value type might be useful to make
sure the value is in expected type (especially when a boolean value is
expected), but we will revisit that later.
example:
lookup(<NAME>, [<VALUE TYPE>], [<MERGE BEHAVIOR>], [<DEFAULT VALUE>])
Change-Id: I77cb622a7ec1471715bb3e4fcb0157e5a6b80e74
Currently we override default values for backend manifests by undef
but because of this we already need to define each parameters otherwise
puppet-cinder raises validation failure or set empty values.
This change removes that redundant overrides and make puppet-tripleo
rely on defaults in puppet-cinder (and most of them are
$::os_service_default which result in defaults in cinder itself)
Change-Id: I0089a53ce630a7e84b193af427455ab96b04ec48
This patch updats comment in several manifests to fix lint error with
the following messages:
- No matching class parameter for documentation of <parameter name>
- Duplicate class parameter documentation for <parameter name>
Change-Id: I927fc43fefe169d4041d980ef834975822d3755d
They are currently created within tripleo-heat-teampltes, so there are
no reasons why we should create it by puppet.
Change-Id: Icd8730aa4d47bb1059321014d5e8b2c5c323976a
Cinder removed support for some previously deprecated configs, which
in turn required an update to puppet-cinder. This patch fixes the
parameter names used when creating puppet-cinder resources to not use
the deprecated names.
Closes-Bug: #1801081
Depends-On: I355298aaa7e48d242ad05b8c931ee9d41339185f
Change-Id: Ice4992678902a5adc090323fb232c8405e747bb5
Add the ability to override the "backend_availability_zone" parameter
in every cinder volume backend.
Implements: blueprint split-controlplane-cinder-volume-az
Depends-On: I11821a38d8ba5afc594b3d601cd1634207a6f093
Change-Id: Ic407b747474b567858ad36beabc8a7d8c5022343
The step is typically set with the hieradata setting an integer value:
{"step": 1}
However it would be useful for the value to be a string so that
substitutions are possible, for example:
{"step": "%{::step}"}
This change ensures the step parameter defaults to an integer by
calling Integer(hiera('step'))
This change was made by manually removing the undef defaults from
fluentd.pp, uchiwa.pp, and sensu.pp then bulk updating with:
find ./ -type f -print0 |xargs -0 sed -i "s/= hiera('step')/= Integer(hiera('step'))/"
Change-Id: I8a47ca53a7dea8391103abcb8960a97036a6f5b3
This patch allows to spefify the iscsi_protocol in the iSCSI cinder
backend when we want to use iSCSI Extensions for RDMA (iSER).
The default value remains 'iscsi'.
Change-Id: I6d2c4d71fb3ab1f7749d6e1defb59e86b9364cc1
As we are staring to manually check overcloud services
the first step is to check that the puppet profiles
are all aligned.
Changes applied:
No logic added or removed in this submission.
Removed unused parameters.
Align header comments structure.
All profiles parameters sorted following:
"Mandatory params first sorted alphabetically
then optional params sorted alphabetically."
Note: Following submissions will check pacemaker,
cinder, mistral and redis services in the base profiles
as some of them has the $pacemaker_master parameter
defaulted to true.
Change-Id: I2f91c3f6baa33f74b5625789eec83233179a9655
Ghanshyam Mann