The hiera function is deprecated and does not work with the latest
hieradata version 5. It should be replaced by the new lookup
function[1].
[1] https://puppet.com/docs/puppet/7/hiera_automatic.html
With the lookup function, we can define value type and merge behavior,
but these are kept default at this moment to limit scope of this change
to just simple replacement. Adding value type might be useful to make
sure the value is in expected type (especially when a boolean value is
expected), but we will revisit that later.
example:
lookup(<NAME>, [<VALUE TYPE>], [<MERGE BEHAVIOR>], [<DEFAULT VALUE>])
Change-Id: Ic4fac5d0595ff5addf4d47ae6391f65784e1a03c
Gnocchi manifests have a few parameters defined but unused. This change
removes these ineffective parameters.
Change-Id: Ie2a8e6bdf5bae116f458fa3743fb400f731e2a84
tls_certfile and tls_keyfile is used to set up ssl certs in apache and
these variables are not required in the base class but used by the api
class.
Change-Id: If7ac460ee1783f8816250484611269794fc8fc2f
This reverts commit 88ef2afcbf.
Reason for revert:
Ceilometer and Gnocchi are not deprecated in tripleo-heat-templates.
The current warning in puppet-tripleo gives a wrong notice to users.
Deprecation should happen in a consistent manner within all TripleO
repos.
Conflicts:
manifests/profile/base/gnocchi.pp
Change-Id: I41ebb5c84db3cffa897c259729caa6b5247dd0e9
Since database parameters in the base classes were deprecated, it is
likely that db classes are no longer included automatically in a future
release. Let's ensure that the db classes are included so that
database parameters are always set.
Change-Id: I2a28cd1b7a92776b711eb784db3c4a486dcf6a85
The client classes are used to install client packages like aodhclient,
but there is no need to install these client packages when installing
services. In addition, package installation is no longer enabled since
services are containerized, so these classes are no longer effective.
Change-Id: Iced0d69556f61e6facfb1462de3ad241b5dfcfcb
The inclusion of gnocchi::db will be removed from gnocchi when we
remove deprecated database_connection parameter[1], thus we should
include the class explicitly.
[1] https://review.opendev.org/#/c/748928/
Change-Id: I2f52473edb78b5359eeb5c734b4d9691f86ccd26
Downcase in puppet 6.14 throws an error if the input to it is Undef. We
can avoid this by checking for a value before trying to downcase.
See context https://review.rdoproject.org/r/#/c/26297/
Change-Id: Ib2e97060523a4198a14949a15c9171b56928699c
The gnocchi::storage::corrdination_url parameter was deprecated to be
replaced by the gnocchi::coordination_url parameter.
This patch make puppet-tripleo to use the new parameter instead of the
deprecated one.
Depends-on: https://review.opendev.org/#/c/713448/
Change-Id: I2bbe95375c465aea8d2fe91b31897541ed998ae7
These have been dropped from some of the puppet classes by default. We
still need to include them so our debug logging works.
Change-Id: I4e65219d9669fdd16b2663b7239354330ffbae38
The step is typically set with the hieradata setting an integer value:
{"step": 1}
However it would be useful for the value to be a string so that
substitutions are possible, for example:
{"step": "%{::step}"}
This change ensures the step parameter defaults to an integer by
calling Integer(hiera('step'))
This change was made by manually removing the undef defaults from
fluentd.pp, uchiwa.pp, and sensu.pp then bulk updating with:
find ./ -type f -print0 |xargs -0 sed -i "s/= hiera('step')/= Integer(hiera('step'))/"
Change-Id: I8a47ca53a7dea8391103abcb8960a97036a6f5b3
As we are staring to manually check overcloud services
the first step is to check that the puppet profiles
are all aligned.
Changes applied:
No logic added or removed in this submission.
Removed unused parameters.
Align header comments structure.
All profiles parameters sorted following:
"Mandatory params first sorted alphabetically
then optional params sorted alphabetically."
Note: Following submissions will check pacemaker,
cinder, mistral and redis services in the base profiles
as some of them has the $pacemaker_master parameter
defaulted to true.
Change-Id: I2f91c3f6baa33f74b5625789eec83233179a9655
Implements: blueprint refactor-puppet-manifests
Co-Authored-By: Carlos Camacho <ccamacho@redhat.com>
Co-Authored-By: Juan Antonio Osorio Robles <jaosorior@redhat.com>
Change-Id: I38f218da118c45f3af1938eb17298017f4c70e24
Ghanshyam Mann