... because these resources are no longer used since all services were
containerized.
We already removed the same logic for Gnocchi only by [1].
[1] 6aa4681137
Change-Id: I2a32a067e3586e14c461948bd677b75365272cff
The hiera function is deprecated and does not work with the latest
hieradata version 5. It should be replaced by the new lookup
function[1].
[1] https://puppet.com/docs/puppet/7/hiera_automatic.html
With the lookup function, we can define value type and merge behavior,
but these are kept default at this moment to limit scope of this change
to just simple replacement. Adding value type might be useful to make
sure the value is in expected type (especially when a boolean value is
expected), but we will revisit that later.
example:
lookup(<NAME>, [<VALUE TYPE>], [<MERGE BEHAVIOR>], [<DEFAULT VALUE>])
Change-Id: I2614b8f42c45ba9f5143d51401c1d48d469a4ef8
The third argument of the hiera function determines the hierarchy level
to insert at the top of the hierarchy[1].
[1] https://puppet.com/docs/puppet/7/function.html#hiera
This is currently used for dellemc_unity::emc_share_backend only and is
not used in the other places. In addition passing undef has no effect
so it is just redundant.
This change removes the unnecessary undef parameter, to make usage of
the hiera function consistent across all manifests.
Change-Id: Ia59a79fbd293775afdacd9f8a517ff256720a7c0
Add the ability to override the "backend_availability_zone" parameter
in every manila share backend.
Depends-On: Ie7af8408fe8cec9349593fd9b4cb5bc7deb565cd
Change-Id: Ic71545d786b851e7d3f3ce8502e913b81fc70059
The parameter was deprecated and has no effect in puppet-manila since
Victoria[1]
[1] 2388d7510d600e358c76becf13d08581b489f2a7
Depends-on: https://review.opendev.org/799099
Change-Id: Ifdeb92cf0fcdc563fc37b6e3c97e89a8300ce122
Currently we override default values for backend manifests by undef
but because of this we already need to define each parameters otherwise
puppet-manila raises validation failure or set empty values.
This change removes that redundant overrides and make puppet-tripleo
rely on defaults in puppet-manila (and most of them are
$::os_service_default which result in defaults in manila itself)
Change-Id: Ia269acfc4b64701a968e186a522fe073a08616f3
This is now addressed in ansible and by removing it we should be
able to get rid of the last dependency we had on puppet-ceph
Change-Id: I10d1fb8efea5ccb79f32260fe98dcfdf59eff254
Depends-On: I86b1b75c9d807356e9a1f1901bc7e8856f0c0961
In tripleo-heat-templates a new 'CephConfigPath' parameter
is introduced with the purpose of customizing the path where the
Ceph config and keyring files are created on the host.
This change makes sure that puppet-tripleo is able to consume
a custom location for the Ceph config and keyring files.
Closes-Bug: #1708302
Co-Authored-By: Giulio Fidente <gfidente@redhat.com>
Change-Id: Iaabb66cd26f0246defe391a4e34f4eab3c3c5fee
This option isn't mandatory, and is being
deprecated.
Change-Id: Iedee7838587f9ff12118602663ad55ede1be2902
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
"netapp_root_volume_name" is deprecated in
favor of "netapp_root_volume" and manila will
no longer accept the older option name [1]
[1] https://review.opendev.org/745206/
Depends-On: I3891e8278c5b4a08d1baf435adede425498c3652
Change-Id: I3413897992a6f4ad577735cb0adbb8d1d8989e38
Manila needs to know the CephFS pool name, which the deployer
might want to customize when the Ceph cluster is externally managed.
Change-Id: I3adaa442b8c53ff902761d1dba283a79494c8ae6
Partial-Bug: 1837099
It is possible to provide the config settings
to add an arbitrary and unmanaged backend to Manila
at deployment time via Heat environment files. However,
puppet-tripleo doesn't support extending the
list of enabled backends. Add this capability.
Change-Id: I82f62df0a95f03afbda1b6a4ddaa67ef908030a9
Closes-Bug: #1831938
We might want to connect Manila Share to an external Ganesha service
and in that case need to provide additional configs so that we can
connect to the remote node via SSH.
Change-Id: I1741721ede9f9f469e2554b409ec6e0e6c7c22a2
Implements: blueprint manila-external-ganesha
Depends-On: I31fff6a1b6fede860b8aaee0079183924e8b31d6
manila now [1] supports configuring an octal value for the
rwx permissions mode of the cephfs volumes and snapshots
and groups of these that back manila shares, snapshots,
and groups.
Expose this parameter in the backend manifests for manila
with cephfs.
[1] https://review.openstack.org/#/c/614332
Depends-On: https://review.openstack.org/#/c/638770/
Change-Id: Id8cbdfeff8299ff08a84c1c5902fb909353d4678
This class was replaced by manila::backend::cephfs
in openstack/puppet-manila in the Pike release.
See corresponding change in openstack/puppet-manila [1]
[1] Ib13dfc6ffa77e96f5738c2ca3f9646a80aded659
Change-Id: I6757cd2368021b55775ad54931aa0b78c8383a68
Changing group permissions alters the ACL mask, causing the "read"
permission we set explicitly for the openstack users to be ignored.
This change ensures "read" is set for the ACLs mask.
Change-Id: I4f94a3f7ab2c55a8c45363b8354be99d52980a7b
Closes-Bug: 1775549
Deployment of a managed Ceph cluster using puppet-ceph
is not supported from the Pike release. From Queens it
is not supported use of puppet-ceph when using an
external Ceph cluster either.
This change removes the old manifests necessary to
support deployment of Ceph via puppet-ceph.
Templates removed by I17b94e8023873f3129a55e69efd751be0674dfcb
Depends-On: I8b22917e7436084028ef4fbe7604d28d6a68bee0
Implements: blueprint remove-puppet-ceph
Change-Id: I052af1f755b40a5fefa1f8d37e62b6b36c931271
A typo error resulted in an attempted resource chaining of
Ceph::Key[client.manila] to Exec[exec-setfacl-manila-manila]. The
actual exec resource is Exec[exec-setfacl-manila]
Change-Id: I78eec6022211b0e82c06599dea300961a2309f0c
This patch will set file system ACLs on the ceph client keyring.
This will help resolve (1) for OSP Ocata and before
Change-Id: I0c1bc3d2362c6500b1a515d99f641f8c1468754a
Partial-Bug: #1720787
1: https://bugzilla.redhat.com/show_bug.cgi?id=1462657
There is no reason to keep backend configuration in pacemaker-specific
manifest. This configuration is used no matter whether pacemaker is
used or not.
Change-Id: I63b53d230372a323db1d35a3774283ad2e29fbb1
Closes-Bug: #1714310
The step is typically set with the hieradata setting an integer value:
{"step": 1}
However it would be useful for the value to be a string so that
substitutions are possible, for example:
{"step": "%{::step}"}
This change ensures the step parameter defaults to an integer by
calling Integer(hiera('step'))
This change was made by manually removing the undef defaults from
fluentd.pp, uchiwa.pp, and sensu.pp then bulk updating with:
find ./ -type f -print0 |xargs -0 sed -i "s/= hiera('step')/= Integer(hiera('step'))/"
Change-Id: I8a47ca53a7dea8391103abcb8960a97036a6f5b3
In puppet-manila it is the api service performing db sync, not
scheduler. This change moves ::manila::db::mysql (which creates
the empty database and users) in the tripleo manila/api profile.
Also moves rabbit config into a general manila base profile as
that would be needed by the scheduler service as well.
Change-Id: I2b537f735b8d1be8f39e8c274be3872b193c1014
As we are staring to manually check overcloud services
the first step is to check that the puppet profiles
are all aligned.
Changes applied:
No logic added or removed in this submission.
Removed unused parameters.
Align header comments structure.
All profiles parameters sorted following:
"Mandatory params first sorted alphabetically
then optional params sorted alphabetically."
Note: Following submissions will check pacemaker,
cinder, mistral and redis services in the base profiles
as some of them has the $pacemaker_master parameter
defaulted to true.
Change-Id: I2f91c3f6baa33f74b5625789eec83233179a9655
The tripleo-heat-templates side that uses this is at
https://review.openstack.org/#/c/188137/
Change-Id: I444916d60a67bf730bf4089323dba1c1429e2e71
Implements: blueprint refactor-puppet-manifests
Ghanshyam Mann