The hiera function is deprecated and does not work with the latest
hieradata version 5. It should be replaced by the new lookup
function[1].
[1] https://puppet.com/docs/puppet/7/hiera_automatic.html
With the lookup function, we can define value type and merge behavior,
but these are kept default at this moment to limit scope of this change
to just simple replacement. Adding value type might be useful to make
sure the value is in expected type (especially when a boolean value is
expected), but we will revisit that later.
example:
lookup(<NAME>, [<VALUE TYPE>], [<MERGE BEHAVIOR>], [<DEFAULT VALUE>])
Change-Id: I11ff84f94db06dfd84ecd80ebb09c2a2076758eb
send_queue_limit was added recently to puppet-collectd and
will be available in puppet-collectd-12.2
Change-Id: Ida812cdbe5141ff91a7db7c46e422f86fb762f98
Because the libpod stats plugin is written in golang rather than C,
it is not included in the collectd rpm and therefor cannot be
configured by puppet-collectd and are made here instead. A simple
variable for enabling will suffice for now since the plugin does
not currently have any configuration options.
Change-Id: I575b6504e24f9d690e1b88b2a6bec296438ce747
Signed-off-by: pleimer <pfbleimer@gmail.com>
... to avoid lint errors by relative_classname_inclusion, which was
re-enabled recently[1].
[1] https://review.opendev.org/#/c/740023/
Change-Id: Ibb80b8b0f4075c00ceb306bcf54bb87df58165af
This patch is fixing following issues:
- currently HAProxy is not enabled by default because of wrong hiera key
- QDR connections are not http connections
- the load balanced services are running only controllers and listening
on internal_api interfaces, so the pacemaker_nodes are reused for this
configuration.
Change-Id: I6ae1ceca7ed4ae313c10e6d8be9803d20d68957d
672452018a
in puppet-collectd adds supports of CentOS-8 and collect-python
package is already defined there.
In puppet-tripleo, it started complaining about duplicate entry of
collectd-python package, removing the same fixes for puppet-tripleo
fixes the issue.
Closes-Bug: #1866965
Change-Id: If1a2c65c4208c2255a3140134204e240496ec8b6
Signed-off-by: Chandan Kumar (raukadah) <chkumar@redhat.com>
Currently there are cases when collectd is trying to connect to QDR
on different interface than QDR is listening for connections.
This patch makes sure that those services are always in sync. And also
is changing interior configuration to work based on IPs instead
of hostnames.
Change-Id: Ia865bef9daf5b7e92b1b8c3712113416c9c8c176
This patch adds possibility to configure collectd-exec to execute
collectd-sensubility and configure this extension.
Change-Id: Ieb5042603ff76fd22f867a17a853bb1ec6a744f2
The SQLAlchemy-collectd plugin is now shipped in podman
containers under Kolla, this allows heat templates
to pull the plugin into the collectd configuration when
the collectd templates are being used.
A corresponding set of template changes in tripleo-heat-templates
will enable this plugin.
Change-Id: If598da717653a383a2d3b3373c56517f8bca832f
In the effort of reducing the number of Hieradata files, the
service_names parameter previously consummed in puppet-tripleo can be
replaced by enabled_services which contains the same list.
It will allow us later to remove the service_names hieradata file.
Change-Id: I457f2c81a2cf6cc2f42dc4585b41b0d91dacc059
Related-Bug: #1835551
Current implementation of collect_gnocchi plugin configuration blocks
usage of other python-based plugins. This patch leverages puppet-collectd
classes properly to enable configuration of more than one python-based
plugin together.
Change-Id: I248859bf0e4b70e3a057e96b5fb74be64f4008ed
The correct values or auth modes for Gnocchi are 'basic' and 'keystone'.
This patch fixes the 'simple' usage to 'basic'. Note that without this rename
the deployment works because when 'simple' is used the parameter is not used
in config file, so value 'basic' is used by python-collectd-gnocchi, because
it is implicit default.
Change-Id: I05632137ed12c59a41a5219189c431983935d461
If collectd is allowed to manage repo, it will need
the epel module.
This patch let collectd manage repo. It does not let
to manage the repo by default, but it can be modified.
I also adds the collectd unit test.
Depends-On: I771b4f033ba5d6926e1ab9d9900af8bc81876295
Change-Id: I0576df2902cc44e7e9ff312214d609095132f2a4
The step is typically set with the hieradata setting an integer value:
{"step": 1}
However it would be useful for the value to be a string so that
substitutions are possible, for example:
{"step": "%{::step}"}
This change ensures the step parameter defaults to an integer by
calling Integer(hiera('step'))
This change was made by manually removing the undef defaults from
fluentd.pp, uchiwa.pp, and sensu.pp then bulk updating with:
find ./ -type f -print0 |xargs -0 sed -i "s/= hiera('step')/= Integer(hiera('step'))/"
Change-Id: I8a47ca53a7dea8391103abcb8960a97036a6f5b3
Based on Steve Hardy's comments in
https://review.openstack.org/#/c/413748/, we need to move handling of
the list of plugins out of the heat templates and into puppet. This
module now uses the service_names variable to look up information on
per-service collectd plugins.
Change-Id: Ie5fba01e1f91ffdc39eb0eb1be9b1464c797b04f
This is the glue between the collectd composable service in
tripleo-heat-templates and the puppet-collectd module.
Change-Id: I7e899e3af870b04dcd45503bd322278997fa53d0
Ghanshyam Mann