The hiera function is deprecated and does not work with the latest
hieradata version 5. It should be replaced by the new lookup
function[1].
[1] https://puppet.com/docs/puppet/7/hiera_automatic.html
With the lookup function, we can define value type and merge behavior,
but these are kept default at this moment to limit scope of this change
to just simple replacement. Adding value type might be useful to make
sure the value is in expected type (especially when a boolean value is
expected), but we will revisit that later.
example:
lookup(<NAME>, [<VALUE TYPE>], [<MERGE BEHAVIOR>], [<DEFAULT VALUE>])
Change-Id: Ib25279ec008373245eacb3478d6edb74a5cf9063
This logic is no longer used since we introduced containerized libvirt
daemon and would block implementing the same in puppet-nova.
Change-Id: Ib67747f68976e3bbce8b0ca3f0cc3747a1163c6b
This change enables support for modular libvirt
daemon configurations.
Also deprecating modular_libvirt param so that modular-libvirt
is default configuration and once we remove non-modular libvirt
configuration in next release, this param can be removed.
Depends-On: https://review.opendev.org/c/openstack/puppet-nova/+/785305
Co-Authored-By: Bogdan Dobrelya <bdobreli@redhat.com>
Co-Authored-By: Martin Schuppert <mschuppert@redhat.com>
Change-Id: Id9c1bfcc88f60f61877fe34b1ee01677d3bcc1b0
Include nova::compute::libvirt::virtlogd to manage virtlogd
configuration.
Depends-on: https://review.opendev.org/#/c/685024/
Change-Id: I3d28680b4cf18c06b799e329639bb424e63d1368
This was replaced with deployment_type a while back so uuid is now a
proper value based on the system id. See
https://review.opendev.org/#/c/607647/
Change-Id: Ica2f39e6bee697002984d0f28298338edf55ac4b
[stack@win1 ~]$ sudo podman logs nova_virtlogd
+sudo -E kolla_set_configs OSError: [Errno 30] Read-only file system
The reason is the following nova_virtlogd bind mount:
... - /etc/libvirt/qemu:/etc/libvirt/qemu:ro
Seems kolla config has a some empty folders that are then copied to a
:ro fs and we fail:
()[root@win1 /]$ find
var/lib/kolla/config_files/src/
var/lib/kolla/config_files/src/
var/lib/kolla/config_files/src/etc
var/lib/kolla/config_files/src/etc/libvirt
var/lib/kolla/config_files/src/etc/libvirt/qemu
var/lib/kolla/config_files/src/etc/libvirt/qemu/networks
var/lib/kolla/config_files/src/etc/libvirt/qemu/networks/autostart
Since the above empty folders are due to the timestamp
change caused by the default.xml file removal, let's do
those on BM only.
Hopefully compute folks can propose a more definitive fix that
takes that default.xml removal logic into host-prep-task (if it
is still needed)
Tested on a RHEL8 OS/Containers combo and the error is gone:
[root@overcloud-novacompute-0 ~]# podman logs nova_virtlogd 2>&1| tail -n5
++ chmod 755 /var/log/kolla/libvirt
++ chmod 644 /var/log/kolla/libvirt/libvirtd.log
Running command: '/usr/sbin/virtlogd --config /etc/libvirt/virtlogd.conf'
+ echo 'Running command: '\''/usr/sbin/virtlogd --config /etc/libvirt/virtlogd.conf'\'''
+ exec /usr/sbin/virtlogd --config /etc/libvirt/virtlogd.conf
Change-Id: I629e9e37aff9a1610df874b46c7a5b1eedd3e374
Closes-Bug: #1819482
With the change in https://review.openstack.org/#/c/561784/3 we need to
make sure that the new port range get applied to the the qemu.conf file.
This change includes ::nova::migration::qemu to
::tripleo::profile::base::nova::libvirt
Change-Id: Idadfc7b3507977f1385e846a48a734ed0e5f0a32
Closes-bug: 1779820
Need to ensure libvirt is installed before the execs that depend on it.
Related bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1500527
Change-Id: I7ba62bb3e3a2e43bc57ed33f9b320c698b2c6ad5
Closes-bug: 1723221
The default (on RHEL/CentOS) is to use polkit but this is only useful
for GUI support or for fine grained API access control. As we don't
require either we can achieve identical control using plain old unix
filesystem permissions.
I've merged Sven's changes from https://review.openstack.org/484979
and https://review.openstack.org/487150.
As we need to be careful with the libvirtd option quoting I think it's
best to do this in puppet-tripleo instead of t-h-t yaml.
The option to override the settings from t-h-t remains.
Co-Authored-By: Sven Anderson <sven@redhat.com>
Reverts I91be1f1eacf8eed9017bbfef393ee2d66771e8d6
Closes-bug: 1696504
Change-Id: I507bdd8e3a461091562177403a2a55fcaf6694d2
Depends-On: I17f6c9b5a6e2120a53bae296042ece492210597a
The unit tests jobs are failing because of missing pre conditions for
the new shared class introduced by
Ib233689fdcdda391596d01a21f77bd8e1672ae04. Additionally this change
moved some classes around so that the tests are now failing due to
duplicate class declarations for nova::compute::libvirt::services. This
change moves the include that pulls in the declaration first prior to
the include that exists in tripleo::profile::base::nova::libvirt.
The selinux test was also failing due to a type issue with the fact
being used (boolean vs string)
Change-Id: I5bd4b61d6008820729d58f7743e7e61955dd6f51
Closes-Bug: #1707034
Some of the tasks carried by nova::compute::rbd class apply libvirt.
Change-Id: Ib233689fdcdda391596d01a21f77bd8e1672ae04
Depends-On: I28557deb13b75922932cd3e86c3467a541c988d0
The nova migration config has always been applied by the base::nova profile.
It assumed that libvirtd/nova-compute and are all running on the
same host.
Where this config didn't apply (e.g a nova api host) it was disabled by a flag.
This approach is not compatible with containers. Hieradata for all containers
are combined so per-host flags no longer work, and we can no longer assume
libvirtd and nova-compute run in the same context.
This change refactors the profiles out of the base nova profile and into
a client profile and a target profile that can be included where appropriate.
Change-Id: I063a84a8e6da64ae3b09125cfa42e48df69adc12
Implements: blueprint tripleo-cold-migration
The step is typically set with the hieradata setting an integer value:
{"step": 1}
However it would be useful for the value to be a string so that
substitutions are possible, for example:
{"step": "%{::step}"}
This change ensures the step parameter defaults to an integer by
calling Integer(hiera('step'))
This change was made by manually removing the undef defaults from
fluentd.pp, uchiwa.pp, and sensu.pp then bulk updating with:
find ./ -type f -print0 |xargs -0 sed -i "s/= hiera('step')/= Integer(hiera('step'))/"
Change-Id: I8a47ca53a7dea8391103abcb8960a97036a6f5b3
As we are staring to manually check overcloud services
the first step is to check that the puppet profiles
are all aligned.
Changes applied:
No logic added or removed in this submission.
Removed unused parameters.
Align header comments structure.
All profiles parameters sorted following:
"Mandatory params first sorted alphabetically
then optional params sorted alphabetically."
Note: Following submissions will check pacemaker,
cinder, mistral and redis services in the base profiles
as some of them has the $pacemaker_master parameter
defaulted to true.
Change-Id: I2f91c3f6baa33f74b5625789eec83233179a9655
Create a new profile where we only manage Nova libvirt service.
Change-Id: I2ff3cf6a31bc10aa46a089fcbfc654eda55e6ef8
Implements: blueprint refactor-puppet-manifests
Depends-On: Ib0d3111560af5af451e522c6dc3b3918d0463e7d
Ghanshyam Mann