Make methods static where it's possible

Change-Id: I09baf6491c84a5d4d6e3ab1261d474f7811e32d6
This commit is contained in:
Dina Belova 2014-12-29 14:33:29 +03:00
parent da4b4e85b2
commit cb0575cafc
3 changed files with 6 additions and 3 deletions

View File

@ -66,7 +66,8 @@ class BaseOpenTSDBClient(object):
"""
raise NotImplementedError
def _check_meters(self, meters):
@staticmethod
def _check_meters(meters):
"""Check that meters to be put are having nice format."""
if type(meters) == dict:
meters = [meters]

View File

@ -101,7 +101,8 @@ class RESTOpenTSDBClient(base.BaseOpenTSDBClient):
def get_query(self, query):
return self._make_query(query, 'get')
def process_response(self, resp):
@staticmethod
def process_response(resp):
try:
res = json.loads(resp.text)
except Exception:

View File

@ -199,7 +199,8 @@ class SocketOpenTSDBClient(base.BaseOpenTSDBClient):
'has been collected' % self.max_uncaught_exceptions)
raise
def compose_line_from_meter(self, m_dict):
@staticmethod
def compose_line_from_meter(m_dict):
meter_dict = copy.deepcopy(m_dict)
tags = meter_dict.pop('tags')
tags_str = ''.join(' %s=%s' % (k, v) for k, v in six.iteritems(tags))