Merge "Make ipmi lanplus the default in auto fencing"

releasenotes/notes/ipmi-lanplus-default-fb3ec3496853ed9e.yaml

@@ -0,0 +1,6 @@
+---
+features:
+  - |
+    Deprecate --ipmi-lanplus for ``openstack overcloud generate fencing``
+    command since now this is the default and add new option --ipmi-no-lanplus
+    to override it.

tripleoclient/tests/v1/test_overcloud_parameters.py

@@ -158,6 +158,6 @@ class TestGenerateFencingParameters(utils.TestCommand):
                     }],
                 'delay': None,
                 'ipmi_cipher': None,
-                'ipmi_lanplus': False,
+                'ipmi_lanplus': True,
                 'ipmi_level': None
             })

tripleoclient/v1/overcloud_parameters.py

@@ -78,8 +78,14 @@ class GenerateFencingParameters(command.Command):
                             help=_('Wait DELAY seconds before fencing is '
                                    'started'))
         parser.add_argument('--ipmi-lanplus',
+                            dest='ipmi_lanplus',
+                            default=True,
                             action='store_true',
-                            help=_('Use Lanplus. Defaults to: false'))
+                            help=_('DEPRECATED: This is the default.'))
+        parser.add_argument('--ipmi-no-lanplus',
+                            dest='ipmi_lanplus',
+                            action='store_false',
+                            help=_('Do not use Lanplus. Defaults to: false'))
         parser.add_argument('--ipmi-cipher', type=int,
                             help=_('Ciphersuite to use (same as ipmitool -C '
                                    'parameter.'))