summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatthew Thode <mthode@mthode.org>2018-06-11 12:52:05 -0500
committerMatthew Thode <mthode@mthode.org>2018-06-11 17:15:30 -0500
commit7e91070789187d9e6b5ac2b57ca755504e058e32 (patch)
tree9e3547f61f4ffc18cff5fb5f0a4065dd8a4a4924
parent17c857251ddc1ada8525868a21502f2ff68d8734 (diff)
make requirements check job check for minimum version definitions.
While we don't track the minimum version of a given requirement in requirements.txt we still need to ensure that they exist. Change-Id: I84bfbc3a1db4032ee1a2b5995e6930978be42828 Closes-Bug: #1776247
Notes
Notes (review): Code-Review+2: Doug Hellmann <doug@doughellmann.com> Code-Review+1: qingszhao <zhao.daqing@99cloud.net> Code-Review+2: Sean McGinnis <sean.mcginnis@gmail.com> Workflow+1: Sean McGinnis <sean.mcginnis@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 15 Jun 2018 02:49:10 +0000 Reviewed-on: https://review.openstack.org/574367 Project: openstack/requirements Branch: refs/heads/master
-rw-r--r--openstack_requirements/check.py5
1 files changed, 5 insertions, 0 deletions
diff --git a/openstack_requirements/check.py b/openstack_requirements/check.py
index 92d62ed..60d7ada 100644
--- a/openstack_requirements/check.py
+++ b/openstack_requirements/check.py
@@ -155,6 +155,11 @@ def _validate_one(name, reqs, blacklist, global_reqs):
155 "not match openstack/requirements value : %s" % ( 155 "not match openstack/requirements value : %s" % (
156 name, str(req), str(global_reqs[name]))) 156 name, str(req), str(global_reqs[name])))
157 return True 157 return True
158 # check for minimum being defined
159 min = [s for s in req.specifiers.split(',') if '>' in s]
160 if not min:
161 print("Requirement for package %s has no lower bound" % name)
162 return True
158 for extra, count in counts.items(): 163 for extra, count in counts.items():
159 if count != len(global_reqs[name]): 164 if count != len(global_reqs[name]):
160 print("Package %s%s requirement does not match " 165 print("Package %s%s requirement does not match "