openstack
/
requirements
Code Issues Proposed changes

update the review instructions for new lib releases 

We updated the release process to ask folks to submit constraint
updates, and this change updates the review instructions here to tell
new reviewers to allow them.

Change-Id: I5b8a4d3922794b05d34dc8355de97ee7dd2bf42a
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
This commit is contained in:
Doug Hellmann 2016-05-09 09:36:07 -04:00 committed by Sean Dague
parent 10db24c9f8
commit d741499926
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
README.rst
View File

@ -354,10 +354,17 @@ If the change was proposed by the OpenStack CI bot, then if the change has
passed CI, only one reviewer is needed and they should +2 +A without thinking
about things.
If the change was not proposed by the OpenStack CI bot, and does not include a
``global-requirements.txt`` change, then it should be rejected: the CI bot
will generate an appropriate change itself. Ask in #openstack-infra if the
bot needs to be run more quickly.
If the change was not proposed by the OpenStack CI bot, and only
changes the ``upper-constraints.txt`` entry for a new library release,
then the change should be approved if it passes the tests. See the
README.rst in openstack/releases for more details of the release
process.
If the change was not proposed by the OpenStack CI bot, and is not
related to releasing one of our libraries, and does not include a
``global-requirements.txt`` change, then it should be rejected: the CI
bot will generate an appropriate change itself. Ask in
#openstack-infra if the bot needs to be run more quickly.
Otherwise the change may be the result of recalculating the constraints which
changed when a ``global-requirements.txt`` change is proposed. In this case, ignore