openstack
/
sahara
Code Issues Proposed changes

Fix validation of job binary with Python3 

Currently with Python3 it raises exception
BadJobBinaryInternalException() with Data: b'test-project',
This patch handles it for python3.

Change-Id: I45ce95fdec78af7f21a98613e8c7763bd84ff2aa
Story: 2004688
Task: 28698
This commit is contained in:
yatin 2019-01-02 15:39:29 +05:30
parent 84c1f79327
commit 596c2599af
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sahara/service/validations/edp/job_binary_internal.py
View File

@ -32,7 +32,7 @@ def check_job_binary_internal(data, **kwargs):
if not is_internal_db_enabled():
raise e.BadJobBinaryInternalException(
_("Sahara internal db is disabled for storing job binaries."))
if not (isinstance(data, six.string_types) and len(data) > 0):
if not (isinstance(data, six.binary_type) and len(data) > 0):
raise e.BadJobBinaryInternalException()
if "name" in kwargs:
name = kwargs["name"]

2
sahara/tests/unit/service/validation/edp/test_job_binary_internal.py
View File

@ -30,7 +30,7 @@ class TestJobBinaryInternalCreateValidation(u.ValidationTestCase):
jb_manager.setup_job_binaries()
def test_job_binary_internal_create(self):
self._assert_create_object_validation(data='text')
self._assert_create_object_validation(data=b'text')
self._assert_create_object_validation(
data='',