Commit Graph

12 Commits

Author SHA1 Message Date
chenxing 1f47383e67 Update the documentation link for doc migration
Change-Id: Ied5b93d7509ae6a2a9d87740ebe67679ce705c5b
2017-07-14 13:50:40 +00:00
Ngo Quoc Cuong e181a9c0ff Update log translation hacking rule
Starting with the Pike series, OpenStack no longer supports log
translation.
Update hacking rule to prevent log translation in all log level instead
of only debug level.

Change-Id: I4c6d720b2aa91a883bbf974d390028218357e1e4
2017-07-02 23:07:59 -04:00
kavithahr 46b649450c Changed the spelling mistake.
Change-Id: Ia3a66a254554c9a206c8d5fb9a21179e21d899ee
2017-02-27 06:18:46 +00:00
Javeme 3cb08bc52b Ensure default arguments are not mutable
* add hacking check: no_mutable_default_args()
* remove the mutable default arguments "[]" or "{}" when the function
  is defined.

ref: http://docs.python-guide.org/en/latest/writing/gotchas/

Closes-Bug: #1530282
Change-Id: Ice6f7654211b73d7f8bc3ca0e4dfae3dca354397
2015-12-31 15:56:11 +08:00
Vitaly Gridnev efc639caff Use jsonutils from oslo.serialization
Sahara should use jsonutils from oslo_serialization because
it support all functions from json. Also added
hacking check for that.

Change-Id: I8c286ad947b92d6552b17cfa7ef80ba1beb5b51b
Closes-bug: 1442120
2015-04-14 12:16:53 +03:00
Nikolay Starodubtsev 0eb845d246 Add hacking checks related to logging guideliness
As soon as we have logging guideliness now it's better for us
to have an automated hacking checks at least for some points of it.

Change-Id: I1cef618a83a23f23304b4a40eb8d4263d8b89c70
2015-04-13 14:29:14 +03:00
ChangBo Guo(gcb) 4dc5dfdada Leverage dict comprehension in PEP-0274
PEP-0274 introduced dict comprehensions to replace dict constructor
with a sequence of key-pairs[1], these are twobenefits:
  First, it makes the code look neater.
  Second, it gains a micro-optimization.

sahara dropped python 2.6 support in Kilo, we can leverage this now.

Note: This commit doesn't handle dict constructor with kwargs.
This commit also adds a hacking rule.

[1]http://legacy.python.org/dev/peps/pep-0274/

Closes-Bug: #1430786
Change-Id: I507f2c520ddab1ae3d8487bf7aea497306eb6eb2
2015-04-02 01:51:41 +00:00
Nikolay Starodubtsev 16b05b8b54 Take back upstream checks for import order
Import order checks was removed from upstream after discussion [1].
We want to save it in Sahara and we can do it because we support only
py2.7
NOTE: After moving to 3.x this checks should be removed/modified
[1]: http://lists.openstack.org/pipermail/openstack-dev/2014-December/052519.html

Change-Id: Ie26613c527c46bfd71ef58cb77219644d784f4c3
Closes-Bug: 1429089
2015-03-13 15:28:01 +03:00
Nikolay Starodubtsev 973c576716 Take back upstream checks for commit message
Hacking checks for commit message was removed from upstream after
discussion [1]. We want to save it in Sahara, so we copy it from
hacking.
[1]: http://lists.openstack.org/pipermail/openstack-dev/2014-December/052519.html

Closes-Bug: 1429090

Change-Id: Ibec7fb27dbfb330e8749a798cf89c544d5198c40
2015-03-10 21:30:39 +03:00
Trevor McKay dd8e2f889f Change savanna references in top level docs
Partial-Implements: blueprint savanna-renaming-service
Change-Id: Ibaf5d9f50447c7b574bed731d92dc5f9a478a57e
2014-03-20 15:21:35 -04:00
Sergey Lukjanov b72c9a30ad Replace copy-pasted HACKING.rst with link
Change-Id: I17a452f1eba79f76ddbb95ce3ed6f5053a0fca8e
2013-11-15 14:09:32 +04:00
Sergey Lukjanov 9144cb4692 Additional info files added to repo
Change-Id: Icc3e9d7820beb999347f7c6721c33a2df693740b
DocBuild
2013-04-15 23:37:48 +04:00