100% coverage

shoebox/archive.py

@@ -21,7 +21,7 @@ class Archive(object):
         self._handle = None
         self.filename = filename
 
-    def get_file_handle(self):
+    def get_file_handle(self):  # pragma: no cover
         return self._handle
 
 

shoebox/disk_storage.py

@@ -166,33 +166,3 @@ def unpack_notification(file_handle):
     version = v0.load_preamble(file_handle)
     version_handler = get_version_handler(version)
     return version_handler.unpack(file_handle)
-
-
-if __name__ == "__main__":
-    event = {"event_type": "nova.compute.run_instance.start",
-             "generated": datetime.datetime.utcnow(),
-             "request_id": "req-1234abcd5678efgh",
-             "source": "n-compute-1973",
-             "payload": {
-                "foo": 123,
-                "blah": "abc",
-                "zoo": False
-             }
-            }
-
-    json_event = json.dumps(event, cls=DatetimeEncoder)
-    metadata = {'request_id': event['request_id'],
-                'event_type': event['event_type'],
-                'source': event['source'],
-               }
-
-    binary = pack_notification(json_event, metadata)
-
-    with open("test.dat", "wb") as f:
-        for block in binary:
-            f.write(block)
-
-    with open("test.dat", "rb") as f:
-        metadata, notification = unpack_notification(f)
-        print "Metadata:", metadata
-        print "Notification:", notification

shoebox/roll_checker.py

@@ -21,7 +21,7 @@ class RollChecker(object):
         """Called when a new archive is selected."""
         pass
 
-    def check(self, archive):
+    def check(self, archive):  # pragma: no cover
         """Should the current archive roll?"""
         pass
 

test/test_disk_storage.py

@@ -119,4 +119,21 @@ class TestHelpers(unittest.TestCase):
         self.assertTrue(isinstance(disk_storage.get_version_handler(),
                                    disk_storage.Version1))
 
+    def test_pack_notification(self):
+        with mock.patch('shoebox.disk_storage.get_version_handler') as h:
+            fake_handler = mock.Mock()
+            h.return_value = fake_handler
+            disk_storage.pack_notification("payload", {})
+            self.assertTrue(fake_handler.pack.called)
 
+    def test_unpack_notification(self):
+        file_handle = mock.Mock()
+        file_handle.read.return_value = struct.pack("ih",
+                          disk_storage.BOR_MAGIC_NUMBER, 99)
+
+        with mock.patch('shoebox.disk_storage.get_version_handler') as h:
+            fake_handler = mock.Mock()
+            h.return_value = fake_handler
+            disk_storage.unpack_notification(file_handle)
+            h.assert_called_with(99)
+            self.assertTrue(fake_handler.unpack.called)