Updating the rsa ssh host key based on:
https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/
Note: In the future, StarlingX should have a zuul job and
secret setup for all repos so we do not need to do this
for every repo.
Needed to rename the secret, because zuul fails if like-named
secrets have diffent values in different branches of the same
repo.
Partial-Bug: #2015246
Change-Id: I1d4a2a4e8b220d8966b7ee67243445eeb1601296
Signed-off-by: Davlet Panech <davlet.panech@windriver.com>
yaml.load is considered unsafe. yaml.safe_load is the
recommended method to use.
The yaml.load is only being called from scenario tests,
and from a forensic tool that is unused. Therefore this
code change has no runtime impact.
This allow unsuppressing the following pylint error
E1120 no-value-for-parameter
This allow unsuppressing the following bandit error
B506: Test for use of yaml load
Adding a new bandit zuul job, and removing the pinning
of the version of bandit for this repo.
Test Plan:
PASS: tox -e pylint
PASS: tox -e bandit
PASS: build-pkgs -p nfv
Story: 2010531
Task: 47174
Signed-off-by: Al Bailey <al.bailey@windriver.com>
Change-Id: Ie60dcf98425c95e103d22e7be4212de1954550bf
tox changes:
- remove python2.7 and python3.6 unit test targets
from tox.ini since only python 3.9 is supported
- remove the (junk) functional target from tox.ini
- fix yamllint target in tox.ini so it will actually
process files. Also added a basic yammlint settings file.
- nova-api-proxy tox jobs are now setup for py39
- Removed the py27 limitations from requirements files.
- Removed the upper limits for pylint and astroid.
- Added additional suppressions for new pylint codes.
Zuul changes:
- remove py27 job from zuul
- remove the unused (never working) devstack job
- set the parent zuul jobs to be the jobs defined under
openstack-zuul-jobs rather than just zuul-jobs
- Specify debian-bullseye (python3.9) as the nodeset.
ubuntu-jammy iss python3.10, ubuntu-focal is python3.8
- override tox constraints file to use the STX constraints
This means starlingx/root needs to be a required project
- Removed the nodeset from the pep8 jobs.
Note: these changes do not affect runtime for NFV.
Test Plan:
Pass tox in nfv directory of (debian) dev env.
Pass tox in nova-api-proxy directory of (debian) dev env.
build-pkgs -p nfv
Story: 2010531
Task: 47146
Signed-off-by: Al Bailey <al.bailey@windriver.com>
Change-Id: I6dad77bec40e9b64a9314b237270af046728efb3
Removing redundant py36 Zuul jobs since we now have py39 Zuul jobs in
place with the debian nodeset
Story: 2006796
Task: 43490
Signed-off-by: Bernardo Decco <bernardo.deccodesiqueira@windriver.com>
Change-Id: I678e8842e893f37d1897b153993085d7e5540f43
Add python3.9 gate for nfv.
Story: 2009101
Task: 43100
Signed-off-by: Charles Short <charles.short@windriver.com>
Change-Id: I4b2164e1b2f2f19df590b013e54f8dd42495259a
The py2.7 jobs need to specify xenial
Changed py37 to py36 and specify bionic.
The un-specified python3 jobs work fine on either
focal or bionic.
zuul is not setup to trigger off code changes in this repo
so no source code changes are required to trigger the zuul
jobs
Partial-Bug: 1928978
Signed-off-by: albailey <Al.Bailey@windriver.com>
Change-Id: Iab9c8727a0f16fa7ff02c20ca3bec5622abe7bd7
Also disabling the nfv devstack jobs. These jobs are failing
after the recent repo restructuring due to failures in the
FM devstack setup. The jobs can be re-enabled in the future
(after the issues are fixed), if there is some value in
doing so.
Change-Id: Ib443edc76ca636c83331945de74d875ffb3592ac
Story: 2004515
Task: 36579
Signed-off-by: Bart Wensley <barton.wensley@windriver.com>
Use templates instead of individual jobs so that these
can be changed in one place.
Depends-On: https://review.opendev.org/677606
Change-Id: I1b81f71977bcaa52e60566b9a64bffe6ffdab7d6
With the StarlingX move to supporting pure upstream OpenStack, the
majority of the SDK Modules are related to functionality no longer
supported. The remaining SDK Modules will be moved to StarlingX
documentation.
Story: 2005275
Task: 30545
Depends-On: https://review.openstack.org/#/c/653521
Change-Id: I842596dab79bff79313671e3e0b7aa7e4a93c493
Signed-off-by: Kristine Bujold <kristine.bujold@windriver.com>
nfv requires fm-rest-api, and fm-rest-api requires cgtsclient in
stx-config.
Add stx-config and cgtsclient to jobs to fix the dependency issue.
Try adding WSME in fm-rest-api setup...
Depends-On: https://review.openstack.org/649321
Depends-On: https://review.openstack.org/#/c/649169/
Change-Id: I6ee1cad6aa400f5b763a77e588da40c9332f4acd
Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
Rename stx-devstack-nfv to flock-devstack-nfv
and inherit from flock-devstack-base-min
Change-Id: Ib8aca1dcc09f489b3597daa78b60d39f3ffc54d5
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
The upstream OpenStack default node type changed yesterday
from Ubuntu Xenial to Bionic. We have a number of jobs pegged
directly to py35 which is no longer available in Bionic.
We can either pin the py35 jobs to Xenial nodes or update them
to py36 or py37. OpenStack is supporting both of those for the
Stein release, since StarlingX does not have any position on
Python 3 versions (yet!) I am suggesting we move straight to py37
and in the case of issues now make these jobs non-voting until
any incompatibilities are resolved.
Remove the stable/queens upper-constraints from nfv/tox.ini
Change-Id: Ibb0260d29e48447d770f76211ad4af9b736d7907
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
This makes some cleanup changes to the DevStack plugin for the
change to master and bionic.
* Define values for precedence handling by the upstream devstack playbook
* Add STX_INST_DIR for a deterministic install location
* Add stx-metal to required plugins
* Consolidate all of the is_enabled() handling in the main plugin
entrypoint functions in lib/stx-nfv
Depends-On: https://review.openstack.org/639858
Change-Id: If9fdc8221443561ed489c38b9006de2f6e9755d7
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
Add the minimum dependency bits for devstack master, plus the
required stx-update plugin in the devstack job definition.
The remaining master/bionic stuff will be in a follow-up review.
Change-Id: Id6b4e3dad1fe54d66b2b5a3dbbe3983621943bb2
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
This does not ensure nfv is python3 compatable, but
it does ensure that the current unit tests and code covered
by those tests work in python3.
The shell.py changes are due to a change in default values in argparse.
The instance director change is because python3 uses a reference
rather than a copy, for its dict keys.
Story: 2003427
Task: 28818
Change-Id: Iaccc0ab5fc4e30b41df108f817612abad8ec612c
Signed-off-by: Al Bailey <Al.Bailey@windriver.com>
* Add a basic DevStack job to exercise this
* Clean up plugin to match DevStack conventions
Change-Id: I5b079eacebf9ddb433b5e831d557afe6a1be6880
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
* Add pointers in the main doc to api-ref and releasenotes pages
* Add publish-stx-api-ref and publish-stx-releasenotes jobs
* Add search at bottom of api-ref and relnotes pages to trigger the jobs
Change-Id: If82fe40b570c43c4ac7b25e5bff5d3d72484677f
Signed-off-by: Abraham Arce <abraham.arce.moreno@intel.com>
Also set the theme to alabaster until starlingxdocs is ready
Change-Id: Iccf80cf54075925752a3c3773ba7ccba0c47aed3
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
Baseline changes to comply with Release Notes Management
based in Reno [0]:
* Use build-openstack-releasenotes job for release notes
(We can't use the OpenStack releasenotes template as it includes
publish jobs, stx needs its own)
* Add newnote tox environment as convenience for creating new release
notes, re-using the releasenotes venv.
* Change to SPDX-License-Identifier: Apache-2.0
[0] https://docs.openstack.org/reno/latest/
Story: 2003101
Task: 26667
Change-Id: I33b3083a952faf36168faec4255bec0f25edf9ca
Signed-off-by: Abraham Arce <abraham.arce.moreno@intel.com>
Added a python3 tool called bugbear as part of flake8
Moved the tox.ini for nfv to a new location.
Removed nfv tox calls from the bottom level tox.ini file
Specified the queens upper-constraint. This is because the
kubernetes client from pike is not what is shipped.
Adds a separate tox.ini for nova-api-proxy.
Fix two of the errors flagged by bugbear:
B006: Do not use mutable data structures for argument defaults.
B306: BaseException.message has been deprecated as of Python 2.6
and is removed in Python 3.
Fix unused imports in Flake8
F401 '<module>' imported but unused
Clean up two pylint errors:
W0102 dangerous-default-value
W0631 undefined-loop-variable
Story: 2003499
Task: 26410
Change-Id: I61deb6a002f963cd58fe019bb54a4c3296809391
Signed-off-by: Al Bailey <Al.Bailey@windriver.com>
Turn on zuul voting for py27 in stx-nfv
Modify tox envlist to reflect check jobs
Add pylint to gate jobs
Story: 2003499
Task: 26217
Change-Id: I1c966ac571d88a4487752ae8bbcdc219e4c2b66c
Signed-off-by: Lachlan Plant <lachlan.plant@windriver.com>
This invokes pylint on all the nfv code.
The pylint.rc file currently suppresses failing lint tests.
In later submissions those suppressed types will be enabled
and their code fixed.
Story: 2003499
TaskId: 24944
Change-Id: I4726927a9e5e76a242dec3f7b25f51b2887e505e
Signed-off-by: Al Bailey <Al.Bailey@windriver.com>
Also remove bashate from the linters job and the placeholder shell script
as there are normally no shell scripts in this repo.
Change-Id: I41f86245f5809471f894b18a7fa320c938f9e861
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
Davlet Panech