openstack
/
sushy
Code Issues Proposed changes

Enable some off-by-default checks 

Some of the available checks are disabled by default, like:
[H106] Don’t put vim configuration in source files
[H203] Use assertIs(Not)None to check for None

Change-Id: I380596faf23005e03a9a45f06cade5cb05837fb5
This commit is contained in:
loooosy 2017-07-11 10:43:43 +08:00 committed by Nate Potter
parent ad0d018fbd
commit 23c9bad3bd
2 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sushy/tests/unit/resources/system/test_system.py
View File

@ -222,7 +222,7 @@ class SystemTestCase(base.TestCase):
self.sys_inst._parse_attributes()
# | THEN |
self.assertEqual(96, self.sys_inst.memory_summary.size_gib)
self.assertEqual(None, self.sys_inst.memory_summary.health)
self.assertIsNone(self.sys_inst.memory_summary.health)
# | GIVEN |
self.sys_inst._json['MemorySummary'].pop('Status')
@ -230,22 +230,22 @@ class SystemTestCase(base.TestCase):
self.sys_inst._parse_attributes()
# | THEN |
self.assertEqual(96, self.sys_inst.memory_summary.size_gib)
self.assertEqual(None, self.sys_inst.memory_summary.health)
self.assertIsNone(self.sys_inst.memory_summary.health)
# | GIVEN |
self.sys_inst._json['MemorySummary'].pop('TotalSystemMemoryGiB')
# | WHEN |
self.sys_inst._parse_attributes()
# | THEN |
self.assertEqual(None, self.sys_inst.memory_summary.size_gib)
self.assertEqual(None, self.sys_inst.memory_summary.health)
self.assertIsNone(self.sys_inst.memory_summary.size_gib)
self.assertIsNone(self.sys_inst.memory_summary.health)
# | GIVEN |
self.sys_inst._json.pop('MemorySummary')
# | WHEN |
self.sys_inst._parse_attributes()
# | THEN |
self.assertEqual(None, self.sys_inst.memory_summary)
self.assertIsNone(self.sys_inst.memory_summary)
def test_processors(self):
# check for the underneath variable value

4
tox.ini
View File

@ -40,8 +40,10 @@ commands = oslo_debug_helper {posargs}
[flake8]
# E123, E125 skipped as they are invalid PEP-8.
show-source = True
ignore = E123,E125
# H106: Don’t put vim configuration in source files
# H203: Use assertIs(Not)None to check for None
enable-extensions=H106,H203
builtins = _
exclude=.venv,.git,.tox,dist,doc,*lib/python*,*egg,build