openstack
/
sushy
Code Issues Proposed changes

Change assertTrue(isinstance()) by optimal assert 

Some of tests use different method of assertTrue(isinstance(A, B)).
The correct way is to use assertIsInstance(A,B) provided by testtools.

Change-Id: I24ad3eb8bc073fd6bf0a8679eb1104cd2f4f9994
Closes-bug: #1268480
This commit is contained in:
Vu Cong Tuan 2017-06-07 14:54:28 +07:00
parent c70d2490db
commit 7b96e4aefd
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sushy/tests/unit/resources/test_base.py
View File

@ -96,7 +96,7 @@ class ResourceCollectionBaseTestCase(base.TestCase):
# | WHEN |
result = self.test_resource_collection.get_member('1')
# | THEN |
self.assertTrue(isinstance(result, TestResource))
self.assertIsInstance(result, TestResource)
self.assertEqual('1', result.identity)
self.assertEqual('1.0.x', result.redfish_version)
@ -120,9 +120,9 @@ class ResourceCollectionBaseTestCase(base.TestCase):
# | WHEN |
result = self.test_resource_collection.get_members()
# | THEN |
self.assertTrue(isinstance(result, list))
self.assertIsInstance(result, list)
for val in result:
self.assertTrue(isinstance(val, TestResource))
self.assertIsInstance(val, TestResource)
self.assertTrue(val.identity in member_ids)
self.assertEqual('1.0.x', val.redfish_version)