openstack
/
sushy
Code Issues Proposed changes

Cleanup JsonDataReader name 

Changed name of JsonFileReader to JsonDataReader to better
indicate that it reads from HTTP responses and not local
filesystem files.

Followup to I3609df39c68f2149c1ff1a6818af7168bbd02df0

Change-Id: Ib591f5c2fb522ca81e8f9d93fcb3f653c9586e2f
This commit is contained in:
Aija Jaunteva 2018-10-29 13:42:24 +02:00
parent 3bf894c097
commit 9a0b773438
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sushy/resources/base.py
View File

@ -264,8 +264,8 @@ class AbstractJsonReader(object):
"""Based on data source get data and parse to JSON"""
class JsonFileReader(AbstractJsonReader):
"""Gets the data from JSON file given by path"""
class JsonDataReader(AbstractJsonReader):
"""Gets the data from HTTP response given by path"""
def get_json(self):
"""Gets JSON file from URI directly"""
@ -309,7 +309,7 @@ class ResourceBase(object):
connector,
path='',
redfish_version=None,
reader=JsonFileReader()):
reader=JsonDataReader()):
"""A class representing the base of any Redfish resource
Invokes the ``refresh()`` method of resource for the first
@ -319,7 +319,7 @@ class ResourceBase(object):
:param redfish_version: The version of Redfish. Used to construct
the object according to schema of the given version.
:param reader: Reader to use to fetch JSON data. Defaults to
JsonFileReader
JsonDataReader
"""
self._conn = connector
self._path = path