Commit Graph

12 Commits

Author SHA1 Message Date
ramishra 0b8717e0c8 Cleanup dead mistral actions and workbooks
- Removes unused mistral actions
- All mistral workbooks
- Custom filter for undercloud nova
- mistral entry points as we don't have mistral

Depends-On: https://review.opendev.org/c/openstack/python-tripleoclient/+/775749
Change-Id: I7f826da829bbc7d7a4fcde8afcea3f61742a316a
2021-02-17 20:32:01 +05:30
Rabi Mishra be7c90e30c Match hostname when doing node delete
``overcloud node delete`` at present matches the provided nova
instance ids with existing severs to build the heat blacklist.
This patch would allow users to also use hostnames when deleting
nodes. This will work with deployed servers and scale_playbook.yaml
that matches host pattern.

Partial-Bug: #1869089
Change-Id: I3066689facc169125ade29156190cb98910f32b8
2020-03-31 10:11:43 +05:30
Rabi Mishra 4d969f0456 Move process template functionality to utils
Change-Id: I6c48d8dd3c5c480eef0001746ce5e243d6820be9
2020-02-12 11:44:09 +05:30
Rabi Mishra 8f5c494150 Reset *RemovalPoliciesMode for node delete
'update' *RemovalPoliciesMode during 'node delete' can result in
undesired behaviour as we flush the blacklist history and use
the freshly constructed blacklist and decrease the node count.

Change-Id: Iebd0089b6ab35c84e4f20e83f1990c1c5568017f
Closes-Bug: #1848651
2019-10-18 12:23:53 +05:30
Brad P. Crochet 5a11fb16ad Remove ProcessTemplatesAction as base class
A number of actions still use ProcessTemplatesAction as a base class.
This doesn't make sense in most cases. This is an attempt to decouple
these classes.

Change-Id: I93106288c3f085034efb79a89e01b705f70db6ee
Co-Authored-By: Alex Schultz <aschultz@redhat.com>
2019-04-17 11:11:05 -06:00
Brad P. Crochet 71e30eebe0 Return any errors from called actions in node delete
The node delete action (ScaleDownAction) wasn't passing errors back
from called actions. This results in the workflow continuing to look
for a stack to go to INPROGRESS that never will.

Change-Id: Ia43e0a06215ad19d4b49f1721026db7519220799
Partial-Bug: #1749426
2018-03-15 11:18:57 -04:00
rabi 7213aa5669 Fix overcloud node delete after an upgrade
In fbc435ce16, we stopped passing
'parameters' to stack update call. This is backward incompatible
as the 'parameters' set for the stack before an upgrade would take
precedence over the ones set in 'parameter_defaults' of plan env.

Change-Id: Ia1d823386da687154c433136bf22ae6a0291573d
Closes-Bug: #1749636
2018-02-15 11:27:36 +05:30
Adriano Petrich 76b3e025b7 use Result from mistral_lib instead of mistral
This is part of the ongoing change to remove the mistral
dependency from tripleo-common and use mistral_lib instead

In order to do that we are using the Result class from mistral_lib

Change-Id: I59ce8c6d68de9e9719d84cbaa82462fbd8d647e2
Depends-on: Icc0036bae3c969112f2f67c4a8264bae18f3cc73
2017-06-23 14:20:45 +01:00
Adriano Petrich fbfe481ee4 move mistral base action dependency to mistral_lib
mistral_lib base TripleoAction has a context in the run method
signature. These changes remove the mistral.context and make use
of the one provide by the default executor

Change-Id: Ib1a5aa8d5735b05f5308dc943ac088b5eeeec253
2017-05-17 23:51:05 +01:00
Dougal Matthews 9d3d03436a Remove the underscore from the base action client methods
The underscore typically designates these methods as private, but
they are intended to be used by any/all of the subclasses. This
change clarifies the API.

Change-Id: I4dc95a0e1f84570b184f8b75f51a2c1456909fb9
2016-11-28 13:09:38 +00:00
Jiri Stransky fbc435ce16 Only use parameter_defaults for scaling down
We were using parameters for scaling down but parameter_defaults for
scaling up. The old parameters from scale-down still persisted in the
stack and took precedence over the scaled-up parameter_defaults, so the
scaled-up values didn't propagate.

We already update parameter_defaults in the deployment plan in that same
method, so all we need to do is remove the 'parameters' part.

Change-Id: I90a195a66b15c7c9057bfb415b6a730bbd9a939c
Closes-Bug: #1641142
2016-11-11 18:43:00 +01:00
Ryan Brady 28edd93db6 Port Scale Down Functionality into Workflow
This patch ports the logic of the ScaleDownManager into an action
and an associated workflow to expose it.

Partial-Bug: #1626736
Co-Authored-By: Dougal Matthews <dougal@redhat.com>
Change-Id: Ia31a03c8f0a99dd92b18ffbf76d689b037ef8a78
2016-10-14 13:29:49 +01:00