Makes those files conformant with current linting rules and avoids
linting errors when we need to toch them again.
Previous doing "pre-commit run -a" uncovered these errors, now is no
longer reporting any other errors.
Change-Id: Ie4cf229c8f11c2b55b323eac23c89483b26d3781
This reverts commit 44ee46e826.
'timeout' in deploy command doesn't work always and we can't
realy on it that it will stop deployment in time and allow
openstack nodes to be added to inventory.
Change-Id: I744aea580d9f22a930a86772847c9665c012dd2a
Related-Bug: #1743436
It is possible the tripleo-inventory role fails, for instance if the
undercloud install didn't go as planned and it couldn't generate
a stackrc.
Ignore errors to collect at least some amount of logs.
Change-Id: I5a4d3e67a7144e76987859fe8aae33fe809d32e4
If the overcloud deploy times out, we don't currently get logs from
overcloud nodes because we never got to the task that adds them to the
ansible inventory.
This patch addresses that by always rebuilding the dynamic inventory as
the first task in the collect-logs playbook.
Partial-Bug:# 1738038
Change-Id: I7bf7733ed93179d15f287513d8031223d3966cc1
If running quickstart on localhost, we use usually 127.0.0.2 IP
address instead of "localhost". We need to exclude it from logs
collection exactly as localhost. Logs from local host will be
collected according to its role (virthost, undercloud, etc).
Change-Id: I53483fcb1ecc2b548e41a1ac501660392f7661e9
We should run and publish a minimal sets of files even without any host,
when we failed the run before inventory generation.
This change separates the collection step that runs on all hosts except
localhost, and the rest running on localhost. Running on localhost
always succeeds, even with an empty inventory.
Also add a log environment file for local collect-logs.sh runs that
does not upload logs.
Change-Id: I48d07d42be879026fb80afd73835484770006f85
In preperation for integrating tripleo-documentor[1] funtionality into
tripleo-collect-logs, it makes sense to break apart the collect and
publish sections of the role. This keeps things neat and distinct.
[1] - https://github.com/HarryRybacki/tripleo-documentor
Change-Id: I165dc823ae0dd489a085c1bb7c00871db2d988ba
Ghanshyam Mann