This change removes logic for releases older than train, because these
releases are already EOLed. This covers only undercloud-* roles and
playbooks.
Note that this change also removes the containerized_* variables
because current active releases(>=Train) no longer supports
non-containerized deployment. The containerized_undercloud_upgrade
variable is still left because the variable is still required by
the tripleo-ci-base-multinode-standard job template.
In addition, TripleO UI support is removed because the component was
retired before Train.
Change-Id: I5132e5bac4ddaa6f76564cab67e486cb5a4e2bbb
Since we're moving the masquerade management out of puppet[1], we
cannot rely on hieradata anymore.
This patch creates a custom_env_file taking care of the override of the
actual heat MasqueradeNetworks parameter.
It also get rid of an ugly pattern, and uses an actual list for the
custom_env_files (while still supporting the space separated string).
[1] https://review.opendev.org/q/topic:masquerade-ansible
Depends-On: https://review.opendev.org/c/openstack/tripleo-ansible/+/836871
Change-Id: I977d245eb4863b37c63e21c416debe8df34b813b
Use undercloud_install from tripleo-operator-ansible
for all supported releases i.e train+.
Also cleanup vars/templates related to legacy undercloud
install.
Due to release=master condition tripleo-operator-ansible
was used only for master and in mean while there were
multiple releases.
Change-Id: I813decf17ff58b53677bd84a4fab5c1fad7d60ef
`--old-deploy-image` was added as liberty only code to allow uploading
the old deploy ramdisk.[1]
Since Mitaka the old ramdisk is not be supported. With this patch:
removing this from ci code as well.
[1] https://review.opendev.org/c/openstack/python-tripleoclient/+/263351
Change-Id: I3a86c000a3d46dd8cfdc92ad30fcde21f522a5be
To run TLS-E without novajoin, set undercloud_enable_novajoin
to false. To avoid confusion, this changes the previous behavior
of undercloud_enable_novajoin flag and it's default value. The
original flag wasn't used, because novajoin is only used for
TLS-E, so it doesn't make sense to deploy it otherwise.
Depends-On: https://review.opendev.org/731383
Depends-On: https://review.opendev.org/740951
Change-Id: Id97074ff7b1341942e8c85fc709a83b33e0af414
Only install ara on mistral executor container if
undercloud_enable_mistral is set to True, otherwise we obviously don't
want it.
Move undercloud_enable_mistral to extras-common so it can be used by
both overcloud-prep-images and undercloud-deploy roles.
Change-Id: I69073b007138d8941da878def7033ffaf79e8f5d
Add a new ansible parameter to control if paunch is enabled or not:
undercloud_enable_paunch (undefined by default).
It'll configure the undercloud.conf and tripleoclient will configure the
right Heat parameter to disable Paunch when wanted.
Change-Id: I67c1f61d8422fba1d70f6075bbb116305513acf6
If `baremetal_provision` is `true`, deploy baremetal with "openstack
overcloud node provision" and deployed-server, instead of with
heat/nova.
Change-Id: I57893a64f4c3224ffe8bd12330f12bd9d3cbbf89
Blueprint: nova-less-deploy
This change propagates the undercloud_enable_nova quickstart variable
to enable_nova in undercloud.conf
Blueprint: nova-less-deploy
Change-Id: I88acc8b25684036e76434ecabc1a8624c4584c86
The openstack undercloud deploy command has been deprecated and will be
removed. This change removes the support for this method via the
undercloud-deploy role.
Change-Id: I4c6a46d9dcee4efc38a3de682ecffacf529288b8
Starting from Stein, we want the Undercloud to be deploying Podman
containers instead of Docker containers.
This patch switches container_cli to be 'podman', and make sure we only
configure this new parameter in Stein and beyond.
Also run the container CLI with sudo, it's required to Podman on CentOS7.
blueprint podman-support
Change-Id: I21662de8ac0101a25c2b73a4650bb4af0f5df89a
Makes those files conformant with current linting rules and avoids
linting errors when we need to toch them again.
Previous doing "pre-commit run -a" uncovered these errors, now is no
longer reporting any other errors.
Change-Id: Ie4cf229c8f11c2b55b323eac23c89483b26d3781
This new parameter will be useful to run Podman instead of Docker on the
Containerized Undercloud.
The default remains to 'docker'.
blueprint podman-support
Change-Id: I7b84cb550e7d52e4781ae78e1eb928ae8cfa3a75
By default, provide no overrides for the resource_registry
used to deploy undercloud with heat. This allows to
use t-h-t defaults, by quickstart default, and seems better
than running with opinionated values.
Change-Id: I7025965f612acde88690336cb353c8a91b6f543d
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
In Stein we've dropped the undercloud install via instack so we need to
be able to override the command so that we can properly continue
testing instack-undercloud.
Change-Id: Ic13488cbebe2ec5fb3a60f04898c3af12280d62c
Related-Blueprint: remove-instack-undercloud
Allow undercloud installations/upgrades from custom t-h-t, similarly to
overcloud_templates_* et al.
Unify and share custom t-h-t install script for OC and UC and mixed
update/upgrade cases via new shared role tht-prep-config.
To diverge undercloud from overcloud install/update/upgrade cases, use
the following shared mappings (vars on the right correspond to UC
cases):
* tht_templates_path: undercloud_templates_path (defaults to RPM dir)
* tht_templates_repo: undercloud_templates_repo
* tht_templates_branch: undercloud_templates_branch
* tht_templates_refspec: undercloud_templates_refspec
and a 2nd group (defaults set to do nothing, but only disable the
t-h-t prepare script's code blocks under control of those):
* composable_scenario: undercloud_composable_scenario
* upgrade_composable_scenario: undercloud_upgrade_composable_scenario
* prep_post_hook_script: undercloud_prep_post_hook_script
* download_templates_rpm: download_undercloud_templates_rpm
* tht_rpm_url: undercloud_tht_rpm_url
Those in group 2 may be customized to mimic the overcloud mixed
upgrades logic for underclouds/all-in-one for future use.
And for overclouds respectively, use mappings:
* composable_scenario: remains unchanged
* upgrade_composable_scenario: remains unchanged
* prep_post_hook_script: overcloud_prep_post_hook_script
* download_templates_rpm: download_overcloud_templates_rpm
* tht_rpm_url: remains unchanged
* tht_templates_path: overcloud_templates_path
...
Related-bug: #1691467
Closes-bug: #1781227
Change-Id: I4e0dcf24b93b8e4afb8359cb5108c4b7b5ba3d55
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
Make net_config_override and undercloud_resource_registry_args
mutually exclusive. When net_config_override is defined, we do
not want resource_registry for the network config in tht, as
they might happen to be in the direct conflict.
Closes-bug: #1781577
Change-Id: I802b525d477fd29a2ad746256a342acb364b0d1d
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
By default SELinux will be disabled on underclouds being installed on
CentOS and enabled on RHEL.
Change-Id: I9dd91302e895dc12814022fbc703f68fd01327d2
Depends-On: I6973fec9bcc55373f89e5c873ff6ae7050fff432
Closes-Bug: #1779005
This file will write out the heat environment file
containers-prepare-parameter.yaml which will be used to do any
required image preparation during undercloud install.
The role parameter undercloud_container_images_file has been left as
an option for overriding, but is no longer required.
This change also switches the overcloud prepare to consume this file
via the command "openstack tripleo container image prepare"
It is expected that overcloud deploy will use the exact same
containers-prepare-parameter.yaml and the logic will be in place to
skip any unnecessary prepare actions. For this reason, the parameter
undercloud_docker_image_tag has been removed, and docker_image_tag is
used directly.
Since this file (and the variables used to build it) will be common to
undercloud and overcloud, there has been some refactoring to move
variable defaults to extras-common.
Change-Id: I290806b9296773688dfd02bc41f8baea28cf3d6a
Blueprint: container-prepare-workflow
It had been missing for some places and now that
technical debt gets addressed.
Depends-on: Iaef2671acf516b7e89358984a0d8a59555fc91f0
Change-Id: I887d5bccc6bd5c514348d8ebfc7c13f0bcdc217d
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
This param is useful if we want to cleanup the undercloud after its
containerization during the upgrade process from Queens to Rocky.
Set to true, it'll removes the rpms deployed on the undercloud that are
not needed anymore since we containerized the services.
Change-Id: If3a3a3b2e4a6d1cf6cd57c3b382a7a08fac0e971
1) Update the doc links according to OpenStack document migration
2) Fix the doc links according to the lastest OpenStack Website
Change-Id: I15e7659a91dd9aaec8cb5cb96d20e8c318609d61
...and tripleoclient.
When installing via 'undercloud deploy', add
environments/docker.yaml explicitly, as the client
does for undercloud install --use-heat.
Use undercloud_custom_env_files instead of
undercloud_extra_services_args.
Allow to override undercloud net config via a
custom file defined from undercloud_net_config_override.
Default t-h-t params file for net config are generated from
undercloud_resource_registry_args and
undercloud_network_environment_args and can be overriden via
undercloud_net_config_override and/or undercloud_custom_env_files.
This maintains feature parity of containerized UC heat
installer with instack/undercloud.conf.
Closes-bug: #1763337
Depends-on: I3b59abc839ec6c709e5fd24652610a5fac58ee57
Change-Id: Iaeca9ea014d99147461c6e3fae3122e27cb88c1d
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
Complement Idf595498e46eeb88acfd4c3a21094d22197a6d7b
and make sure heat installer takes a valid hieradata
override file depending on config vars setup.
Update README as well to explain the cases better.
Closes-bug: #1766579
Closes-bug: #1766848
Change-Id: Id821f613fe72e2f768f80acaa5657a8be86879b7
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
* In order to achieve the containerizing tempest goal, we need to
make sure the tempest fake service is available on the undercloud
so that it can be used for running tempest tests.
Change-Id: I0dd38ea4ffbe06eb10d7f86a9f87333c193ea398
By default, we don't need to prepare the containers anymore, since they
are now prepared in tripleoclient since:
I00f72b1cd7ab6a03dd42bc489f3c950ee32dedeb
We also introduce update_containers boolean that will be use in the near
future, so we will prepare containers, update them and use them to
deploy the undercloud and overcloud. This will be pushed later though.
Change-Id: I5b76f80cfa4066845c0ec4c9e765d57d9ec2bfc9
This updates the relevant environment/services-docker code
for undercloud-deploy to default to dockerish environment/services.
Change-Id: I8f452e34bffb269741f0831a6d61aece9722f860
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
When processing heat templates for undercloud deployments
driven with heat, allow to specify conf options for the
tripleo client.
Depends-on: Ib0c2e3ffd81742441400d27857afae457d71a424
Change-Id: Ieba5f34ffe40a4b89ecde4903a4abc86915f017c
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
This patch contains changes to deploy a containerized undercloud by
using: "openstack undercloud install --use-heat" command.
Details of the changes:
- The experimental containerized undercloud deployments driven via
`undercloud deploy` CLI is not supported anymore for Pike.
- overcloud-prep-containers: fix an jinja2 syntax issue with "is defined"
- overcloud-prep-images: "--http-boot=/var/lib/ironic/httpboot" is
added to the "openstack overcloud image upload" command.
- undercloud_rpm_dependencies parameter has been created, default to
undercloud_tripleo_pkg value.
- Remove "undercloud_tripleo_pkg" so we only use
"undercloud_rpm_dependencies". Note that "undercloud_tripleo_pkg"
was only used in this repository.
- Remove "undercloud_update_packages" option which was technical debt.
- Add "undercloud_install_cli_options" option which is used to add extra
options to "openstack undercloud install" command.
- Add "undercloud_container_images_file" which is the environment file
with default parameters for containers to use with undercloud install CLI.
- Add "undercloud_custom_env_files" which provides custom t-h-t env files
for the "undercloud install" `undercloud.conf` interface.
- Generate the undercloud prep containers script. This script will
reproduce what we expect from our users to run with
"openstack overcloud container image prepare" command, for the
undercloud.
- Update undercloud-deploy.sh.j2, remove tech debt and update for new
bits.
- Install heat libraries and other dependencies for containerized UC
from python-tripleoclient-heat-installer. This should go away
once python-tripleoclient installs python-tripleoclient-heat-installer
automatically.
- Update undercloud-install.sh to use undercloud_install_cli_options
which is empty by default but will be used in the container-undercloud
featureset to override with the right parameters.
Partially-Implements: bp containerized-undercloud
Co-Authored-By: Bogdan Dobrelya <bdobreli@redhat.com>
Co-Authored-By: Emilien Macchi <emilien@redhat.com>
Co-Authored-By: Ian Main <imain@redhat.com>
Co-Authored-By: Martin André <m.andre@redhat.com>
Co-Authored-By: Wes Hayutin <weshayutin@gmail.com>
Change-Id: I7d056b208d5ac0639e3277f3f4ae453a9ee639e8
The noop network config had been removed from the
containerized undercloud deploy script. With the t-h-t
default network configuration, CI wants eth1 and fails
as there is no such interface available for CI slaves.
Parametrize undercloud network config following the
existing overcloud network configuration parameters:
- (undercloud_)resource_registry_args
- (undercloud_)network_environment_args.
Set the default net config to net-config-noop.yaml.
Remove network_environment_file as never used for UC.
Closes-bug: #1746540
Change-Id: I8aa0ca5312a162e11c04bce7da4c59980799e8d0
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
To alleviate missing flexibility ( like proposed in
I6d61dee8c19f708bc834a497593122f23ef2baf4 ) for the experimental
undercloud deploy CLI options passed via quickstart inventory
vars, allow to specify:
* The client's --local-domain via undercloud_cloud_domain
(unset by default)
* Additional services environments files. Defaults to those
currently hardcoded. The hadcoded values go away as well.
Change-Id: I706d3386288fa4c9086294ec5bcdb746c539ca37
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
Fix undercloud deploy references to the deprecated packages:
* openstack-puppet-modules is deprecated, use puppet-tripleo instead
* use the openstack-heat-agents package to install all of the
python-heat-agent packages, instead of having to specify
each individually
(follows-up I72caf6ff0dfa3f164737b92e89c1cc6043845864)
Change-Id: I3d7258415723143741b9059b73e2cc0dab870fa0
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
A prior patch merged that caused a regression in newton..
5c966baa20
This commit moves the default for undercloud_enable_mistral to true
Change-Id: I8d9d395f98221b10847ae16ca300fbb5e8a2896d
Closes-Bug: #1737502
Stop making assumption about the default values from undercloud.conf.
These can change and break quickstart. This also means the generated
undercloud.conf has broken documentation the day a default value
changes, making it harder to debug failures.
Be more specific and set defaults values for boolean variables.
Change-Id: I9c530e2234e627e9795347d2e5208e8dc965bb45
The tripleoupstream registry is deprecated in favor of tripleomaster,
where images are pushed automatically on rdo promotion.
Change-Id: I84724efedb6e7ff967469d0e4277aa6fd9538748
Images for containerized underclouds can be parametrized differently
as for overcloud deployments. For example, undercloud may fetch images
from a promotion pipeline, while overcloud may consume those from the
local registry hosted undercloud.
Align the containerized undercloud case with the recent changes docker registry
host, namespace and tag defaults. Consumed these from the common defaults, yet
allowing to diverge.
Fix conditions for undercloud-deploy to always prepare undercloud images for
containerized underclouds. If built locally with kolla, the undercloud_docker_*
parameters should point to a local registry. If fetched from remote registry,
the same logic applies. Altering `undercloud_docker_*` allows to cover
such cases.
Add the missing `undercloud_docker_registry_tag` parameter. Allow omitting
`undercloud_docker_registry_port`, when a registry host value does not require
a port, like 'docker.io' host.
Closes-bug: #1733800
Change-Id: Ic3d448c8215f44a957711e666a34e78482d8100d
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
This is no longer required as the prepare command detects whether the
registry is secure and DockerInsecureRegistryAddress as necessary.
Change-Id: Ieac6b4b2a7ab81688d1dc4315c312eef8be500c9
Depends-On: I74586145c222921880402cec92bbaa5f10e8b972
Related-Bug: #1722632
Allow tripleo client to generate default parameters
for undercloud container images from docker.io/tripleoupstream
images or a given docker registry host, port, namespace and
(un)secure access mode.
Switch heat-all to run in a container defined from that template
to minimize installation of dependencies.
Change-Id: I8cb71be205aec1122cadbdb045efa71e1f7d01d1
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
Set the overcloud_domain_name option in undercloud.conf using
the overcloud_cloud_domain variable that we already use for the
overcloud's CloudDomain, and for setting FreeIPA's realm.
Change-Id: I24315644a5c658f11201cebef9ad3af1edd501e8
The tripleo-ui requires that the javascript configuration
be updated for virt deployments using a ssl tunnel to connect.
It uses by default non-ssl ports and virthost address as the ip.
Depends-On: Id53c5bd7f199c64bc9cb37df7e63f27c4673f415
Change-Id: Ie9d3e7d12c420b9b65c25692435c0457f1233a27
Address the tech debt introduced in the quickstart-extras
undercloud-deploy role. Move installation of the packages
into the client's 'openstack undercloud deploy' prerequisites phase,
executed as a separate deployment step.
Change-Id: Id22ac7833360bf6ebdcdaaf0032c5c66182dbce1
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
* Parametrize network settings for undercloud deploy to align with
the undercloud install's undercloud.conf and nova-join's DNS
config steps.
* Move the undercloud nameservers defaults to the extras-common.
* Support extra deploy args for 'openstack undercloud deploy'.
Defaults to the heat-native mode, may be altered to containerized
heat-all agents, and other args like keep-running, if wanted.
* Support custom t-h-t templates for underclouds as well (shares
the custom t-h-t script and vars with the overcloud-prep-config)
* Template prerequisite packages installed by the
undercloud-install.sh script. These should be moved to the
tripleoclient's 'openstack undercloud deploy', eventually.
* Allow requested dev env packages to be updated by the
undercloud-install.sh script (defaults to update nothing,
which is backwards compatible). Note, this has nothing to the
prerequisite packages.
* Document missing variables for the undercloud-deploy role.
* Document hacking dev branches for customized underclouds.
Related-bug: #1691467
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
Change-Id: Id32f492369dc74428bde8c4120308279cbba53fc
Ghanshyam Mann
yatinkarel