- run `pre-commit autoupdate` and fixed new issues
- adopted newer pre-commit config for ansible-lint 4.2.0+
- fixed some reported broken rules
- temporary disabled few rules, just to contain the size of of review,
planning to drop/fix them in follow-ups.
Change-Id: I807ba4e919527be56c85ec72d0f4c7148f04e994
- Fixes 206 errors and removed the skip.
- Also replaces revision with latest tag (pushed today)
Bug: https://bugs.launchpad.net/tripleo/+bug/1848512
Change-Id: I69d75ba9de8ab0e91eb45fd4f9febfdb28cdcb3a
Makes those files conformant with current linting rules and avoids
linting errors when we need to toch them again.
Previous doing "pre-commit run -a" uncovered these errors, now is no
longer reporting any other errors.
Change-Id: Ie4cf229c8f11c2b55b323eac23c89483b26d3781
We are moving away from hardcoding the stack user and opting to
replace it with `undercloud_user` and `non_root_user` as appropriate
to increase flexibility of OOOQ and OOOQ-Extras.
Change-Id: I7ea43a3fabab2c69fd4f3b5550ea5e4627443406
- According to the ansible-lint documentation, we can pass a role directory as
an argument. But due to https://github.com/willthames/ansible-lint/issues/210,
the role directory has to contain a trailing slash!
- This patch fixes the following ansible-lint rules:
* ANSIBLE0004: Git checkouts must contain explicit version
* ANSIBLE0008: Deprecated sudo
* ANSIBLE0011: All tasks should be named
* ANSIBLE0014: Environment variables don't work as part of command
* ANSIBLE0015: Using bare variables is deprecated
- Temporarily skipping the following ansible-lint rules (Fixes will be part of
others patches):
* ANSIBLE0007: Using command rather than an argument to e.g file
We have a lot of 'rm' command and we should use file module instead
* ANSIBLE0012: Commands should not change things if nothing needs doing
* ANSIBLE0013: Use Shell only when shell functionality is required
Change-Id: I3d5591ea9fd1691e8115d7093db87781a08a6082
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
- This patch avoids deprecations warning about using sudo/sudo_user
instead of become/become_user.
Change-Id: I1f4909cd25ffbe3d53dd55118fe1af0052cf6b9a
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
Ghanshyam Mann