This change removes logic for releases older than train, because these
releases are already EOLed. This covers only overcloud-* roles and
playbooks and the other items will be covered by separate changes.
Note that this change also removes the containerized_* variables
because current active releases(>=Train) no longer supports
non-containerized deployment. The containerized_overcloud_upgrade
variable is still left because the variable is still required by
the tripleo-ci-base-multinode-standard job template.
Change-Id: If29ec2c2219a28a1f79db0e552e2c622c0a7bda6
Upgrades yamllint to latest version and adots use of its strict
checking.
Fix all known problems reported by yamllint so we don't have to do
that while touching these files.
Change-Id: I4bdc520d9e2aff086c4b463718bc1e053261a4f5
Story: https://tree.taiga.io/project/tripleo-ci-board/task/381
Makes those files conformant with current linting rules and avoids
linting errors when we need to toch them again.
Previous doing "pre-commit run -a" uncovered these errors, now is no
longer reporting any other errors.
Change-Id: Ie4cf229c8f11c2b55b323eac23c89483b26d3781
We need to use in allow-traffic-for-controller.yml the same conditionals
that we have in prep-network [1] otherwise the script to allow the
traffic will be executed and, since it expects to find the BOOTSTACK_MASQ
iptables chain, will fail.
[1] roles/overcloud-prep-network/templates/overcloud-prep-network.sh.j2
Change-Id: Ia104eecbe29c1eee230c2ccbc5926ca8bfbffc83
This reverts commit c1d0eb1c87.
Since this was fixed in queens/master, we don't need to run it in queens
and master so we've added a release clause.
Change-Id: I8b5b6ed983b1560f9f834abd8a54ae53b4db3465
Related-Bug: #1760189
- dhcp-match is already managed in Neutron since https://review.openstack.org/#/c/172040/
- MTU option shouldn't be managed by TripleO Quickstart.
Change-Id: I68701b45801c9c25f2a60d1a4afc51955a84c546
When using boolean variables in conditional tests, those variables
should be filtered as '|bool'. Otherwise, they are being evaluated as
a string and return True in any case.
Change-Id: I1e3642cb2d33d839e4808ae79ae991175e32dd0f
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
This commit adds the removal of the /tmp/ipxe directory before
downloading the upstream sources via git.
This will make this script idempotent, otherwise if the directory is
present git command will fail with the entire quickstart command.
Change-Id: Ic2e690f892300d7b17daa256242e2b59424d68f2
This will now run bashate on all shell scripts. We could ignore the
following list of bashate errors:
- E006: Line longer than 79 columns (as many scripts use jinja
templating, this is very difficult)
- E040: Syntax error determined using `bash -n` (as many scripts
use jinja templating, this will often fail and the syntax
error will be discovered in execution anyway)
Change-Id: I6f6d454ac54a0ac98d8b8a092fa522cba092a592
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
We need to differentiate local_working_dir from working_dir
as well as decouple the stack user from `ansible_user` var.
Both of these are causing issues as we begin to automate
deployments in more environments.
- Cleanup duplicate variables that are consumed via extras-common
- Note: extras-common depends on the common role in OOOQ
- Cleanup redundant var and superfluous quotes from overcloud-scale
role
- Cleanup redundant comments in <role>/defaults/main.yml
Closes-bug: 1654574
Change-Id: I9c7a3166ed1fc5042c11e420223134ea912b45c5
As more ansible variables are shared or reused across roles it is
important to define these variables in a role that is always
executed. In this case that role is extras-common.
Note: This review is a blocker for https://review.openstack.org/#/c/418998/
Change-Id: I31fd13d7bcb98d73e7f16048c57c027d95faeec5
We have built up a lot of cruft over the months within our roles.
This review aims to clean up the unused sections. Now that we have
each role within a single repository, ensuring a clean house
is even more important than when they were separate.
Change-Id: Ibb34b376c516a09ba0f7fdb02580e8803497fc50
Some platforms are missing this dependency.
Add this repo so that the upstream PXE script can
complete.
Change-Id: If3d7792e1eaf8b19a53ed71a0cc86bdf3c3ba344
Ghanshyam Mann