When running a playbook with become: true, it also runs the facts
module with sudo, so ansible_user_dir will have the value of the
root user, rather than the expected home directory of the
ansible_ssh_user.
This can create issues in further tasks as ansible cache is used,
variables like ansible_user_dir can persist when next tasks run.
~~~
fatal: [undercloud]: FAILED! => {"changed": false, "error":
"[Errno 13] Permission denied:
'/root/tripleo_undercloud_install.sh'", "msg": "Unable to
output shell script /root/tripleo_undercloud_install.sh:
[Errno 13] Permission denied: '/root/tripleo_undercloud_install.sh'"}
~~~
With this patch, We are modfying making two changes:-
1) Removing not required become: true as interfaces information can be
captured as normal user.
2) Modifying the setup: module to only collect particular network
fact subsets and not even the min subset.
Change-Id: Ib167b88b03f01bb8945c53cd000b5fcac85dd320
RHEL 8.4 guest images set the locale to LANG=en_US
which results in error during the deploy.
This role ensure that the locale includes
LANG=en_US.UTF-8 after the image boots.
Related-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1935345
Change-Id: I06dd113e41d4b47e74663cc5c7bea74434cfa0fc
Removing the ens3 network-scripts file is needed when
creating a Centos 8 VM for the undercloud in baremetal
deployments.
Change-Id: I28760c662b7aaf27582c46281855d79f874f369e
Rhel/Centos8 don't have bridge-utils utility. We have to create
network bridge using nmcli tool. Added template for RHEL8/C8
- add-provisioning-interface-os-major-version-8.sh.j2 and modified
logic in playbook to call relevant template based on OS Version.
We also set the required firewalld commands to allow proper network
traffic flow from undercloud to baremetal overcloud nodes.
Change-Id: I5e56b387283fa8deff857bcf3a39a007a3d876a3
- run `pre-commit autoupdate` and fixed new issues
- adopted newer pre-commit config for ansible-lint 4.2.0+
- fixed some reported broken rules
- temporary disabled few rules, just to contain the size of of review,
planning to drop/fix them in follow-ups.
Change-Id: I807ba4e919527be56c85ec72d0f4c7148f04e994
Without these variables, the user connecting to
the virthost will default to stack- which will
not work with zuul.
Change-Id: Ieffcccabcc92ae99cf9672c9acb8c83f6657812a
Upgrades yamllint to latest version and adots use of its strict
checking.
Fix all known problems reported by yamllint so we don't have to do
that while touching these files.
Change-Id: I4bdc520d9e2aff086c4b463718bc1e053261a4f5
Story: https://tree.taiga.io/project/tripleo-ci-board/task/381
Makes those files conformant with current linting rules and avoids
linting errors when we need to toch them again.
Previous doing "pre-commit run -a" uncovered these errors, now is no
longer reporting any other errors.
Change-Id: Ie4cf229c8f11c2b55b323eac23c89483b26d3781
We need to differentiate local_working_dir from working_dir
as well as decouple the stack user from `ansible_user` var.
Both of these are causing issues as we begin to automate
deployments in more environments.
- Cleanup duplicate variables that are consumed via extras-common
- Note: extras-common depends on the common role in OOOQ
- Cleanup redundant var and superfluous quotes from overcloud-scale
role
- Cleanup redundant comments in <role>/defaults/main.yml
Closes-bug: 1654574
Change-Id: I9c7a3166ed1fc5042c11e420223134ea912b45c5
As more ansible variables are shared or reused across roles it is
important to define these variables in a role that is always
executed. In this case that role is extras-common.
Note: This review is a blocker for https://review.openstack.org/#/c/418998/
Change-Id: I31fd13d7bcb98d73e7f16048c57c027d95faeec5
We have built up a lot of cruft over the months within our roles.
This review aims to clean up the unused sections. Now that we have
each role within a single repository, ensuring a clean house
is even more important than when they were separate.
Change-Id: Ibb34b376c516a09ba0f7fdb02580e8803497fc50
Ghanshyam Mann