- Use recommended flake8 setup in pre-commit
- Removes use of hacking as pre-commit provides the lock-in
- Bumps flake8 to latest stable
- Resolves two ignored rules
Change-Id: I98f382cd2b72345748e40106624c73039e0f0f2c
Upgrades yamllint to latest version and adots use of its strict
checking.
Fix all known problems reported by yamllint so we don't have to do
that while touching these files.
Change-Id: I4bdc520d9e2aff086c4b463718bc1e053261a4f5
Story: https://tree.taiga.io/project/tripleo-ci-board/task/381
- adopts official syntax for 'when:' commands
- assures we use current linter which spots when errors
- reverts temporary linter rule disablement
- use parsable output (pep8 like) for ansible-lint
Change-Id: I6eb5719841c2f264e1efed4bf38726f71c840e36
Closes-Bug: #1797838
Currently the gating tripleo-quickstart-extras changes with
dependencies on tripleo-quickstart changes is broken.
The reason being that the checkout task deletes the tripleo-quickstart
directory while it is in use.
This review add a tripleo-quickstart-gate-repo to add the dependent
change to. After this role and quickstart run has completed,
the tripleo-quickstart-gate-repo directory can be renamed to
tripleo-quickstart before the deploy ci-script is run.
Change-Id: Ieaaf230155dcc2cdaafede63be193306eeb40499
Previously the 'flake8' command was running but didn't seem to
check out something in all cases.
- This patch decouples the 'ansible-lint' and the 'flake8' sections
into separated 'testenv'.
- And this patch fixes all the 'flake8' issues.
Change-Id: I30169598d086515121175ca322882ee00f05b913
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
We need to differentiate local_working_dir from working_dir
as well as decouple the stack user from `ansible_user` var.
Both of these are causing issues as we begin to automate
deployments in more environments.
- Cleanup duplicate variables that are consumed via extras-common
- Note: extras-common depends on the common role in OOOQ
- Cleanup redundant var and superfluous quotes from overcloud-scale
role
- Cleanup redundant comments in <role>/defaults/main.yml
Closes-bug: 1654574
Change-Id: I9c7a3166ed1fc5042c11e420223134ea912b45c5
As more ansible variables are shared or reused across roles it is
important to define these variables in a role that is always
executed. In this case that role is extras-common.
Note: This review is a blocker for https://review.openstack.org/#/c/418998/
Change-Id: I31fd13d7bcb98d73e7f16048c57c027d95faeec5
Our gates in ci.centos currently fail when using depends-on in
both the extras->quickstart and quickstart->extras directions.
This patch addresses the extras->quickstart direction by
adding a workaround for a bug in the ansible git module when
using "force"
Change-Id: I5e74377081ff1c4644da5930a496078a5b422692
Closes-Bug: 1655757
We need to use force to be able to overwrite the current repo state as
the quickstart repo is already checked out during gating.
Change-Id: Ibb0eeca6a74efccdbd5c2eba84f9e96bab187ec3
Previously the role would not check out the role changes when running
directly on the extras-gate. Also avoid fetching changes that are
already checked out by Jenkins.
Change-Id: I8b9b9a65bdac7a55fc31e43c5054c6c027dc1bf5
This role lets arbitrary tripleo-quickstart and
tripleo-quickstart-extras changes be gated together through the
"Depends-On" mechanism.
Change-Id: If5b747b1bba17dd20efa9e7caee6fbc638dbb716
Ghanshyam Mann