This redirect does not work or won't work in the future.
Note: This adds ansible-core to test-requirements.txt,
we may need to add requirements.txt and ansible collections
in ansible-collections-requirements.yml in the future.
Change-Id: Iffb41b68283f77050d8073364156cc0aca85559e
- run `pre-commit autoupdate` and fixed new issues
- adopted newer pre-commit config for ansible-lint 4.2.0+
- fixed some reported broken rules
- temporary disabled few rules, just to contain the size of of review,
planning to drop/fix them in follow-ups.
Change-Id: I807ba4e919527be56c85ec72d0f4c7148f04e994
- Fixes 206 errors and removed the skip.
- Also replaces revision with latest tag (pushed today)
Bug: https://bugs.launchpad.net/tripleo/+bug/1848512
Change-Id: I69d75ba9de8ab0e91eb45fd4f9febfdb28cdcb3a
Uses the new location of openstack-virtual-baremetal as it was
imported to openstack organization earlier today.
Change-Id: I6f6904b67052a97d8ebc5e4f3d766efb93fec7a5
This will allow ovb to develop the new dev-2.0 version as master and
continue supporting the stable.
Once master is no longer use by CI jobs, we can finally migrate the
repository via https://review.openstack.org/#/c/620613/
This setup matches the branch naming pattern used by other openstack
projects.
Change-Id: I8e9199d59d512202842e8fa11d258c1f97549325
Story: https://tree.taiga.io/project/tripleo-ci-board/task/527
Upgrades yamllint to latest version and adots use of its strict
checking.
Fix all known problems reported by yamllint so we don't have to do
that while touching these files.
Change-Id: I4bdc520d9e2aff086c4b463718bc1e053261a4f5
Story: https://tree.taiga.io/project/tripleo-ci-board/task/381
Avoids deprecation warnings like below by adopting recommended syntax.
[DEPRECATION WARNING]: Using tests as filters is deprecated. Instead of
using `result|failed` instead use `result is failed`. This feature will
be removed in version 2.9. Deprecation warnings can be disabled by
setting deprecation_warnings=False in ansible.cfg.
Change-Id: Ie0e0fbc61090e2b89971252ee60700158acf5fd4
Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
When OVB stack is not created we can't know the reason. So print
all stack info if it's failed, but don't if it's created.
Change-Id: Ic7462f58ef647d91df9f975d46c823c390a7e9ad
The ovb-manage-stack role creates OVB stacks in a similar way
to te-broker. However the patterns of naming the stacks and the
related resources were different. This review changes the naming
pattern of the ovb-manage-stack role to match that used with
te-broker to allow for a more uniform mangement of stacks
across tenants and host clouds.
Change-Id: I5c764b9eb9d49e75998d8fe39f41ac90ec00df73
ovb-manage stack recently changed parameter names and calls.
This references the merge to customize the driver for build-nodes-json.
https://github.com/cybertron/openstack-virtual-baremetal/commit/
a3786bca1604d6048562af80eca3bcad119e5065
Change-Id: Ice7c5caeec185172ae5637d2220aa0871867f12c
Closes-Bug: #1750512
The classic drivers (pxe_*, agent_* and iscsi_*) are deprecated in
Queens and will be removed in Rocky. This change uses the new
--driver argument to build-nodes-json to specify the driver to use.
Change-Id: If51505c4cd53918200b65c75915e389adaddb200
* add "cachable: true" to set_fact calls when the fact would be used by
other roles in later runs; the other fact names were checked to make
sure they are not referred to in other roles
* consolidate the formatting of the set_fact calls, using the proper
yaml structure instead of `set_fact: foo=bar`
Depends-On: I987d51cc252b7ebc3972d60497234fa676864882
Change-Id: I5dd3084ead618e357b1e7d841ea2ee794bd0569a
Currently the ovb-manage-stack role does not have any way to
setup a non-root user and no way to dump an inventory file. This
works fine when used with the rest of quickstart, because we have
other code that does these things.
However in order to reproduce tripleo-ci OVB jobs we want to
simply provision an environment like tebroker does in those jobs.
Then we just hand that environment off to the tripleo-ci job
scripts.
This change adds two optional bits (both off by default) that will
add a non-root user and dump an inventory file.
Change-Id: I9ee4402572583d6acb7cfdbde79b4b2e41a53fdf
When deploying with a containerized overcloud, the
overcloud nodes run into issues with a smaller volume
size.
Note that this review only increases the default.
Indiviual cloud users can set a smaller volume size
if required.
Change-Id: Ie312066c114602c271fa0ae8a906d5ea60514cd1
Performance with ephemeral storage on RDO Cloud for
the non-ci flavors is slow. This review enables
'boot from volume' when using non-ci flavors and
parameterizes the sizes of the volumes so that users
can modify those values in feature sets.
Change-Id: I92c8f5c190b678fcb3920fc584464b3321ab371e
For clouds where there standard flavors do not
provide large enough disks, users need the option
to boot from volume.
This review moves the version pin forward for
the Openstack Virtual Baremetal repo as the boot
from volume functionality was added in a later
version.
Change-Id: I3aa00c3dee22beaa0ce8581a6aa5b308b4fd5caa
For OVB clouds requiring port security, there is a default template
to be added when the overcloud is deployed without
network isolation. This review adds that option.
Change-Id: Id4e0ae571bf4d875a56175320e98f5f427fe6511
The Openstack Virtual Baremetal repo can change and
impact gates. This review adds the option to pin
the version of the OVB repo to a known good hash/release.
Change-Id: If3fb38fd1a57fbf994e291ce6b4fc7d7be722724
The deploy.py is updated when changes are made to the
openstack-virtual-baremetal repo. Deploying the OVB stack
with shade does not get these updates.
Upstream is using the deploy.py script so this is another
step in bringing the two workflows closer.
Change-Id: I24591b0fa0163f6f5315936a5493d615dd89adbb
This review changes the list of DNS servers to use RDO Cloud
default dns servers. Also, it single sources the DNS server for the
undercloud.
Change-Id: Ic905c19b136362d0d4db930ad47d3c84ccc18117
"set -o pipefail" is a bashism, and it is not within the POSIX
standard. It is possible that the system's default shell (/bin/sh) is
not bash, which can result in errors.
This change only corrects this in ovb-manage-stack which is most likely
to directly run on non-CentOS/Fedora/RHEL systems during the devmode OVB
execution.
Change-Id: I7a98001f125ef903766543102cd0506a243606f3
This never actually did anything because we are setting a variable
to itself. However, with ansible2.3 update this actually breaks.
Change-Id: I7ca4a29d0eeeacfe799d7640fcbecc9d88329be0
If an OVB stack does not deploy successfully, the os_stack module
fails out without returning any reason for failure.
This review ignores the error returned by os_stack and
adds a debug step that prints out the stack status so the
user knows why the deploy failed.
This review deletes the os_stack module stored in
ovb-manage-stack role as it is now included with
Ansible.
Change-Id: I7f0d4ef68d06cddf18101da20877cf49e8415069
Running quickstart with OVB needs to work with multiple host
clouds where different flavor sets are available.
This review:
* Adds variables to the flavor specifications so that they can be
overwritten by config files per host cloud environment
* Adds functionality to clean up stacks and keypairs
from the host cloud environment
* Includes cloning the Openstack Virtual Baremetal repo
within the ovb-manage-stack role
* Deletes the clouds.yaml file so it is not available,
with the tenant password exposed for longer than
necessary to create or delete the stack
* Changes the default key location to use
the user's default key on the undercloud
Change-Id: I5f0f7327a2509ef889b80a35024478b13df2c2a9
OVB workflow installs a vanilla OS image on the undercloud
and then installs repos and images.
This review adds the missing Ocata default image.
The images names will be overwritten per host cloud.
Change-Id: Ic2263d8f6babcf321d70e27d3fd3b342086087a2
Support multinic network isolation for ipv4 and ipv6 in quickstart
Also updates the roles and configs for network isolation types
used upstream in tripleo-heat-templates.
Change-Id: I5f78b908fe41a1304295fad4e0187d049b16fa80
Previously the 'flake8' command was running but didn't seem to
check out something in all cases.
- This patch decouples the 'ansible-lint' and the 'flake8' sections
into separated 'testenv'.
- And this patch fixes all the 'flake8' issues.
Change-Id: I30169598d086515121175ca322882ee00f05b913
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
novaclient 7.0.0 and above requires the 'project_name'
parameter, defined in the cloud.yml config file.
Change-Id: I15928d05ddbad28a8bdb3ef247c6aac85226a4d2
We need to differentiate local_working_dir from working_dir
as well as decouple the stack user from `ansible_user` var.
Both of these are causing issues as we begin to automate
deployments in more environments.
- Cleanup duplicate variables that are consumed via extras-common
- Note: extras-common depends on the common role in OOOQ
- Cleanup redundant var and superfluous quotes from overcloud-scale
role
- Cleanup redundant comments in <role>/defaults/main.yml
Closes-bug: 1654574
Change-Id: I9c7a3166ed1fc5042c11e420223134ea912b45c5
As more ansible variables are shared or reused across roles it is
important to define these variables in a role that is always
executed. In this case that role is extras-common.
Note: This review is a blocker for https://review.openstack.org/#/c/418998/
Change-Id: I31fd13d7bcb98d73e7f16048c57c027d95faeec5
Add vanilla RHEL image to use, by default, when deploying rhos-8.
This value can be overwritten to test rhos-8 on othe rhel versions.
Change-Id: If62afbe9273c070d8a16f99ac1b25208fe863212
The OVB role was written at first to work with ready undercloud
images. This review changes the workflow to use a vanilla
guest image for the undercloud and set up the users, repos
and overcloud images after the OVB stack is deployed.
This streamlines the OVB workflow on different environments.
Change-Id: Ic8f40b5e38fab5aee3dc84d6fb1462b3f0f61ca7
All workflows not using the undercloud ready image
are required to setup the undercloud so that it
contains the elements required for installation and
deploy.
This role should include general undercloud set up
steps but can also include environment specific
steps that are only run under certain conditions.
Steps to get and modify overcloud images are in a
separate role - to be extracted from tripleo-quickstart.
Steps to get and enable repos are in a separate role.
Change-Id: Ibc5af913378ee6b713f94a775ea8ba8b6ffbfd0c
For environments where OVB is run on an Openstack
host cloud, this role contains the functionality
to manage the heat stack.
The associated playbooks are included.
Change-Id: I6270000613b1883a4f729faee3d255fd08624c13
Ghanshyam Mann