This change removes logic for releases older than train, because these
releases are already EOLed. This covers only overcloud-* roles and
playbooks and the other items will be covered by separate changes.
Note that this change also removes the containerized_* variables
because current active releases(>=Train) no longer supports
non-containerized deployment. The containerized_overcloud_upgrade
variable is still left because the variable is still required by
the tripleo-ci-base-multinode-standard job template.
Change-Id: If29ec2c2219a28a1f79db0e552e2c622c0a7bda6
With this change we are adding capability to create custom
baremetal environment specific yaml templates:-
* network_data.yaml
* vip_data.yaml
Above files will be created using the var `network_data_details` and
`network_vip_details` defined in downstream env_setting.yml(details
about env_setting.yml in [1])
Also, Updating `overcloud-deploy` role to parameterize the location of
network_data.yaml and vip_data.yaml file, this will help override the
default location.
[1] https://opendev.org/openstack/ansible-role-collect-logs/src/branch/master/docs/static/baremetal-overcloud/environment-settings-structure.rst
Change-Id: Ibfbe2d2af8372f47f6e6a31ca821bfb314ce347f
'extra_tht_configs' parameter is used to pass extra tht
configs to overcloud deploy command(using 'extra_tht_config_args'
fact), this parameter is used to modify overcloud-deploy command,
so this patch moves the tasks associated with it to overcloud-deploy
role.
Closes-Bug: #1806328
Change-Id: I4367bd554bfc06b2416fee792b5b2a91ff8f7ff8
The change this depends on and the changes before
it remove the need to provide these parameters as
they are instead read from the subnet.
Depends-On: I5f33e06ca3f4b13cc355e02156edd9d8a1f773cd
Change-Id: I64ffeae8ead85af9aebc2e546b47d175a5a0eea7
Missing parmeter PublicVirtualFixedIPs at network env have to be there
without --tags all.
Change-Id: I44a881d22052a4f02cb3b9effcfde546d3c4253c
Closes-Bug: 1790858
Upgrades yamllint to latest version and adots use of its strict
checking.
Fix all known problems reported by yamllint so we don't have to do
that while touching these files.
Change-Id: I4bdc520d9e2aff086c4b463718bc1e053261a4f5
Story: https://tree.taiga.io/project/tripleo-ci-board/task/381
Allow undercloud installations/upgrades from custom t-h-t, similarly to
overcloud_templates_* et al.
Unify and share custom t-h-t install script for OC and UC and mixed
update/upgrade cases via new shared role tht-prep-config.
To diverge undercloud from overcloud install/update/upgrade cases, use
the following shared mappings (vars on the right correspond to UC
cases):
* tht_templates_path: undercloud_templates_path (defaults to RPM dir)
* tht_templates_repo: undercloud_templates_repo
* tht_templates_branch: undercloud_templates_branch
* tht_templates_refspec: undercloud_templates_refspec
and a 2nd group (defaults set to do nothing, but only disable the
t-h-t prepare script's code blocks under control of those):
* composable_scenario: undercloud_composable_scenario
* upgrade_composable_scenario: undercloud_upgrade_composable_scenario
* prep_post_hook_script: undercloud_prep_post_hook_script
* download_templates_rpm: download_undercloud_templates_rpm
* tht_rpm_url: undercloud_tht_rpm_url
Those in group 2 may be customized to mimic the overcloud mixed
upgrades logic for underclouds/all-in-one for future use.
And for overclouds respectively, use mappings:
* composable_scenario: remains unchanged
* upgrade_composable_scenario: remains unchanged
* prep_post_hook_script: overcloud_prep_post_hook_script
* download_templates_rpm: download_overcloud_templates_rpm
* tht_rpm_url: remains unchanged
* tht_templates_path: overcloud_templates_path
...
Related-bug: #1691467
Closes-bug: #1781227
Change-Id: I4e0dcf24b93b8e4afb8359cb5108c4b7b5ba3d55
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
Avoids deprecation warnings like below by adopting recommended syntax.
[DEPRECATION WARNING]: Using tests as filters is deprecated. Instead of
using `result|failed` instead use `result is failed`. This feature will
be removed in version 2.9. Deprecation warnings can be disabled by
setting deprecation_warnings=False in ansible.cfg.
Change-Id: Ie0e0fbc61090e2b89971252ee60700158acf5fd4
Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
After change I3bdb7d00dab5a023dd8b9c94c0f89f84357ae7a4 was introduced,
External network isn't "special" anymore in the network templates, it
gets generated as any other network. The default IP ranges and default
route come from network_data.yaml. Whenever we override one, we should
also override the other, otherwise we get non-matching
settings. E.g. my deployment with custom
`undercloud_external_network_cidr` previously resulted in:
(undercloud) [stack@undercloud ~]$ openstack subnet show external_subnet
| allocation_pools | 172.20.0.4-172.20.0.250 |
| cidr | 172.20.0.0/24 |
| gateway_ip | 10.0.0.1 |
...which didn't work out, the controllers didn't have a default route
created at all. With this patch, the default route will get
automatically pointed to 172.20.0.1.
Change-Id: I99cbb7c652e374cb5c256a706661ba7ce5038b87
Closes-Bug: #1756878
This would be useful for ffu mixed version upgrade testing. The use
case is test environment only as we want to have a mixed version with
master-uc/netwon-oc. This is not a normal environment use case and as
such we expect workaround to have this working.
The trouble of maintaining the extra workaround against having a not
too long feedback loop on the ffu upgrade seems worth the trouble.
Change-Id: Ib37b9f58e25b94fe7459b61355d5d15c3f0d36b8
Related-Bug: #1742924
Using overcloud-custom-tht-script.sh.j2 to use a git clone of tht
currently fails because the user lacks permission to modify
/usr/share.
Also, having the git clone directly into /usr/share is not very useful
for those using quickstart for tht development.
This change does a git clone of tht to the working directory and symlinks this
to /usr/share/
It also makes $HOME readable so that mistral workflows have permission
to read the local tripleo.
Change-Id: I08f259664c7810f3a1b1373285bfec1227144da9
In cases where TLS and IPv6 is enabled in the overcloud, quickstart
still passed an IPv4 value for PublicVirtualFixedIps. This fixes that.
Co-Author: Juan Antonio Osorio Robles <jaosorior@redhat.com>
Co-Author: Sagi Shnaidman <sshnaidm@redhat.com>
Change-Id: I09849c0915e7de7cf3b6de92457dfb5ff29f05ff
Introduce an upgrade_composable_scenario variable to hold the path to
the scenario file used in the upgrade command to differentiate with the
composable_scenario variable for the path of the scenario file used in
deploy command. Remove the deploy_composable_scenario variable that was
previously holding a boolean value, which can be inferred from the
content of the composable_scenario variable.
Reorder the arguments passed to the deploy command so that the default
from the docker.yaml environment doesn't overwrite the setting coming
from the scenario.
Co-Authored-By: Jiří Stránský <jistr@redhat.com>
Depends-On: Ie08bbe08530bd48a0ca58667f0704f360e0a4dd7
Change-Id: Iece70e22cd40cb119f2f9eb3c51be7bd4631fade
Related-Bug: #1714905
There are specific network-environment.yaml files for the
OVB deployments. This review removes those specific files
and adds settings so that the OVB deployments can use the
network-environment.yaml file generated from the j2 template.
Closes-Bug: #1698982
Change-Id: If4861c8fa7f847a524738f274189f6fdab4a5942
This review changes the list of DNS servers to use RDO Cloud
default dns servers. Also, it single sources the DNS server for the
undercloud.
Change-Id: Ic905c19b136362d0d4db930ad47d3c84ccc18117
* Parametrize network settings for undercloud deploy to align with
the undercloud install's undercloud.conf and nova-join's DNS
config steps.
* Move the undercloud nameservers defaults to the extras-common.
* Support extra deploy args for 'openstack undercloud deploy'.
Defaults to the heat-native mode, may be altered to containerized
heat-all agents, and other args like keep-running, if wanted.
* Support custom t-h-t templates for underclouds as well (shares
the custom t-h-t script and vars with the overcloud-prep-config)
* Template prerequisite packages installed by the
undercloud-install.sh script. These should be moved to the
tripleoclient's 'openstack undercloud deploy', eventually.
* Allow requested dev env packages to be updated by the
undercloud-install.sh script (defaults to update nothing,
which is backwards compatible). Note, this has nothing to the
prerequisite packages.
* Document missing variables for the undercloud-deploy role.
* Document hacking dev branches for customized underclouds.
Related-bug: #1691467
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
Change-Id: Id32f492369dc74428bde8c4120308279cbba53fc
Make sure the networking parameters are always defined for
deployed-server. According to the docs, the following
parameters need to be specified:
parameter_defaults:
NeutronPublicInterface:
ControlPlaneDefaultRoute:
EC2MetadataIp:
Move deployed_server defaults to the extras-common to share
it across overcloud-prep-config and overcloud-deploy roles.
Change-Id: I46efa6d6a6985c4cb77e518f827e027c13e5d0f9
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
overcloud_templates_path is defined in roles/extras-common.
Change Id216cf2091e23221cb5ae54421e3051dce1a6d18 redefines this
variable diffrently in the overcloud-prep-config role, which causes
the baremetal deploys using bonds to fail.
The review removes the variable default in overcloud-prep-config.
The role README.md is updated to refer to the extras-common default.
Change-Id: I149d47f31a5fb87d700e25d1743e11f06422e9a6
The OVB settings were kept in an internal repo.
Since settings for public clouds can be added to
the extras repo, where open settings can be used,
access to private repos should not be needed.
Note that the user will still have to source a rc
file to access resources on a tenant.
Change-Id: Id625c2a60811fafb353519ad9bf976fc7bdea826
Overwriting this broke mixed version upgrade [1], which tried to copy
t-h-t to `/home/stack//usr/share/openstack-tripleo-heat-templates`:
b1a1f010db/roles/overcloud-upgrade/tasks/pre-undercloud.yml (L39)
Setting tht_dir like this is suspicious given how tht_dir is used in
rest of the code, and this should probably be fully removed eventually,
but i'm keeping it at least for Ocata as i suspect that there might be
some jobs relying on the semi-broken behavior (which probably aren't
running a mixed version upgrade, otherwise they'd fail).
In case we are using a composable scenario which didn't exist
previously, we copy in the composable scenario from the RPM location, so
that OOOQ can find the expected environment file without needing to
backport composable scenario env files to older releases.
Change-Id: Ib3fdaa87c211545f835afb1c95e4d13debba2827
Instead of getting the tht stable/branch for the mixed
upgrade, it's more robust to download the rpm tht package
depending on the overcloud_release
Change-Id: Id216cf2091e23221cb5ae54421e3051dce1a6d18
When pipe is added to command, it should still exit with its
result code, so save it by setting pipeline option before each
command.
Close-Bug: #1676156
Change-Id: Ibbe49b4a15a5b7825447a563fe35af85fd48b3ff
Prepend a timestamp with awk to our deployment and test commands. This
allows html linking from the log servers and also better correlation
with the system logs.
We are not using the "ts" command from the moreutils package to avoid
extra dependencies. The drawback is the lack of sub-second timinig.
It is possible to disable the timestamping by setting the
timestamper_cmd to an empty string.
Also add a README file for the extras-common role.
Closes-Bug: #1673046
Change-Id: I8a2a1e4fde2ba805d3361e2e7a2337e873133ef0
add role var undercloud_network_cidr from undercloud-deploy so it can be
reused by validate-undercloud role for the sanity check script
Removed unnecessary default from other roles.
Change-Id: Id46d7a9e3fdc2028cf345564311c04af323b289f
derive a default value for overcloud_public_ip from
undercloud_external_network_cidr. This allows the deployer to set a
single value (undercloud_external_network_cidr) and have all the
defaults adjust accordingly.
Change-Id: Ideaec0e4036785e3c2f3d2859c85df827e624ca1
Support multinic network isolation for ipv4 and ipv6 in quickstart
Also updates the roles and configs for network isolation types
used upstream in tripleo-heat-templates.
Change-Id: I5f78b908fe41a1304295fad4e0187d049b16fa80
This adds the overcloud_dns_servers variable to the
overcloud-prep-config role.
Co-Authored-by: Juan Antonio Osorio Robles <jaosorior@redhat.com>
Change-Id: I563e4beecd77c772f274cc7459cb7cd02479c516
This is not being used in this role. Also, the relevant documentation
was moved from the undercloud-deploy role to the overcloud-prep-config
role.
Change-Id: If5d13648a9b631d710a0fb205a037e3f0d14fb5e
We need to differentiate local_working_dir from working_dir
as well as decouple the stack user from `ansible_user` var.
Both of these are causing issues as we begin to automate
deployments in more environments.
- Cleanup duplicate variables that are consumed via extras-common
- Note: extras-common depends on the common role in OOOQ
- Cleanup redundant var and superfluous quotes from overcloud-scale
role
- Cleanup redundant comments in <role>/defaults/main.yml
Closes-bug: 1654574
Change-Id: I9c7a3166ed1fc5042c11e420223134ea912b45c5
As more ansible variables are shared or reused across roles it is
important to define these variables in a role that is always
executed. In this case that role is extras-common.
Note: This review is a blocker for https://review.openstack.org/#/c/418998/
Change-Id: I31fd13d7bcb98d73e7f16048c57c027d95faeec5
See https://bugs.launchpad.net/heat-templates/+bug/1650625.
using the full path in the templates does not seem
workable as the temmplates path is configurable.
Moving the custom nic-configs to the t-h-t dir
so that the relative script path resolves.
Change-Id: I70867ee90313ea4a8a1c5da312ad0fed3144d58c
We have built up a lot of cruft over the months within our roles.
This review aims to clean up the unused sections. Now that we have
each role within a single repository, ensuring a clean house
is even more important than when they were separate.
Change-Id: Ibb34b376c516a09ba0f7fdb02580e8803497fc50