This change removes logic for releases older than train, because these
releases are already EOLed. This covers only overcloud-* roles and
playbooks and the other items will be covered by separate changes.
Note that this change also removes the containerized_* variables
because current active releases(>=Train) no longer supports
non-containerized deployment. The containerized_overcloud_upgrade
variable is still left because the variable is still required by
the tripleo-ci-base-multinode-standard job template.
Change-Id: If29ec2c2219a28a1f79db0e552e2c622c0a7bda6
Upgrades yamllint to latest version and adots use of its strict
checking.
Fix all known problems reported by yamllint so we don't have to do
that while touching these files.
Change-Id: I4bdc520d9e2aff086c4b463718bc1e053261a4f5
Story: https://tree.taiga.io/project/tripleo-ci-board/task/381
- adopts official syntax for 'when:' commands
- assures we use current linter which spots when errors
- reverts temporary linter rule disablement
- use parsable output (pep8 like) for ansible-lint
Change-Id: I6eb5719841c2f264e1efed4bf38726f71c840e36
Closes-Bug: #1797838
* add "cachable: true" to set_fact calls when the fact would be used by
other roles in later runs; the other fact names were checked to make
sure they are not referred to in other roles
* consolidate the formatting of the set_fact calls, using the proper
yaml structure instead of `set_fact: foo=bar`
Depends-On: I987d51cc252b7ebc3972d60497234fa676864882
Change-Id: I5dd3084ead618e357b1e7d841ea2ee794bd0569a
When pipe is added to command, it should still exit with its
result code, so save it by setting pipeline option before each
command.
Close-Bug: #1676156
Change-Id: Ibbe49b4a15a5b7825447a563fe35af85fd48b3ff
Prepend a timestamp with awk to our deployment and test commands. This
allows html linking from the log servers and also better correlation
with the system logs.
We are not using the "ts" command from the moreutils package to avoid
extra dependencies. The drawback is the lack of sub-second timinig.
It is possible to disable the timestamping by setting the
timestamper_cmd to an empty string.
Also add a README file for the extras-common role.
Closes-Bug: #1673046
Change-Id: I8a2a1e4fde2ba805d3361e2e7a2337e873133ef0
On a 3 controllers node setup, the neutronl3ha.yml file is always set due to
that regexp which is always true and always returning 1 as number of
controllers.
Closes-Bug: #1643866
Main Author: Athlan-Guyot sofer <sathlang@redhat.com>
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
Change-Id: Icfe4fdc5762cc264f86cd2f513b5f5b53ad7cf75
Lacking quotes, only the first word of the failure message
propogates, '"msg": "Overcloud"'.
Casting strings to ints to ensure they are evaluated
as expected. These conditionals broke, probably a regeression
related to recent move to Ansible 2.2.X
Change-Id: I3e225efd6792485a74a17f973f92d4cc87ddfa99
We need to differentiate local_working_dir from working_dir
as well as decouple the stack user from `ansible_user` var.
Both of these are causing issues as we begin to automate
deployments in more environments.
- Cleanup duplicate variables that are consumed via extras-common
- Note: extras-common depends on the common role in OOOQ
- Cleanup redundant var and superfluous quotes from overcloud-scale
role
- Cleanup redundant comments in <role>/defaults/main.yml
Closes-bug: 1654574
Change-Id: I9c7a3166ed1fc5042c11e420223134ea912b45c5
As more ansible variables are shared or reused across roles it is
important to define these variables in a role that is always
executed. In this case that role is extras-common.
Note: This review is a blocker for https://review.openstack.org/#/c/418998/
Change-Id: I31fd13d7bcb98d73e7f16048c57c027d95faeec5
We have built up a lot of cruft over the months within our roles.
This review aims to clean up the unused sections. Now that we have
each role within a single repository, ensuring a clean house
is even more important than when they were separate.
Change-Id: Ibb34b376c516a09ba0f7fdb02580e8803497fc50
https://review.openstack.org/#/c/397312/ has removed some options in
tripleoclient.
Specifically, --neutron-network-type and --neutron-tunnel-types
are being used in tripleo-quickstart .This patch removes them
from extra_args and scale_extra_args.
This parameters are being passed via environment files or using vxlan
by default so i think it doesn't need any other adjustment.
Change-Id: Icb36a45797bdb5e217ce9f33fa67e6697590b23c
- Remove scale_ceph.yml config, it isn't tested/verified and
shouldn't be supported
- Clean up the scale_compute.yml config and remove unused or
redundant (overriding default with default) variables
- Ensure the conditional tasks cast strings to bools to avoid
false positives
Change-Id: Ib80e5e492b3add4a7943bdeb24de0957b9b7bcb3
Ghanshyam Mann