- run `pre-commit autoupdate` and fixed new issues
- adopted newer pre-commit config for ansible-lint 4.2.0+
- fixed some reported broken rules
- temporary disabled few rules, just to contain the size of of review,
planning to drop/fix them in follow-ups.
Change-Id: I807ba4e919527be56c85ec72d0f4c7148f04e994
- Fixes 206 errors and removed the skip.
- Also replaces revision with latest tag (pushed today)
Bug: https://bugs.launchpad.net/tripleo/+bug/1848512
Change-Id: I69d75ba9de8ab0e91eb45fd4f9febfdb28cdcb3a
Upgrades yamllint to latest version and adots use of its strict
checking.
Fix all known problems reported by yamllint so we don't have to do
that while touching these files.
Change-Id: I4bdc520d9e2aff086c4b463718bc1e053261a4f5
Story: https://tree.taiga.io/project/tripleo-ci-board/task/381
Makes those files conformant with current linting rules and avoids
linting errors when we need to toch them again.
Previous doing "pre-commit run -a" uncovered these errors, now is no
longer reporting any other errors.
Change-Id: Ie4cf229c8f11c2b55b323eac23c89483b26d3781
We are moving away from hardcoding the stack user and opting to
replace it with `undercloud_user` and `non_root_user` as appropriate
to increase flexibility of OOOQ and OOOQ-Extras.
Change-Id: I7ea43a3fabab2c69fd4f3b5550ea5e4627443406
- According to the ansible-lint documentation, we can pass a role directory as
an argument. But due to https://github.com/willthames/ansible-lint/issues/210,
the role directory has to contain a trailing slash!
- This patch fixes the following ansible-lint rules:
* ANSIBLE0004: Git checkouts must contain explicit version
* ANSIBLE0008: Deprecated sudo
* ANSIBLE0011: All tasks should be named
* ANSIBLE0014: Environment variables don't work as part of command
* ANSIBLE0015: Using bare variables is deprecated
- Temporarily skipping the following ansible-lint rules (Fixes will be part of
others patches):
* ANSIBLE0007: Using command rather than an argument to e.g file
We have a lot of 'rm' command and we should use file module instead
* ANSIBLE0012: Commands should not change things if nothing needs doing
* ANSIBLE0013: Use Shell only when shell functionality is required
Change-Id: I3d5591ea9fd1691e8115d7093db87781a08a6082
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
We need to differentiate local_working_dir from working_dir
as well as decouple the stack user from `ansible_user` var.
Both of these are causing issues as we begin to automate
deployments in more environments.
- Cleanup duplicate variables that are consumed via extras-common
- Note: extras-common depends on the common role in OOOQ
- Cleanup redundant var and superfluous quotes from overcloud-scale
role
- Cleanup redundant comments in <role>/defaults/main.yml
Closes-bug: 1654574
Change-Id: I9c7a3166ed1fc5042c11e420223134ea912b45c5
As more ansible variables are shared or reused across roles it is
important to define these variables in a role that is always
executed. In this case that role is extras-common.
Note: This review is a blocker for https://review.openstack.org/#/c/418998/
Change-Id: I31fd13d7bcb98d73e7f16048c57c027d95faeec5
We have built up a lot of cruft over the months within our roles.
This review aims to clean up the unused sections. Now that we have
each role within a single repository, ensuring a clean house
is even more important than when they were separate.
Change-Id: Ibb34b376c516a09ba0f7fdb02580e8803497fc50
- This patch avoids deprecations warning about using sudo/sudo_user
instead of become/become_user.
Change-Id: I1f4909cd25ffbe3d53dd55118fe1af0052cf6b9a
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
Ghanshyam Mann