openstack
/
tripleo-validations
Code Issues Proposed changes

Fix the introspection interface look up 

The ironic-inspection firewall specific configuration options were moved from
the ``firewall`` to the ``iptables`` group. All options in the ``firewall``
group are now deprecated.

Moreover, this patch adds `changed_when: False` to commands that should not
change things if nothing needs doing [ANSIBLE0012].

Change-Id: I609a3e44a6b18487601b78cfbc12bbaa742ad78e
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
This commit is contained in:
Gael Chamoulaud 2018-11-14 12:00:43 +01:00
parent 1ff8160f17
commit 2d967a0dec
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
validations/dhcp-introspection.yaml
View File

@ -14,10 +14,11 @@
- pre-introspection
tasks:
- name: Look up the introspection interface
ini: path=/var/lib/config-data/ironic_inspector/etc/ironic-inspector/inspector.conf section=firewall key=dnsmasq_interface
ini: path=/var/lib/config-data/ironic_inspector/etc/ironic-inspector/inspector.conf section=iptables key=dnsmasq_interface
register: interface
- name: Look up the introspection interface from the deprecated option
ini: path=/var/lib/config-data/ironic_inspector/etc/ironic-inspector/inspector.conf section=discoverd key=dnsmasq_interface
ini: path=/var/lib/config-data/ironic_inspector/etc/ironic-inspector/inspector.conf section=firewall key=dnsmasq_interface
register: interface_deprecated
- name: Look for rogue DHCP servers
script: files/rogue_dhcp.py {{ interface.value or interface_deprecated.value or 'br-ctlplane' }}
changed_when: False