All the validations directory contents have been migrated into Ansible
Roles then this directory could be now deleted.
Change-Id: I41328b2f1e6d8e8d695c0794557567f07c509874
Implements: blueprint validation-framework
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
The gate is now using the last ansible-lint version (4.0.1) which have new
ids/tags and new rules. The old tags (ANSIBLE*) should remains backwardly
compatible but this patch is using the new ones.
This patch fixes all the lint issues.
Change-Id: Ic151f3e969b8e3729394fd477bb8341d1cb75fd7
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
When no overcloud is deployed, the openstack-endpoint.yaml validations
fail. This patch re-orders couple of tasks and runs the failing task for
unavailable endpoints only when an overcloud exists.
Change-Id: I174b5a239a7c1ab7b93323654a417db8f087bc27
Story: #2002061
Inventory variable overcloud_keystone_url gets its
value from stack's output 'KeystoneURL'
which might include the keystone version.
We need to get rid off the version, otherwise
undercloud validations fail at the time of
checking the Keystone endpoint [0].
[0] - 545e4924e3/validations/openstack-endpoints.yaml (L28)
Co-Authored-By: Jose Luis Franco <jfrancoa@redhat.com>
Story: #2001897
Change-Id: I3e900afd840a4a0504a573a1eabe80911f8f7881
The overcloud services validation uses the Keystone API version 2 to generate a
token. This doesn't work anymore since Queens.
This patch changes the validation to use API version 3 instead.
Closes-Bug: #1757187
Change-Id: I4e080521a334fca4999b9bc6e3e1bcacd24c476b
We should check that the Horizon endpoint is
configured correctly before running the validation.
Change-Id: Ib0b1c7e68711222e0f8326a268fde7b100a92e87
Related-Bug: 1742947
This patch adds tools/ansible-lint.sh script to lint validations playbooks.
Moreover, it adds `changed_when: False` to commands that should not change
things if nothing needs doing [ANSIBLE0012].
Change-Id: I4fb432bfbd2b73740c29011d08a09058b6c45348
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
This adds the pre-upgrade and pre-update groups to the existing
overcloud endpoint validation which checks horizon and keystone
Change-Id: Iebccce31a7a12f72f22305a977085d1a1d886b81
We were reading overcloudrc for the openstack-endpoints validation.
However, the name of tha file may differ if the deployment plan is
called something else than "overcloud" and more importantly, the GUI
deployments don't create the file on the undercloud at all.
This updates the Ansible inventory to read the admin password and
keystone url for the specified plan if available and the validation to
use those values instead of relying on overcloudrc.
Change-Id: I9ff26016c43888267968ef2588f686f7de95bda3
Closes-Bug: #1643808
Move TODO text so it will not appear in description and GUI.
Revise description to better describe behavior of validation.
Change-Id: I580e26dfb74c299340e1cba6a4c1aca10edf180a
Closes-bug: #1643541
Gael Chamoulaud