openstack
/
trove-integration
Code Issues Proposed changes

Change assertTrue(isinstance()) by optimal assert 

Some of tests use different method of
assertTrue(isinstance(A, B)) or assertEqual(type(A), B).
The correct way is to use assertIsInstance(A, B) provided
by testtools

Change-Id: Ib303f68d83db760dae045f0416f257c4622fa777
This commit is contained in:
gecong1973 2016-09-30 16:13:59 +08:00
parent 8d48fb0cd9
commit 9f92ca853f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/integration/tests/volumes/driver.py
View File

@ -110,7 +110,7 @@ class VolumeTest(unittest.TestCase):
self.storyFail = storyFail
def assert_volume_as_expected(self, volume):
self.assertTrue(isinstance(volume["id"], Number))
self.assertIsInstance(volume["id"], Number)
self.assertEqual(self.story.volume_name, volume["display_name"])
self.assertEqual(self.story.volume_desc, volume["display_description"])
self.assertEqual(1, volume["size"])