Third in a series of commits to add Codespell to Ironic Repos. This commit adds the Tox Target to CI
A future commit could potentially add a git-blame-ignore-revs file if their are lots of spelling mistakes that could clutter git blame.
Change-Id: I21d137007c5432f3e4970a912b528cbc2748b7ad
Second in a series of commits to add Codespell to Ironic Repos. This one adds the command that was used to fix the spelling errors.
Future Commits will add CI support and potentially a git-blame-ignore-revs file if their are lots of spelling mistakes that could clutter git blame.
Change-Id: I90886dbb7ad7adf5520f8cc436012fa63c89ca78
Without setting language, sphinx throws a warning. We count warnings as
errors. This is causing CI jobs to fail in virtualbmc.
Change-Id: Ifab813e7bdeca1727720b4eb8ae62f5d8b8a4a68
This is the first in a series of commits to add support for codespell. This is continuning the process completed in ironic-python-agent.
Future Commits will add a Tox Target, CI support and potentially a git-blame-ignore-revs file if their are lots of spelling mistakes that could clutter git blame.
Change-Id: If39cba190cd4cde60ce13ae2fcde77b69776d4d2
A review of the helper code which wraps libvirtmod's compiled
module which implements the libvirt wrapper for Python, which
we refer to and call as libvirt or python-libvirt, reveals that
it appears possible for AttributeError and KeyError to be raised
up to the intermediate library level. While everything else refers
to libvirtError, it still seems possible, albeit remote, that
the generated code and interactions may still raise exceptions
besides libvirtError which previously would result in unexpected
behavior.
What we sometimes see on the ipmitool side is a generic
"Error: Unable to establish IPMI v2 / RMCP+ session" error which
is generated in many cases, including when no response is received.
So, since libvirtError is based on an Exception class, changes
exception handling to just catch and log based upon Exception.
Change-Id: I8159f5d1de2acb0678e7c85306413fab6999e615
It is no longer supported by jammy and lead us to the following errors with the announce-release job.
```
No package matching 'python-dev' is available
```
Change-Id: I295bf25056f66c29649620ce8420382c4a151c1d
VirtualBMC is not a tool designed for production use; ensure this is
explicitly documented in the readme.
Story #2010382
Task #46661
Change-Id: I581b96b93d9b24f650ac0c6280d074708ec69ef4
When setting parameters revolving around boot
mode, options, firmware, it is necessary to
extract and edit the XML document.
Some details, however, are not automatically
extracted and libvirt must be told to provide
secure information. This change prevents us
from accidently loosing such configuration
parameters
Story: 2010382
Task: 46651
Change-Id: I0da2f37c5b630d2a180f59b74f23c027ee56e17b
Maintaining support for older not supported in Zed Python versions
would take too much effort with a lot of libraries dropping
compatibility with 3.6 and 3.7
Change-Id: I58a810d8cf4247153623c247de71f774928653aa
Also leave py3.6 test as it's still trendy
Remove l-c job definition from tox.ini, it was not used anyway and
we're removing l-c jobs everywhere
Fix tempest test
Change-Id: Ibdb5be75cf9e1c7a2ce26c05ee1e5e5d85d20482
We have updated the yoga testing runtime to keep the
py36 testing.
- https://review.opendev.org/c/openstack/governance/+/820195
Unit tests job template is also updated to keep python
3.6 as a voting job. So with the py3.6 and py3.9 testing as voting
job template, we are keeping python 3.6, 3.7, 3.8, and 3.9 as
tested versions in the Yoga cycle.
- https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/820286
This commit re-add the python 3.6/3.7 versions in setup.cfg classifier.
Change-Id: I0b1fd265bfed80b76e5eced456d80b65310b4368
UPPER_CONSTRAINTS_FILE is old name and deprecated
This allows to use upper-constraints file as more
readable way instead of UPPER_CONSTRAINTS_FILE=<lower-constraints file>.
Change-Id: Id0b52f70e02b08d4983a218af7c2e34c38ec3c7d
Setuptools v54.1.0 introduces a warning that the use of dash-separated
options in 'setup.cfg' will not be supported in a future version [1].
Get ahead of the issue by replacing the dashes with underscores. Without
this, we see 'UserWarning' messages like the following on new enough
versions of setuptools:
UserWarning: Usage of dash-separated 'description-file' will not be
supported in future versions. Please use the underscore name
'description_file' instead
[1] https://github.com/pypa/setuptools/commit/a2e9ae4cb
Change-Id: I2781f250f8db9907987b75b0c66ad8bfb041ccee
We need to specify doc requirements in doc/requirements.txt
to avoid problems with the pip resolver for the release team.
Removed specific doc requirements from test-requirements.txt
Change-Id: Ib2570e01bef426c0e5ecfd59249d08ea00749b28
As discussed during the upstream ironic community meeting on
Monday Dec 14 2020, the lower-constraints job is being removed.
Change-Id: I79af2ef5dd144d7b0bd3e3036fbf0e671701ef6a
Remove pep8 dependencies from test-requirements, they're not
needed there and are hard to constraint properly.
Change lower-constraints to make pip resolver happy.
Change-Id: I85f2e368f6834888e3c82d365c2ecbcebfabd8e7
Also re-oreder jobs and add common openstack jobs for cover and
lower-constraints.
And disable dstat to prevent failures due to dstat bug in focal.
Change-Id: Ia219fdaac13c21d9fce08e69b45945d4b5e37a89
Versions of hacking from 3.1.0 until 4.0.0 NOT included are supposed
to require a safe version of flake8, so besides normale issues related
to minor version upgrades, we can safely use those versions.
Also forcing pycodestyle versions to be compatible with flake8 installed
by hacking.
Change-Id: I98bc624f9eb8f8153885e52366e34ac7a0e047fa
The current code logs the milliseconds twice:
2020-09-21 00:24:21,706.706 3484 DEBUG VirtualBMC [-] Get power...
The documentation for the logging module in py3 is quite
unambiguous about %(asctime) providing milliseconds.
The documentation in py2 is unclear on what is supposed
to offer, but in practice it works exactly as py3.
Change-Id: Ibb050c58d5fb949316700d7d2db4c77bd62f5e25
As recommended, since version 3.2.0 tox switches pip invocations
to use the module -m pip instead of direct invocation.
We set min version to 3.2.1 [1] to also fix the behavior of
--parallel--safe-build
[1] https://tox.readthedocs.io/en/latest/changelog.html#v3-2-1-2018-08-10
Change-Id: I4003a8bebc7737250d0c318426e885d0888df57d
The mock third party library was needed for mock support in py2
runtimes. Since we now only support py36 and later, we don't need it
in lower-constraints.
These changes will help us to drop `mock` from openstack/requirements
Change-Id: Iccbcd6deddc1d246d214a2c52086a0cc8d911882
Switch to openstackdocstheme 2.2.1 and reno 3.1.0 versions. Using
these versions will allow especially:
* Linking from HTML to PDF document
* Allow parallel building of documents
* Fix some rendering problems
Update Sphinx version as well.
Set openstackdocs_pdf_link to link to PDF file. Note that
the link to the published document only works on docs.openstack.org
where the PDF file is placed in the top-level html directory. The
site-preview places the PDF in a pdf directory.
Change pygments_style to 'native' since old theme version always used
'native' and the theme now respects the setting and using 'sphinx' can
lead to some strange rendering.
openstackdocstheme renames some variables, so follow the renames
before the next release removes them. A couple of variables are also
not needed anymore, remove them.
See also
http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014971.html
Change-Id: I20ea481c1dd9651258b8ae13da9b1e1ec710482b
libvirt-python needs to be compiled also during doc building, add
"compile" target to bindep which is used for install and doc jobs.
This fixes the doc CI jobs.
Change-Id: I8ec597485db067a919d2455a81b7fe79b83153f7
Full py3 compatible version.
Add all Python3 modules to stdlib list.
Also includes fix to an enum34 dependency bug.
Change-Id: I26f38e18ce5c1c61aadbc1590a79c97e7b3c4ab4