openstack
/
vitrage-tempest-plugin
Code Issues Proposed changes

small refactoring on graph creation and checks 

* copy is redundant remove it
* use enumarate instead of index
* use for each instead for on range

Change-Id: I9cac993067e13b635733008d4ba866271b33cf29
This commit is contained in:
Eyal 2019-03-05 16:07:12 +02:00
parent d424a7cb1c
commit e5a4cc630f
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
vitrage_tempest_plugin/tests/base.py
View File

@ -288,7 +288,7 @@ class BaseVitrageTempest(test.BaseTestCase):
graph = nx.MultiDiGraph() if not graph else graph
if 'children' in api_graph:
children = api_graph.copy()['children']
children = api_graph['children']
del api_graph['children']
vitrage_id = api_graph[VProps.VITRAGE_ID]
@ -306,13 +306,13 @@ class BaseVitrageTempest(test.BaseTestCase):
graph = nx.MultiDiGraph()
nodes = api_graph['nodes']
for i in range(len(nodes)):
graph.add_node(str(i), **nodes[i])
for i, node in enumerate(nodes):
graph.add_node(str(i), **node)
edges = api_graph['links']
for i in range(len(edges)):
graph.add_edge(str(edges[i]['source']),
str(edges[i]['target']),
for edge in edges:
graph.add_edge(str(edge['source']),
str(edge['target']),
EdgeProperties.RELATIONSHIP_TYPE)
return graph