Commit Graph

13030 Commits

Author SHA1 Message Date
Dr. Jens Harbott 9daf23cc01 Merge "Fix zuul config errors" into stable/stein 2023-08-12 20:20:33 +00:00
Dr. Jens Harbott 404ff31334 Fix zuul config errors
Drop required-projects that no longer exist:

- openstack/neutron-lbaas
- x/tap-as-a-service

Change-Id: I50176fa303e7099f848cca2c6e363e41dd1626fa
2023-08-12 22:13:09 +02:00
Clark Boylan b7239d4ac4 Fix Zuul shared queue config.
The current queue config is deprecated and will be removed in the next
major zuul release. Update to ensure windmill uses correct config.

More info can be found on the zuul mailing list:
  https://lists.zuul-ci.org/pipermail/zuul-discuss/2022-May/001801.html

Change-Id: I6d059710911fadc80b86bf2ebbad9527c372c5fa
(cherry picked from commit 715cb5fc11)
2023-08-12 19:44:38 +00:00
Kobi Samoray 55c041dc96 Use stein-eol branch for Octavia
Correct issue from previous patch

Change-Id: I36ba039798c778dcc99b827cc1d9cbab12805929
2021-06-28 14:13:22 +03:00
Kobi Samoray cfe4faa787 Use stein-eol tag for Octavia in stable/stein
As Octavia stable/stein has been EOLed.
Also few fixes to UTs, requirements and testing to pass the gate

Change-Id: Icc3285aef1315f1e2fe0898da3f5a8f9b6b19f46
2021-06-22 13:05:25 +03:00
asarfaty 83d4a3bc4d NSX|P Check lb service on listener create/update
Also fallback to the old behavior of service id the same as
the lb id.

Change-Id: I7ab34b32fd59f8d12693b2826f4019843360fe54
2020-11-06 07:40:21 +00:00
Ghanshyam Mann c4c5aec8d3 Use the networking-l2gw project new location
networking-l2gw and networking-l2gw-tempest-plugin are
imported to new location now and supposed to be retired from
openstack/namespace[1].

-https://review.opendev.org/#/c/744110/

Change-Id: I902ea79cdd3a8e56540ab44a7bd2f986f5d18bca
2020-09-24 07:20:28 +02:00
asarfaty 8e0254b711 Skip new unsupported unittests
Commit I054296c790b697198550acbeae29546758b422c2 added IPv6 related
test which is not supported by the v/v3 plugins

Change-Id: Ia30bd8aca47397c2ea2fb3c55f6a559ef2f22a91
2020-08-05 10:03:24 +00:00
Zuul dcc5e5abb3 Merge "NSXV: Support session persistence with Octavia" into stable/stein 2020-07-28 08:59:47 +00:00
Adit Sarfaty b54c1293d7 Revert "Octavia driver: agent implementation"
This reverts commit bac9c058e5.

Change-Id: Id806f56824d0cb1112ce3e4f28880629c0d72c2e
2020-07-12 05:42:58 +00:00
Kobi Samoray bac9c058e5 Octavia driver: agent implementation
The driver is loaded, then terminated whenever a request is issued.
This behavior causes termination of the Octavia listener which is
responsible to the processing of the driver status updates and
statistics processing.
The following change implements an agent which will execute the
listener.

Change-Id: I566aaa65df4ba7455577a539aa9eebb6cc36a099
(cherry picked from commit 24e93461d0)
2020-07-09 08:47:03 +02:00
Kobi Samoray a4c248f456 NSXV: Support session persistence with Octavia
Octavia breaks when listener is created before the pool, and session
persistence is specified.

Change-Id: I116871ce6fec12f099248e88ff560362f89c3d23
2020-07-08 08:13:52 +00:00
Zuul 7740d7eba7 Merge "NSXP: Update Octavia with object statuses" into stable/stein 2020-07-07 07:31:34 +00:00
asarfaty 7e2b4f4996 NSX|P: Issue proper error in external network creation
Change-Id: If9633b4e74d8a354ff93d2a75968d41cee0f8ad3
2020-07-06 04:03:32 +00:00
Kobi Samoray 78beece78e NSXP: Update Octavia with object statuses
Send object updates about statuses: loadbalancers, listeners, pools, and members.

Change-Id: Ifd893818c2ddb1325f3bed9f618b72754ed0689f
2020-07-02 15:37:05 +03:00
asarfaty 13f7c3b795 NSX|P: Fix listener create & update
Use tags to find the lb service id from the loadbalancer id

Change-Id: Ic6a756aaa98c27362d34f3eff488864a4eedd036
(cherry picked from commit 4d5cbfd7a1)
2020-07-02 09:32:52 +00:00
Zuul cf10c49b56 Merge "NSX|P: Support update of listener with certificate" into stable/stein 2020-06-30 21:23:07 +00:00
asarfaty e9ca40d884 NSX|P: Fix handling LB member on external subnet
If the LB has an external vip, the member must have a local subnet-id
connected to a router with an uplink,
or the member must have an IP which is a FIP address

In addition, remove one leftover log, and remove a lock on router
id when it is None

Change-Id: Iefb492e43b5cc47a84ce82e4dfbcb0d1e5e6bffe
2020-06-30 12:24:04 +00:00
asarfaty df021b4b0a NSX|P: Support update of listener with certificate
Change-Id: Ia32a61eae8456a6c8f0f475e9bcc58da88af29e1
2020-06-30 06:02:42 +00:00
asarfaty ac4680e609 Fix default args in nsxadmin
Commit I0c75f0a616d8016a840611edab1e3b3edb53c4ad removed
the selected -r / -o by mistake

Change-Id: I2b017e3642f07908086a46baf9fe1c6cc8544fb1
2020-06-21 09:11:43 +00:00
Zuul edccd37a5f Merge "NSX|V3+P: Fix listener creation when LB has no name" into stable/stein 2020-06-21 04:47:04 +00:00
asarfaty 063c976fd6 NSX|V3+P: Fix listener creation when LB has no name
Change-Id: Idaa39e140a724d01892e6c29a914d47ec4f5b18a
2020-06-20 04:22:47 +00:00
asarfaty 645e66121a Support custom config files in admin utilities
The admin utilities usually run with the default config files:
/etc/neutron/neutron.conf and /etc/neutron/plugins/vmware/nsx.ini

In order to run it with custom files you can use:
nsxadmin --config-file <neutron conf path> --config-file <nsx conf path>

Change-Id: I0c75f0a616d8016a840611edab1e3b3edb53c4ad
2020-06-19 08:39:48 +00:00
Zuul eb27d79bd8 Merge "NSXT LB: handle listener deletion failures" into stable/stein 2020-06-04 06:35:32 +00:00
Kobi Samoray b376ad6ffd NSXV: allow DHCP reply on DHCP edges
Work around DHCP edge's behavior where firewall is blocking DHCP unicast
replies.

Change-Id: I2ed3de8d665166fed3bc42da56d2a180b070ca0d
2020-06-02 15:59:01 +00:00
Kobi Samoray fb77ab9659 NSXT LB: handle listener deletion failures
When deleting a listener which doesn't exist in the backend, the call
shouldn't fail but delete from OpenStack DB and issue an error to the
log file.

Change-Id: I1ee816d82986a651ea2889b1a4a74889e8724dbb
2020-06-02 09:55:00 +03:00
asarfaty c0da5a9c44 Fix admin utils quota issue
Commit I7e68c9d0e40e03c0e3e708e04c996fdceed56df4 fixed the sg rule quota
issue in the admin utilities tests, instead of in their mock plugins

Change-Id: I95b6411e960c62def3bbc6a9d7b6cdd92fc4aa92
(cherry picked from commit fb2c27bebf)
2020-05-29 17:22:57 +00:00
asarfaty 25a8919587 NSX|P: support multiple loadbalancers on a router
The loadbalancers using the router LB service will be marked on
a new tag on the NSX service.

Also adding an admin utility to update existing Lb services with the tag.

Change-Id: I6c38b45e4d683681a6915fd07ca296264c7d2495
2020-05-18 08:01:46 +00:00
asarfaty 61fe375766 Fix pep8 issues
Change-Id: Ic22f30bb19ed23bafbdd2fbbe514d9286b418cab
2020-05-12 07:24:13 +00:00
Zuul 2d2546ed9e Merge "Handle Octavia certificates properly" into stable/stein 2020-05-09 17:23:03 +00:00
asarfaty 19c74cc3d1 NSX|P: Make sure service router exists for vlan interface
When adding a vlan interface to a tier1 router, the edge cluster
must also be set, so that a service router will exist.
When removing a vlan interface, check if the service router is still
needed.

Change-Id: I73b3b02b876eea3d3247487fd12b542b637b6e0b
2020-05-07 03:34:56 +00:00
Kobi Samoray 62863daead Handle Octavia certificates properly
Octavia certificate were mishandled as LBaaSv2 certificate objects

Change-Id: Ib8ce4f735ca6fc74f6c11d91eae508fd86397dbf
2020-05-07 03:34:45 +00:00
asarfaty 136a4005ae Fix broken unit tests
Commit I0a9b91b09d6260ff96fdba2f0a455de53bbc1f00 broke the unit tests
This patch adds the security rules quota mock were needed.

Change-Id: I7e68c9d0e40e03c0e3e708e04c996fdceed56df4
(cherry picked from commit 8fa0e7daac)
2020-05-06 18:38:34 +02:00
asarfaty f9ed36ec04 NSX|P: Fix router interface removal
With Policy DHCP, subnets should not allways be removed from the
segment.

Change-Id: I80344e506e225b13838bc06999dbc72930414c68
(cherry picked from commit e567073dfb)
2020-05-05 07:02:01 +00:00
Zuul f2af846e5a Merge "NSX|P: Do not search for FW resources when not needed" into stable/stein 2020-04-23 15:17:31 +00:00
asarfaty f73633740f NSX|P: Do not search for FW resources when not needed
cleanup_router_fw_resources was called twice when updating the
GW firewall and no FWaaS ports were found.
This method should be called only once inside delete_router_gateway_policy
if a policy exists.

Change-Id: Ib947720daaff2b0112d580e1353c9bae0f3dce06
2020-04-23 08:30:34 +00:00
asarfaty 504323b863 NSX|P: Fix ipv6 subnet gateway IP
Since NSX 3.0 ipv6 subnet GW cannot have a zero suffix.
This fix performs the check & update for MP DHCP subnets,
in addition to the Policy DHCP subnets that already had this check.

(Cherry picked from commit Ie74e96eb36df16f5e98588d92067f94168f3f5a6)

Change-Id: Ia1a47d8196b5336bb5510dccffd4e8c3821c8fd7
2020-04-22 06:04:59 +02:00
asarfaty 90f2171f97 NSX|P: Fix port security update for network
Change-Id: Id576ea0bc2e9c3dff1f1ba683ba26f1e30dded44
2020-04-10 15:58:07 +00:00
asarfaty dd0e6123ae NSX|V: Fix SG icmp rules creation
When updating a section, exising icmp echo request/reply rules cannot have
icmp code field.
In addition the icmpcode 0 should also be removed from the rule creation

Change-Id: I380d5e45235fd0033bba924b42c6b83104f17241
2020-03-31 06:26:52 +00:00
asarfaty 7d91aaf601 NSX|P: Fix trunk driver detach calls
Use vif_id in case of compute ports to keep their VM link

Change-Id: I1150dc5336032c006e21ee91833f8949480abd4a
2020-03-25 04:49:53 +00:00
Kobi Samoray 79004ea526 NSXv: use correct DFW config for LBaaS rules
NSXv 6.4.x is more sensitive to the definition of DFW rules and doesn't
support comma separated IP addresses.
Instead it requires individual source/destination constructs per each IP
or CIDR.
The patch addresses this problem within LBaaS driver.

Change-Id: I117665e9fdcc78812ae8188ae514855333b8570d
2020-03-09 09:31:25 +00:00
asarfaty 0638eb2c8d NSX|P: Add validation on number of segment subnets
The NSX does not support multiple segment subnets of the same ip version
This means that the plugin should prevent creation of a DHCP subnet
and another overlay router-interface subnet on the same network

Change-Id: I2898efe1ccbc7d06e6baeb2b30f76e3190801fa8
2020-03-04 11:10:09 +02:00
asarfaty 7a904e2efe NSX|P Fix get_subnets for router interfaces
The parameter name in kwargs was wrong, leading to reading
all the subnets again.

Change-Id: Ied5a18f9737e48ed805d2c24673c8f1d9df0958e
2020-03-04 09:05:41 +02:00
asarfaty b224e89cf1 NSX|V3: Fix broken unit tests
Commit Ibad52cca60131e970447536fd22c4f4440c66d34 groke the unit tests
by removing a mock that is needed by the plugin tests.
Adding back the mock in the plugin tests context.

Change-Id: I85c191c3c15aedc0740cb3c23990c0ea0b646fe7
2020-03-01 12:12:41 +00:00
asarfaty b360f99626 NSX|P: Fix segments update upon dhcp/router interfaces changes
Use update instead of create_or_overwrite when updating segment
to keep all its original attributes.
In addition if router interface add/remove to keep all dhcp subnets data

Change-Id: I04ee3242fb22886838f9c1c7afa42ab4a74927d1
2020-02-25 05:37:23 +00:00
Zuul 4b9be71281 Merge "NSX|V3+P: Fix loadbalancer delete to support error cases" into stable/stein 2020-02-23 13:51:15 +00:00
asarfaty 44c6831e76 NSX|V3+P: Fix loadbalancer delete to support error cases
If the loadbalancer is in error, the subnet / port might not exist
so the service should just log this error and continue

Change-Id: If8dd1cec562a6252ead7115287c219a3f4701f5e
2020-02-23 11:01:57 +02:00
asarfaty a4bec193c5 NSX|P: Fix LB listener default pool validation
When checking that the pool is not used by anotehr listener,
skip the current listener.

Change-Id: I21d35abd35bdfc83d7535830dfab63b1b9285467
(cherry picked from commit 93d3a9ca83)
2020-02-23 06:46:50 +00:00
asarfaty 592302fd01 NSX|P: Use policy dhcp & mdproxy in plugin UT
Change-Id: I493520c50ef0673b538eb49d63300e0f998de901
2020-02-17 15:17:26 +00:00
asarfaty 398c86247a NSX|P: Support policy DHCP
IPv4 support for Policy DHCP depending on the NSX version & on config.
Including devstack support for configuration & cleanup, and admin utilility
for migration from MP implementation to Policy one.

IPv6 support will follow in a future patch.

Change-Id: I01bfb5bd530c63ca8b635bbebcac47659187077e
2020-02-13 11:47:21 +00:00