- Update BGP plugin for changes in neutron-dynamyic-routing
- Skip test for duplicate port MAC for NSX-V plugin
- Fix test for network creation in default AZ for NSX-V plugin
- Adapt .zuul.yaml for changes in tap-as-a-service
- Fix issues with requirements check job
- Minor changes to tox.ini
Change-Id: Idbf051e98d7c961273f46c6b6a1aaa9b358ab3d8
Bump neutron-lib, and osc-lib, and update some more requirements
Depends-on: Ie74ea517a403e6e2a7a4e0a245dd20e5281339e8
Change-Id: If34a9889fb0f137856f7c241788cf593e722d665
1.Upgrade pylint to 2.4.4, add exclusions to the tests, and
fix some lint errors in the code
2. Fix user creation with GRANT in MySQL 8.0(Ubuntu Focal)
In Ubuntu Bionic (18.04) mysql 5.7 version used to create
the user implicitly when using using the GRANT.
Ubuntu Focal (20.04) has mysql 8.0 and with mysql 8.0 there
is no implicit user creation with GRANT. We need to
create the user first before using GRANT command.
See also commit I97b0dcbb88c6ef7c22e3c55970211bed792bbd0d
3. Remove fwaas from the zuul.yaml
4. Remove DB migration test which is failing ue to FWaaS migration
with py38
5. Fix cover tests python version in .tox
6. fix requirememnts
Change-Id: I22654a5d5ccaad3185ae3365a90afba1ce870695
networking-l2gw and networking-l2gw-tempest-plugin are
imported to new location now and supposed to be retired from
openstack/namespace[1].
-https://review.opendev.org/#/c/744110/
Change-Id: I902ea79cdd3a8e56540ab44a7bd2f986f5d18bca
As neutron-fwaas is no longer maintained, get it from pypi instead of Git.
Also update neutron projects in requirements to latested released versions
Change-Id: I866d0b6f57f7b34ccc8bc998b8df729103497f6c
As a first step add coverage test as non-voting with a low threshold,
and exclude older plugins.
Also removing some unused code, and relocating tests-only code, and adding
some unit tests to improve coverage.
Change-Id: Ib7af0b5de49e1a0ee2927b01f2a5f71acf633fb5
Commit Idbfefe85dc0ddb04bd2d88fafcf3f6e751a1c3d7 added py38 to
the gate jobs.
This patch adds the necessary configuration for the vmware-nsx
Change-Id: I47a8b8b553f4a8b852508ccc4e8df48a1cb87832
Since it's no longer supported past Train, lets stop
running the tests.
Please also see the related neutron patch:
I1c171ab906a3b4c66558163ad26947ebf710a276
Change-Id: Ic5361ac8495493d45603a57fcaac5f8385c681b7
This patch slims down the test-requirements.txt and
lower-constraints.txt so that we only require what we really use/need.
It also updates the flake8 section of tox.ini to match [1] except H904
is not included herein since vmware-nsx doesn't translate messages.
[1] https://review.opendev.org/#/c/667723/1/tox.ini
Change-Id: I4e0b1564640cf38b90e084abb410bd4de6d76733
This patch bumps the hacking, bandit and flake8 requirements to match
suit with similar work (ex [1]). It also updates the code to fix a few
new pep8 errors as well as adds a local tox target for
requirements-check-dev.
[1] https://review.opendev.org/#/c/658245/
Change-Id: I6caeb52dc1a5842338ec989a742ae5989608e0da
Commit Ia4f4b335295c0e6add79fe0db5dd31b4327fdb54 removed all the
neutron-lbaas code from the master (Train) branch
Change-Id: I9035f6238773aad0591436c856550b7a5e01e687
This patch:
- Updates git.openstack based URLs to use opendev.
- Cleans up the lower-constraints.txt file to only include what we
really need.
Change-Id: I3eecd97c313c33c820ca2be8f01f6848244cd52a
vmware-nsx specific policies are defined as policy-in-code.
- vmware_nsx/policies/lsn.py, qos_queue.py and maclearning.py
are moved from the neutron repo.
- vmware_nsx/policies/providersecuritygroup.py is based on the difference
between etc/policy.json and the old neutron policy.json
- vmware_nsx/policies/security_group.py is based on
etc/policy.d/security-groups.json
- vmware_nsx/policies/network_gateway.py is based on
etc/policy.d/network-gateways.json
etc/policy.d/dynamic-routing.json and etc/policy.d/neutron-fwaas.json
have no policies specific to vmware-nsx, so they can be dropped and
we can use policy-in-code definitions in neutron-fwaas and
neutron-dynamic-routing.
etc/policy.d/routers.json and flow-classifier.json cannot be
converted into policy-in-code because the default policies are
different from those defined in neutron and networking-sfc.
Note that etc/policy.d/routers.json now has policies which are
different from the default policies defined in the neutron repo.
(Others are clean up by this commit.)
This commit depends on the following patches under review:
(neutron-fwaas policy-in-code support)
Depends-On: https://review.openstack.org/527282
(neutron-dynamic-routing policy-in-code support)
Depends-On: https://review.openstack.org/625429
(networking-sfc policy-in-code support)
Depends-On: https://review.openstack.org/625431
(Drop 3rd-party plugin specific policies)
Depends-On: https://review.openstack.org/625394
Partially Implements: blueprint neutron-policy-in-code
Co-Authored-By: Michal Kelner Mishali <mkelnermishal@vmware.com>
Co-Authored-By: Adit Sarfaty <asarfaty@vmware.com>
Change-Id: I96a9dbd759d54308abbc12ce65c97b06a76453cd
The commands used by constraints need at least tox 2.0.
Update to reflect reality, which should help with local running of
constraints targets.
Change-Id: I301278dd742037fd4a1ca498ace8e3a4e299bf56
As part of the python 3 first effort [1], this patch adds UT support for
python 3.6 by:
- Updating the zuul.yaml to include the py36 template and jobs.
- Adding a py36-dev target to tox.ini for local testing.
- Updating the upper constraints to use master rather than stable/rocky.
- Updating the version of eventlet used as previous 2x.x versions had
a python 3 bug for monkey patching.
- Consolidating the eventlet monkey patching in the code.
[1] https://governance.openstack.org/tc/goals/stein/python3-first.html
Change-Id: I3c11ac9dff9a2e25b33e8310929c961ffd0bcc52
Implementing the Octavia support for NSX-V & NSX-T.
Follow up patches will handle the TVD plugin, Status updates,
and migration.
Since Octavia is not (yet?) in the requirements, using a hack to allow unittests
to be skipped.
Co-Authored-by: Adit Sarfaty <asarfaty@vmware.com>
Change-Id: Iadb24e7eadcab658faf3e646cc528c2a8a6976e5
The new stable upper-constraints file is only available
after the openstack/requirements repository is branched.
This will happen around the RC1 timeframe.
Recheck and merge this change once the requirements
repository has been branched.
The CI system will work with this patch before the requirements
repository is branched because zuul configues the job to run
with a local copy of the file and defaults to the master branch.
However, accepting the patch will break the test configuration
on developers' local systems, so please wait until after the
requirements repository is branched to merge the patch.
Change-Id: I7ae697a8023c76ec352616b269150633acdea119
The release job will fail without a venv target in tox, so this patch
adds it to allow our release jobs to run.
Change-Id: I5cdeaed4455db352255906211d0092ab15e9a092
This patch is part of the community goals to enable python 3 first, and
only use python 2 when explict.
To do so, this patch:
- Makes python 3 the default env for non py27 tox targets.
- Adds a py3-dev target for running py3 locally.
- Refactors the pip install commands for stable dependency install into
their own target and refs them where needed.
- Updates the code to pass pep8 in python 3.
- Bumps the version of pylint to 1.7.1 to address some py3 issues in
earlier versions.
As part of this effort we should also look into making python 3 the
default for our VMware NSX 3rd party CI jobs.
Change-Id: Ibaa3e9d717f32ffb6479346163c14d4be7df50cf
This patch updates tox ini to support both a dev and build target;
lower-constraints-dev and lower-constraints respectively.
The dev target is for running locally so it manually installs the
required projects whereas the build target doesn't as per zuul's
required project definition in project.yaml.
Also see https://review.openstack.org/#/c/573386/
Change-Id: I0e6cf1ca0f4b07c080ff5a7b221dabedfd8bf6cf
Create a tox environment for running the unit tests against the lower
bounds of the dependencies.
Create a lower-constraints.txt to be used to enforce the lower bounds
in those tests.
Add openstack-tox-lower-constraints job to the zuul configuration.
See http://lists.openstack.org/pipermail/openstack-dev/2018-March/128352.html
for more details.
Change-Id: Ia65cd41c6d0f4a4847458188cc5afddb06035a23
This patch adds the py27-dev and pep8-dev tox targets that enable local
(outside the gate) running of py27 and pep8 using master branches from
our sub-project dependencies as discussed in [1] in editable mode.
If additional local/dev targets are needed (ex functional) they can be
added in the same fashion as shown herein.
With this patch to run pep8 locally use:
tox -e pep8-dev
And to run py27 locally:
tox -e py27-dev
The editable projects will be under .tox/{env}/src/
This patch also adds to our devstack/lib scripts by cleaning out any
existing (dependency git) projects and installing them in editable mode
from git.
Depends-On: https://review.openstack.org/552865
Depends-On: https://review.openstack.org/554297
[1] http://lists.openstack.org/pipermail/openstack-dev/2018-March/128328.html
Change-Id: I4d0dcba15e5b30e4cfa7335edf9c2dd961530184
Remove tox_install.sh, we have now all dependencies in
global-requirements and don't need this setup anymore.
Update tox.ini for this, move constraints into deps for proper
working.
This enables proper installation of dependencies from git.
Depends-On: https://review.openstack.org/552865
Depends-On: https://review.openstack.org/554297
Change-Id: I49d432bdf01221d0244449c4e2be807d0f646afa
ostestr is no longer installed by default by infra and will be totally
removed longer term; stestr [1] is its replacement.
This is the reason out gate is failing with the following today:
nsx/tools/ostestr_compat_shim.sh: ostestr: not found
This patch moves us to stestr by:
- Updating tox.ini to use stestr rather than call ostestr_compat_shim.sh
and in turn ostestr.
- Removing ostestr_compat_shim.sh as its no longer used.
For more details on stestr see [1].
Also note that this is a quick migration to stestr to get the gate
working; additional tweaks may come up.
[1] http://stestr.readthedocs.io/en/latest/MANUAL.html
Change-Id: I9a871d3542c2f2615d757c0009ea3d6695f0e3f7
This now existsin the vmware_nsx_tempest_plugin
Change-Id: I76e5856deeeb06b87675314635d06aa0291143eb
Depends-On: I804c3fd1e0c9cbeb454677e7951072ad74391fec
Now that there exists only a gate job for Python 3.5 and not 3.4,
we should remove those references to the 3.4 that is untested.
Change-Id: Idb66d124611de879b33c0f8bd20f37f24da443b4
There is no this directory openstack/common which was used to keep codes from
oslo-incubator, we have retired oslo-incubator. Removing openstack/common from
all OpenStack code in favor of the Oslo libraries is a project wide goal
for the Ocata release. So don't use this directory any more. We should drop it
for improving searching efficiency.
Change-Id: I23f918ee6cd9939bfd46c4bf77cf56c0995c6e35
Model migration tests were not run because of incorrect import.
Run them in unit test mode instead of functional jobs.
Also fix existing migrations and models which are not in sync.
Change-Id: I4f7362972929308201776214fe01c007f14a6580
Openstack infra now supports upper constraints for
all jobs. Updated tox.ini to use upper constraints
for all jobs.
Change-Id: Ie446293f52a87ba89e090d566e3d62141a5c4f51
Closes-Bug: #1614361
Many deprecations are triggered early (on imports, for example)
before the warnings are enabled by the WarningsFixture in the
base test class.
To make sure all DeprecationWarning messages are emitted we enable
them via the PYTHONWARNINGS environment variable.
Change-Id: I02725cb71f5a55ccc257e3897b4141f99f4ab8d3
The service insertion feature allows us to redirect some of the NSX traffic to an external
security vendor like Palo-Alto or checkpoint for advanced inspection.
The implementation contains:
Enable the flow classifier plugin, and use it to create redirect rules on NSX
When the flow classifier plugin is initialized a new security group is created
and added to the configured service profile
When a vm port with port security is created/updated, it is added to this security group
When the admin user create a flow classifier entry, a backed redirect rule will be created.
DocImpact: new NSXV Configuration parameters:
service_insertion_profile_id = <service profile id, i.e. serviceprofile-1>
DocImpact: The flow classifier methods should be added to the policy.json as admin only
Change-Id: I67a132d4b35764c6940516a8365a2749d574aad2
As bug 1568706 uncovered, we were using zuul-cloner
in our gate jobs; this was preventing our translation from
syncing.
After digging into this issue a number of changes in this
associated logic were found to not be in sync with neutron.
This patch updates out tox/tools logic to follow that of neutron.
In addition this patch fixes any pylint checks that were failing to
make pep8 pass.
IMPORTANT:
Please review closely, not only to the tools/tox updates but also
to the ignored pylint checks in the code. We only want to disable
checks where appropriate.
Change-Id: I6c5fee3ca3073ad079eac1636cc3b9ec45926a68
Closes-Bug: #1568706
Now that there is a passing gate job, we can claim support for
Python 3.5 in the classifier. This patch also adds the convenience
py35 venv.
Change-Id: I14f4f90ca0f0c863f9175934f63c95b9115f9b8c
This patch adds support for Port Mirroring feature for
NSXv3 plugin. This driver implements the Tap-as-a-Service
APIs and maps the tap-flow and tap-service resources
to backend PortMirroring objects.
Closes-Bug: #1598318
Change-Id: I5719fbbacfd3ec39250c59ec73cac2dc84af596d
This patch adds support to automatically generate config files
for vmware-nsx repo using oslo config generator[1] for all
VMware plugins.
Tox can be used to generate a sample config file using the
following command:
tox -e genconfig
This will generate a config file "nsx.ini.sample" under
vmware-nsx/etc/ folder.
This patch also modifies devstack scripts to use the
auto-generated config files and adds more information to help
texts in config modules.
[1] http://docs.openstack.org/developer/oslo.config/generator.html
Change-Id: Iff4ea37b52616295b262ead53947acb5b0cd9cd7
Partial-Bug: #1568215
Salvatore Orlando