From 18a321d510329206f2488c9e20a64e473b678ba5 Mon Sep 17 00:00:00 2001 From: Thanh Ha Date: Wed, 19 Sep 2018 09:46:14 -0400 Subject: [PATCH] Fix options.update is not 'all' if no config If the user does not have 'update' in their configuration ensure we are properly defaulting to 'all' and not None. Change-Id: I65ddc49066119db0947801203ac88cb69153d1b0 Signed-off-by: Thanh Ha --- jenkins_jobs/cli/entry.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/jenkins_jobs/cli/entry.py b/jenkins_jobs/cli/entry.py index 30373b490..77669b0d6 100644 --- a/jenkins_jobs/cli/entry.py +++ b/jenkins_jobs/cli/entry.py @@ -94,8 +94,9 @@ class JenkinsJobs(object): # Note: CLI options override config file options. if getattr(self.options, 'update', None) is None: - self.options.update = str(self.jjb_config.builder.get('update', - 'all')) + self.options.update = self.jjb_config.builder.get('update') + if self.options.update is None: + self.options.update = 'all' if getattr(self.options, 'plugins_info_path', None) is not None: with io.open(self.options.plugins_info_path, 'r',