From 516858a9c457c950836d1306c452bc1b6255d461 Mon Sep 17 00:00:00 2001
From: tanhengyeow <E0032242@u.nus.edu>
Date: Sun, 12 Aug 2018 21:49:57 +0800
Subject: [PATCH] ant: Refactor code to improve readability

Change-Id: I3d56a18b140e6660c91e144f5bd27db3d8fbded3
Signed-off-by: Tan Heng Yeow <E0032242@u.nus.edu>
---
 jenkins_jobs/modules/builders.py   | 24 +++++++++++++-----------
 tests/builders/fixtures/ant002.xml |  7 ++++---
 2 files changed, 17 insertions(+), 14 deletions(-)

diff --git a/jenkins_jobs/modules/builders.py b/jenkins_jobs/modules/builders.py
index 77ca9e4fd..b5b8ba860 100644
--- a/jenkins_jobs/modules/builders.py
+++ b/jenkins_jobs/modules/builders.py
@@ -301,28 +301,30 @@ def ant(registry, xml_parent, data):
     """
     ant = XML.SubElement(xml_parent, 'hudson.tasks.Ant')
 
-    mappings = []
     if type(data) is str:
         # Support for short form: -ant: "target"
         data = {'targets': data}
+
+    mapping = [
+        ('targets', 'targets', None),
+        ('buildfile', 'buildFile', None),
+        ('ant-name', 'antName', 'default'),
+    ]
+    helpers.convert_mapping_to_xml(ant, data, mapping, fail_required=False)
+
+    mapping = []
     for setting, value in sorted(data.items()):
-        if setting == 'targets':
-            mappings.append(('', 'targets', value))
-        if setting == 'buildfile':
-            mappings.append(('', 'buildFile', value))
         if setting == 'properties':
             properties = value
             prop_string = ''
             for prop, val in properties.items():
                 prop_string += "%s=%s\n" % (prop, val)
-            mappings.append(('', 'properties', prop_string))
+            mapping.append(('', 'properties', prop_string))
         if setting == 'java-opts':
-            jopt_string = ' '.join(value)
-            mappings.append(('', 'antOpts', jopt_string))
+            jopt_string = '\n'.join(value)
+            mapping.append(('', 'antOpts', jopt_string))
 
-    mappings.append(('ant-name', 'antName', 'default'))
-
-    helpers.convert_mapping_to_xml(ant, data, mappings, fail_required=True)
+    helpers.convert_mapping_to_xml(ant, data, mapping, fail_required=True)
 
 
 def trigger_remote(registry, xml_parent, data):
diff --git a/tests/builders/fixtures/ant002.xml b/tests/builders/fixtures/ant002.xml
index 160bfd04a..9152f87a5 100644
--- a/tests/builders/fixtures/ant002.xml
+++ b/tests/builders/fixtures/ant002.xml
@@ -2,13 +2,14 @@
 <project>
   <builders>
     <hudson.tasks.Ant>
+      <targets>debug test install</targets>
       <buildFile>build.xml</buildFile>
-      <antOpts>-ea -Xmx512m</antOpts>
+      <antName>Standard Ant</antName>
+      <antOpts>-ea
+-Xmx512m</antOpts>
       <properties>builddir=/tmp/
 failonerror=True
 </properties>
-      <targets>debug test install</targets>
-      <antName>Standard Ant</antName>
     </hudson.tasks.Ant>
   </builders>
 </project>