From f95db7c756383e461ca49e4f5a9028370331c55e Mon Sep 17 00:00:00 2001 From: Andrew Mellen Date: Thu, 12 Apr 2018 11:38:16 -0400 Subject: [PATCH] Sort views list jobs Change-Id: I27613393fd423fb514e9adfa44db7f12c5249b52 --- jenkins_jobs/modules/view_list.py | 1 + tests/views/fixtures/view_list001.yaml | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/jenkins_jobs/modules/view_list.py b/jenkins_jobs/modules/view_list.py index 36e28a62d..e657b3e63 100644 --- a/jenkins_jobs/modules/view_list.py +++ b/jenkins_jobs/modules/view_list.py @@ -144,6 +144,7 @@ class List(jenkins_jobs.modules.base.Base): XML.SubElement(jn_xml, 'comparator', {'class': 'hudson.util.CaseInsensitiveComparator'}) if jobnames is not None: + jobnames = sorted(jobnames) # Job names must be sorted in the xml for jobname in jobnames: XML.SubElement(jn_xml, 'string').text = str(jobname) diff --git a/tests/views/fixtures/view_list001.yaml b/tests/views/fixtures/view_list001.yaml index 9b0400e58..9d83879b9 100644 --- a/tests/views/fixtures/view_list001.yaml +++ b/tests/views/fixtures/view_list001.yaml @@ -5,8 +5,8 @@ filter-executors: true filter-queue: true job-name: - job-name-1 - - job-name-2 - job-name-3 + - job-name-2 columns: - status - weather