jjb
/
python-jenkins
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(1 comment)

Patch-set: 6
Attention: {"person_ident":"Gerrit User 35874 \u003c35874@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35866\u003e replied on the change"}
This commit is contained in:
Gerrit User 35866 2023-03-24 06:17:54 +00:00 committed by Gerrit Code Review
parent 61f7927f68
commit 09bee6b316
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
bb772c3497d4b7891060993c7acadd15dcfdb5f5
View File

@ -16,6 +16,24 @@
"message": "Small suggestion\nThe Pythonic way doing this is list comprehension. May improve the performance in large scale data iteration.\nLike\n\n```\nreturn [\n {\n \"name\": c[\"displayName\"],\n \"description\": c[\"description\"],\n ...\n }\n for c in nodes_data[\"computer\"]\n]\n```",
"revId": "bb772c3497d4b7891060993c7acadd15dcfdb5f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "70e2341e_4b2602be",
"filename": "jenkins/__init__.py",
"patchSetId": 4
},
"lineNbr": 1553,
"author": {
"id": 35866
},
"writtenOn": "2023-03-24T06:17:54Z",
"side": 1,
"message": "I\u0027ve added the mentioned changes; please check and let me know if you have further suggestions.",
"parentUuid": "a41a4332_361db34d",
"revId": "bb772c3497d4b7891060993c7acadd15dcfdb5f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}