From 9f6c274bd2877253990a4e490d3ccdaf7db817ab Mon Sep 17 00:00:00 2001 From: Gerrit User 4146 <4146@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Mon, 13 May 2019 16:24:51 +0000 Subject: [PATCH] Update patch set 2 Patch Set 2: Code-Review-1 (2 comments) Patch-set: 2 Label: Code-Review=-1 --- 44cb40aafa64b1c26889a6de9c92bf993466eae1 | 38 ++++++++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 44cb40aafa64b1c26889a6de9c92bf993466eae1 diff --git a/44cb40aafa64b1c26889a6de9c92bf993466eae1 b/44cb40aafa64b1c26889a6de9c92bf993466eae1 new file mode 100644 index 0000000..5c02b51 --- /dev/null +++ b/44cb40aafa64b1c26889a6de9c92bf993466eae1 @@ -0,0 +1,38 @@ +{ + "comments": [ + { + "key": { + "uuid": "dfbec78f_7ba26bb0", + "filename": "tasks/config.yaml", + "patchSetId": 2 + }, + "lineNbr": 14, + "author": { + "id": 4146 + }, + "writtenOn": "2019-05-13T16:24:51Z", + "side": 1, + "message": "This checks that puppet_environmentpath is a truthy value but the old check was specifically that the value was empty string.\n\nIs this an equivalent (or otherwise correct) update?", + "revId": "44cb40aafa64b1c26889a6de9c92bf993466eae1", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "dfbec78f_fb95fb40", + "filename": "tasks/main.yaml", + "patchSetId": 2 + }, + "lineNbr": 98, + "author": { + "id": 4146 + }, + "writtenOn": "2019-05-13T16:24:51Z", + "side": 1, + "message": "This comparison and the one below imply the check on the earlier file was not updated properly. I think we may need a not as below?", + "revId": "44cb40aafa64b1c26889a6de9c92bf993466eae1", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + } + ] +} \ No newline at end of file